Transliteration map fix #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Ukrainian support
Simplify gsub calls
Handle empty strings and strings that contain lines without text.
* These were causing deploys to fail.
Require rake issue
Fixed typo in readme.
Stratus3D
force-pushed
the
transliteration-map-fix
branch
from
26915b0 to
5c509b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address everything in #13.
I had to modify the master branch from our repo so that I could create this PR. We've added support for Ukrainian and that forced us to rework quite a bit of the code. Our version does work though, the only downside is that sometimes it has to guess which language it's transliterating from when coming from Ukrainian or Russian. I'll be happy to do a second PR to add support for Ukrainian if you want it.