-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enroll non-UMich users (iss. #221, #169, #252, #291) #247
Commits on Nov 16, 2021
-
tl-its-umich-edu#221 - add methods for non-UMich users
Very simplistic approach for now. Should be refactored to reduce duplication of code before merging upstream.
Configuration menu - View commit details
-
Copy full SHA for 91b8e24 - Browse repository at this point
Copy the full SHA 91b8e24View commit details
Commits on Nov 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d53814f - Browse repository at this point
Copy the full SHA d53814fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6b295e - Browse repository at this point
Copy the full SHA a6b295eView commit details
Commits on Nov 29, 2021
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for a90cca4 - Browse repository at this point
Copy the full SHA a90cca4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c123226 - Browse repository at this point
Copy the full SHA c123226View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4416ba2 - Browse repository at this point
Copy the full SHA 4416ba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fb37e7 - Browse repository at this point
Copy the full SHA 7fb37e7View commit details -
tl-its-umich-edu#221 - add config svc to enroll ext user method
Also, temporarily accept results as JSON string. Method based on one for enrolling existing users
Configuration menu - View commit details
-
Copy full SHA for 9e5fd2c - Browse repository at this point
Copy the full SHA 9e5fd2cView commit details -
tl-its-umich-edu#221 - method based on enroll existing users
Temporarily use JSON results as return value.
Configuration menu - View commit details
-
Copy full SHA for 15fc7e0 - Browse repository at this point
Copy the full SHA 15fc7e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef1975e - Browse repository at this point
Copy the full SHA ef1975eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3e4540 - Browse repository at this point
Copy the full SHA b3e4540View commit details
Commits on Dec 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5ca5ffa - Browse repository at this point
Copy the full SHA 5ca5ffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8410c8 - Browse repository at this point
Copy the full SHA a8410c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e185db - Browse repository at this point
Copy the full SHA 4e185dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for df7d7be - Browse repository at this point
Copy the full SHA df7d7beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1980e2e - Browse repository at this point
Copy the full SHA 1980e2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d52cfa0 - Browse repository at this point
Copy the full SHA d52cfa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ddcf53 - Browse repository at this point
Copy the full SHA 9ddcf53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2826718 - Browse repository at this point
Copy the full SHA 2826718View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32c6d37 - Browse repository at this point
Copy the full SHA 32c6d37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ddd3a3 - Browse repository at this point
Copy the full SHA 3ddd3a3View commit details
Commits on Dec 9, 2021
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for 14c32b4 - Browse repository at this point
Copy the full SHA 14c32b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a04f72 - Browse repository at this point
Copy the full SHA 0a04f72View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffc189b - Browse repository at this point
Copy the full SHA ffc189bView commit details
Commits on Dec 14, 2021
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for d911752 - Browse repository at this point
Copy the full SHA d911752View commit details -
tl-its-umich-edu#221 - add admin API token config support
`adminApiToken` may end up replacing `adminApiClientId` and `adminApiSecret` altogether.
Configuration menu - View commit details
-
Copy full SHA for c75ba78 - Browse repository at this point
Copy the full SHA c75ba78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83187fa - Browse repository at this point
Copy the full SHA 83187faView commit details -
tl-its-umich-edu#221 - add admin API token config support
`adminApiToken` may end up replacing `adminApiClientId` and `adminApiSecret` altogether.
Configuration menu - View commit details
-
Copy full SHA for adc89dc - Browse repository at this point
Copy the full SHA adc89dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01834ea - Browse repository at this point
Copy the full SHA 01834eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3796f46 - Browse repository at this point
Copy the full SHA 3796f46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fc754b - Browse repository at this point
Copy the full SHA 5fc754bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c737b7 - Browse repository at this point
Copy the full SHA 9c737b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6b9b7a - Browse repository at this point
Copy the full SHA e6b9b7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ba42b4 - Browse repository at this point
Copy the full SHA 7ba42b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78317c4 - Browse repository at this point
Copy the full SHA 78317c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20074ff - Browse repository at this point
Copy the full SHA 20074ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72712ed - Browse repository at this point
Copy the full SHA 72712edView commit details -
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for 9c51430 - Browse repository at this point
Copy the full SHA 9c51430View commit details
Commits on Dec 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 32297ab - Browse repository at this point
Copy the full SHA 32297abView commit details
Commits on Dec 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bbe1a78 - Browse repository at this point
Copy the full SHA bbe1a78View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf86f08 - Browse repository at this point
Copy the full SHA bf86f08View commit details -
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for 49202f0 - Browse repository at this point
Copy the full SHA 49202f0View commit details -
tl-its-umich-edu#221 - resolve handling of invitation results
There are 3 distinct things happening in this method, creating users as needed, inviting new users, and enrolling all users. Each process returns different information, so it seems the best way to handle that and return it all to the API user is as a single JSON response.
Configuration menu - View commit details
-
Copy full SHA for c39efc2 - Browse repository at this point
Copy the full SHA c39efc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a9d03c - Browse repository at this point
Copy the full SHA 6a9d03cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffc1d88 - Browse repository at this point
Copy the full SHA ffc1d88View commit details -
Configuration menu - View commit details
-
Copy full SHA for c13618d - Browse repository at this point
Copy the full SHA c13618dView commit details
Commits on Dec 17, 2021
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for f8bc2fb - Browse repository at this point
Copy the full SHA f8bc2fbView commit details -
tl-its-umich-edu#221 - move create users methods
Moved `createExternalUsers()` and `createExternalUser()` methods from `SectionApiHandler` to `AdminApiHandler`. As suggested by @ssciolla in PR tl-its-umich-edu#247 comment: https://github.com/tl-its-umich-edu/canvas-course-manager-next/pull/247/files/c13618dcfac8c22935d81e493f3200fce344bfe1#r770959269
Configuration menu - View commit details
-
Copy full SHA for f8b3340 - Browse repository at this point
Copy the full SHA f8b3340View commit details -
tl-its-umich-edu#221 - add module to complete
InvitationService
Added `InvitationModule` and necessary references in order to use `InvitationService` as a full-fledged service. As suggested by @ssciolla in PR tl-its-umich-edu#247 comment: https://github.com/tl-its-umich-edu/canvas-course-manager-next/pull/247/files/c13618dcfac8c22935d81e493f3200fce344bfe1#r771579036
Configuration menu - View commit details
-
Copy full SHA for 77de934 - Browse repository at this point
Copy the full SHA 77de934View commit details -
tl-its-umich-edu#221 - return invitation results correctly
As I was testing this, the `inviteResults` kept coming back as `null`, even though I could see results in the console log. I thought it was a question of timing with the async method, but then I realized I wasn't returning from the method correctly. It's much better now.
Configuration menu - View commit details
-
Copy full SHA for 62e42c2 - Browse repository at this point
Copy the full SHA 62e42c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51c4cdb - Browse repository at this point
Copy the full SHA 51c4cdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ec4362 - Browse repository at this point
Copy the full SHA 4ec4362View commit details
Commits on Dec 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 32f9fe0 - Browse repository at this point
Copy the full SHA 32f9fe0View commit details
Commits on Dec 20, 2021
-
tl-its-umich-edu#252 - check for user existence
@ssciolla: I'm not sure whether I wrote this API entry with the security we would like. Give me feedback.
2Configuration menu - View commit details
-
Copy full SHA for 761c3d0 - Browse repository at this point
Copy the full SHA 761c3d0View commit details
Commits on Dec 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 455e6ac - Browse repository at this point
Copy the full SHA 455e6acView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfce3ab - Browse repository at this point
Copy the full SHA dfce3abView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8b3109 - Browse repository at this point
Copy the full SHA f8b3109View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59b9f04 - Browse repository at this point
Copy the full SHA 59b9f04View commit details
Commits on Jan 4, 2022
-
tl-its-umich-edu#221 - remove invitation API URL
Remove invitation API URL, add note about picking good key name, and update references to renumbered steps.
Configuration menu - View commit details
-
Copy full SHA for 64ad253 - Browse repository at this point
Copy the full SHA 64ad253View commit details
Commits on Jan 5, 2022
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for 4596f2e - Browse repository at this point
Copy the full SHA 4596f2eView commit details -
tl-its-umich-edu#221 - new
CanvasUserLoginEmail
interfaceAdded new `CanvasUserLoginEmail` interface for those times we need to use a `CanvasUser` with `login_id` and `email`. @ssciolla and I discussed making this change before the Dec 2021 holiday break. I would rather have one interface for both purposes, but I can't get it to work right. Perhaps that's due to my limited TypeScript experience.
Configuration menu - View commit details
-
Copy full SHA for 0decd1b - Browse repository at this point
Copy the full SHA 0decd1bView commit details
Commits on Jan 7, 2022
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for 68b3b4a - Browse repository at this point
Copy the full SHA 68b3b4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53dff50 - Browse repository at this point
Copy the full SHA 53dff50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b3bad0 - Browse repository at this point
Copy the full SHA 0b3bad0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b13740 - Browse repository at this point
Copy the full SHA 3b13740View commit details -
Configuration menu - View commit details
-
Copy full SHA for 956a649 - Browse repository at this point
Copy the full SHA 956a649View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce38c2f - Browse repository at this point
Copy the full SHA ce38c2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e18066d - Browse repository at this point
Copy the full SHA e18066dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1de3e9f - Browse repository at this point
Copy the full SHA 1de3e9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e795701 - Browse repository at this point
Copy the full SHA e795701View commit details -
Configuration menu - View commit details
-
Copy full SHA for c41cc14 - Browse repository at this point
Copy the full SHA c41cc14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e2db8a - Browse repository at this point
Copy the full SHA 2e2db8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15d65e2 - Browse repository at this point
Copy the full SHA 15d65e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for aeb1efa - Browse repository at this point
Copy the full SHA aeb1efaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5894203 - Browse repository at this point
Copy the full SHA 5894203View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b24364 - Browse repository at this point
Copy the full SHA 0b24364View commit details
Commits on Jan 10, 2022
-
tl-its-umich-edu#291 - removed, so user can accept terms
From Canvas API docs: `user[terms_of_use]` - Whether the user accepts the terms of use. Required if this is a self-registration and this canvas instance requires users to accept the terms (on by default). If this is true, it will mark the user as having accepted the terms of use.
Configuration menu - View commit details
-
Copy full SHA for 5eee9fc - Browse repository at this point
Copy the full SHA 5eee9fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b035b8 - Browse repository at this point
Copy the full SHA 8b035b8View commit details
Commits on Jan 11, 2022
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for a578eec - Browse repository at this point
Copy the full SHA a578eecView commit details -
tl-its-umich-edu#220 - added
ExternalEnrollment
typeAlso corrected minor spacing mistake. (eslint didn't notice that one. 😉)
Configuration menu - View commit details
-
Copy full SHA for 18b1149 - Browse repository at this point
Copy the full SHA 18b1149View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a8ecf8 - Browse repository at this point
Copy the full SHA 1a8ecf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3055b4d - Browse repository at this point
Copy the full SHA 3055b4dView commit details -
Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm …
…into 221-enroll-non-umich * '221-enroll-non-umich' of https://github.com/lsloan/ccm: tl-its-umich-edu#220 - use new `ExternalEnrollment` return type
Configuration menu - View commit details
-
Copy full SHA for 5669210 - Browse repository at this point
Copy the full SHA 5669210View commit details -
Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm …
…into 221-enroll-non-umich * '221-enroll-non-umich' of https://github.com/lsloan/ccm: tl-its-umich-edu#220 - use new `ExternalEnrollment` return type
Configuration menu - View commit details
-
Copy full SHA for 799b3a3 - Browse repository at this point
Copy the full SHA 799b3a3View commit details -
Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm …
…into 221-enroll-non-umich * '221-enroll-non-umich' of https://github.com/lsloan/ccm:
Configuration menu - View commit details
-
Copy full SHA for 49caaa9 - Browse repository at this point
Copy the full SHA 49caaa9View commit details
Commits on Jan 17, 2022
-
tl-its-umich-edu#221 - remark-lint coddling
I don't see any problem with README.md, but remark-lint has complained about it. Let's see whether the changes I've made satisfy it.
Configuration menu - View commit details
-
Copy full SHA for aca1cef - Browse repository at this point
Copy the full SHA aca1cefView commit details
Commits on Jan 20, 2022
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for c23d0ca - Browse repository at this point
Copy the full SHA c23d0caView commit details
Commits on Jan 31, 2022
-
tl-its-umich-edu#221 - check roles user is allowed to assign
Finally! I had trouble with TypeScript syntax surrounding `enum` types. I finally have a solution that works. It may not be elegant. I know it needs cleaning up, which I'll do tomorrow.
Configuration menu - View commit details
-
Copy full SHA for 197fd3a - Browse repository at this point
Copy the full SHA 197fd3aView commit details
Commits on Feb 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e6b300d - Browse repository at this point
Copy the full SHA e6b300dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba07db4 - Browse repository at this point
Copy the full SHA ba07db4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e616abc - Browse repository at this point
Copy the full SHA e616abcView commit details
Commits on Feb 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 74347c6 - Browse repository at this point
Copy the full SHA 74347c6View commit details
Commits on Feb 3, 2022
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich Resolved conflicts: * ccm_web/server/src/api/api.controller.ts * ccm_web/server/src/api/api.service.ts
Configuration menu - View commit details
-
Copy full SHA for b62821f - Browse repository at this point
Copy the full SHA b62821fView commit details -
tl-its-umich-edu#221 - reorg imports
Suggested by @ssciolla in tl-its-umich-edu#247 (comment).
Configuration menu - View commit details
-
Copy full SHA for 0d045e8 - Browse repository at this point
Copy the full SHA 0d045e8View commit details
Commits on Feb 4, 2022
-
tl-its-umich-edu#221 - attempt to use NestJS HttpMethod
As suggested by @ssciolla, I'm trying to use HttpMethod instead of simple Axios for Cirrus requests. The previous use of Axios seems to be masking details from error responses. However, this doesn't seem to work at all. I can't even tell whether the request is being sent to Cirrus.
Configuration menu - View commit details
-
Copy full SHA for 6933474 - Browse repository at this point
Copy the full SHA 6933474View commit details -
tl-its-umich-edu#221 - error handling changes
The error handling code makes some assumptions about the structure of responses from the Canvas API. In the case of creating users, when there were errors (e.g., the user already exists, etc.) this code didn't recognize it as a proper Canvas error, because it had a different format. So, added a way for other error message formats to be accepted.
Configuration menu - View commit details
-
Copy full SHA for d66b3ed - Browse repository at this point
Copy the full SHA d66b3edView commit details
Commits on Feb 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a424e10 - Browse repository at this point
Copy the full SHA a424e10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35f8a0b - Browse repository at this point
Copy the full SHA 35f8a0bView commit details -
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for dfd06f4 - Browse repository at this point
Copy the full SHA dfd06f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 377baf8 - Browse repository at this point
Copy the full SHA 377baf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38e68e2 - Browse repository at this point
Copy the full SHA 38e68e2View commit details
Commits on Feb 9, 2022
-
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for 79dd288 - Browse repository at this point
Copy the full SHA 79dd288View commit details -
tl-its-umich-edu#221 - working request using
HttpModule
A lot of gratitude goes to @ssciolla for helping with this. I was making a TS newbie mistake which caused an error. I couldn't tell that the error wasn't coming from the Cirrus request.
Configuration menu - View commit details
-
Copy full SHA for 4132b66 - Browse repository at this point
Copy the full SHA 4132b66View commit details -
tl-its-umich-edu#221 - improvements in invitation service
Better error handling and return a more descriptive type.
Configuration menu - View commit details
-
Copy full SHA for b090610 - Browse repository at this point
Copy the full SHA b090610View commit details
Commits on Feb 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9fab557 - Browse repository at this point
Copy the full SHA 9fab557View commit details -
tl-its-umich-edu#221 - move swagger link to top
This change isn't strictly related to the issue, but I prefer the Swagger link to appear at the top of the page. With the app loaded into an iframe and the iframe doesn't fit entirely within the page's display (at least, not in my browser), there's a lot of scrolling within scrolling I need to do when the link is at the bottom of the page. It's much simpler at the top. Plus, with the link at the top, we could also add a "DEVELOPMENT MODE" banner there, if we'd like.
Configuration menu - View commit details
-
Copy full SHA for ba63309 - Browse repository at this point
Copy the full SHA ba63309View commit details -
tl-its-umich-edu#221 - no
InvalidTokenInterceptor
for admins@pushyamig reported a problem with this in Slack (https://umich-its-annarbor.slack.com/messages/G0130F688N6/p1644339699163449).
Configuration menu - View commit details
-
Copy full SHA for 772a7f4 - Browse repository at this point
Copy the full SHA 772a7f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f77ec3 - Browse repository at this point
Copy the full SHA 4f77ec3View commit details -
tl-its-umich-edu#221 - move role check from service to controller
Also regroup code and simplify getting of account ID number.
Configuration menu - View commit details
-
Copy full SHA for 288c5da - Browse repository at this point
Copy the full SHA 288c5daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85830e9 - Browse repository at this point
Copy the full SHA 85830e9View commit details
Commits on Feb 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d150e9f - Browse repository at this point
Copy the full SHA d150e9fView commit details -
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for a8d5c1f - Browse repository at this point
Copy the full SHA a8d5c1fView commit details -
tl-its-umich-edu#221 - solve some of our invalid email problems
I just noticed the `IsEmail` validator. It's going to be very helpful to us. I discovered that if the input contains invalid email addresses, Canvas is OK with that and creates the account if it doesn't exist. Not ideal. Even worse, the next step of the process passes the email addresses (including the invalid ones) that need to be invited to Cirrus. Unfortunately, when Cirrus gets invalid email addresses in the batch input, the entire batch fails, so nobody gets an invitation. That means accounts were created (and subsequent enrollments were made for them), but no invitations were sent. I was thinking that it may mean the process would need to be reworked to look everybody up FIRST, attempt to invite that batch of new people, and if that succeeds, then do the account creation. The order of those steps and the additional number of steps is not desirable. Now that we can call the entire request invalid if any email addresses are invalid, that should save us from any major changes. I will test further to verify.
Configuration menu - View commit details
-
Copy full SHA for 7a9cc00 - Browse repository at this point
Copy the full SHA 7a9cc00View commit details
Commits on Feb 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e9a62cc - Browse repository at this point
Copy the full SHA e9a62ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef3654b - Browse repository at this point
Copy the full SHA ef3654bView commit details -
tl-its-umich-edu#221 - attempt to key results by email
I'd like to get @ssciolla's feedback on this.
Configuration menu - View commit details
-
Copy full SHA for 2dc9464 - Browse repository at this point
Copy the full SHA 2dc9464View commit details -
tl-its-umich-edu#221 - better response structuring with
Object
Using `Object` seems to be better than `Map`. Also moved the code to after the invitation step to include those results.
Configuration menu - View commit details
-
Copy full SHA for a3e35c5 - Browse repository at this point
Copy the full SHA a3e35c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21e9677 - Browse repository at this point
Copy the full SHA 21e9677View commit details -
tl-its-umich-edu#221 - add login_id
This makes it possible to correlate `CanvasEnrollment` objects with `CanvasUserLoginEmail` ones.
Configuration menu - View commit details
-
Copy full SHA for 7a00c32 - Browse repository at this point
Copy the full SHA 7a00c32View commit details -
tl-its-umich-edu#221 - return
loginId
(email) with resultsBecause the external user enrollment process is based on each user's email address (which is used as their login ID), it's important to include that value in the response. I've also renamed the `userId` variable to `loginId` for clarity and consistency.
Configuration menu - View commit details
-
Copy full SHA for 76c128b - Browse repository at this point
Copy the full SHA 76c128bView commit details
Commits on Feb 17, 2022
-
tl-its-umich-edu#221 - pulled response change PR from @ssciolla
Fixes some problems I had asked for help with. Also makes other changes to response format.
Configuration menu - View commit details
-
Copy full SHA for f350a78 - Browse repository at this point
Copy the full SHA f350a78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51131d0 - Browse repository at this point
Copy the full SHA 51131d0View commit details
Commits on Feb 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ed51145 - Browse repository at this point
Copy the full SHA ed51145View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c82718 - Browse repository at this point
Copy the full SHA 0c82718View commit details -
tl-its-umich-edu#221 - add
InvitationConfig
castThis makes accessing the properties (`apiURL`, `apiEntityID`, etc.) of the object easier and eliminate IDE warnings.
Configuration menu - View commit details
-
Copy full SHA for b0d5a71 - Browse repository at this point
Copy the full SHA b0d5a71View commit details -
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich Conflicts: * ccm_web/server/src/api/api.admin.handler.ts * ccm_web/server/src/api/api.section.handler.ts * ccm_web/server/src/api/api.utils.ts * ccm_web/server/src/config.ts * config/.env.sample
Configuration menu - View commit details
-
Copy full SHA for 7fca2a3 - Browse repository at this point
Copy the full SHA 7fca2a3View commit details -
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for b014cc9 - Browse repository at this point
Copy the full SHA b014cc9View commit details
Commits on Feb 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 13ce4be - Browse repository at this point
Copy the full SHA 13ce4beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bfa0c5 - Browse repository at this point
Copy the full SHA 7bfa0c5View commit details -
tl-its-umich-edu#221 - more eslint god appeasement 🗿🗿🗿🗿🗿
eslint in MS' Visual Studio Code isn't that great. It told me that the previous commit was all that needed to be fixed. However, Codacy disagreed. Upon opening each of the files that Codacy reported, only THEN did VSC's eslint say, "oh yeah… there's one problem in this file. Umm… Yup! There's two files in that file, too. You're good at this! Maybe you don't need eslint in VSC at all, just keep checking Codacy's reports. Can you go away and leave me alone now? Thanks!"
Configuration menu - View commit details
-
Copy full SHA for 07dbb37 - Browse repository at this point
Copy the full SHA 07dbb37View commit details
Commits on Feb 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f3e04f4 - Browse repository at this point
Copy the full SHA f3e04f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bb3663 - Browse repository at this point
Copy the full SHA 0bb3663View commit details -
Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 58cea44 - Browse repository at this point
Copy the full SHA 58cea44View commit details -
tl-its-umich-edu#221 - undo Swagger dev. link changes
Undo my changes to make the Swagger link more convenient to find and use. It doesn't really belong in this PR. @ssciolla is implementing this in PR tl-its-umich-edu#348 instead.
Configuration menu - View commit details
-
Copy full SHA for 5c387b8 - Browse repository at this point
Copy the full SHA 5c387b8View commit details -
tl-its-umich-edu#221 - restore CSRF decorator
It may have been accidentally removed at some point.
Configuration menu - View commit details
-
Copy full SHA for 06ed486 - Browse repository at this point
Copy the full SHA 06ed486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1392849 - Browse repository at this point
Copy the full SHA 1392849View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d9cc23 - Browse repository at this point
Copy the full SHA 2d9cc23View commit details -
tl-its-umich-edu#221 - move invitation API URL definition
Using code as directed by @pushyamig in (tl-its-umich-edu#247 (comment)).
Configuration menu - View commit details
-
Copy full SHA for bf1a27b - Browse repository at this point
Copy the full SHA bf1a27bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85f483b - Browse repository at this point
Copy the full SHA 85f483bView commit details
Commits on Feb 23, 2022
-
tl-its-umich-edu#221 - more of: move invitation API URL definition
Using code as directed by @pushyamig in (tl-its-umich-edu#247 (comment)). The `apiURL` was left behind in the config interface.
Configuration menu - View commit details
-
Copy full SHA for b677374 - Browse repository at this point
Copy the full SHA b677374View commit details -
Configuration menu - View commit details
-
Copy full SHA for 006280d - Browse repository at this point
Copy the full SHA 006280dView commit details -
tl-its-umich-edu#221 - allegedly removed the supposed snark
Who does he think he is putting that in the code‽ He sure seems like some kind of "genius".
Configuration menu - View commit details
-
Copy full SHA for 1fd468b - Browse repository at this point
Copy the full SHA 1fd468bView commit details -
Update ccm_web/server/src/api/api.utils.ts
Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 681fbc6 - Browse repository at this point
Copy the full SHA 681fbc6View commit details -
tl-its-umich-edu#221 - move invitation URL parts to interface
Per @ssciolla's suggestion.
Configuration menu - View commit details
-
Copy full SHA for c193398 - Browse repository at this point
Copy the full SHA c193398View commit details -
Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm …
…into 221-enroll-non-umich * '221-enroll-non-umich' of https://github.com/lsloan/ccm: Update ccm_web/server/src/api/api.utils.ts
Configuration menu - View commit details
-
Copy full SHA for 865f1ba - Browse repository at this point
Copy the full SHA 865f1baView commit details -
tl-its-umich-edu#221 - remove type declaration
Interesting that eslint didn't complain about these. At least not in VSC. It did in IntelliJ IDEA.
Configuration menu - View commit details
-
Copy full SHA for 2797cfb - Browse repository at this point
Copy the full SHA 2797cfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 937e335 - Browse repository at this point
Copy the full SHA 937e335View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b826e5 - Browse repository at this point
Copy the full SHA 2b826e5View commit details -
tl-its-umich-edu#221 - break up import to be like others
I had also used VSC's format document/selection on this file. It removed a lot of spaces that later caused eslint errors. IntelliJ IDEA did this correctly.
Configuration menu - View commit details
-
Copy full SHA for f271825 - Browse repository at this point
Copy the full SHA f271825View commit details -
Configuration menu - View commit details
-
Copy full SHA for 801c7a3 - Browse repository at this point
Copy the full SHA 801c7a3View commit details -
tl-its-umich-edu#221 - redo Cirrus URL definition
The example given in (tl-its-umich-edu#247 (comment)) was wrong. @pushyamig wants the base URL of the Cirrus API to remain in the config, but various other segments of the complete URL are to be hard-coded into the application code.
Configuration menu - View commit details
-
Copy full SHA for f63a8c4 - Browse repository at this point
Copy the full SHA f63a8c4View commit details -
tl-its-umich-edu#221 - remove
String
castingeslint had given an error about the variable in the string and some other errors in that function. However, something has changed since then and none of those errors reappear when I remove the casting.
Configuration menu - View commit details
-
Copy full SHA for 3689bec - Browse repository at this point
Copy the full SHA 3689becView commit details -
tl-its-umich-edu#221 - eslint assuagement
VSC's formatting and eslint features conflict with each other. Codacy reports other problems, but @pushyamig says @ssciolla only follows the eslint advice in VSC. It makes me wonder: If Codacy shows more problems that aren't fixed, does it ever show that the tests for the PR have passed?
Configuration menu - View commit details
-
Copy full SHA for 94ebf49 - Browse repository at this point
Copy the full SHA 94ebf49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3404d66 - Browse repository at this point
Copy the full SHA 3404d66View commit details
Commits on Feb 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4ae143b - Browse repository at this point
Copy the full SHA 4ae143bView commit details -
Update ccm_web/server/src/invitation/cirrus-invitation.interfaces.ts
correct case from @pushyami's code Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 31798cf - Browse repository at this point
Copy the full SHA 31798cfView commit details -
check for unique ID error during Canvas user creation (#7)
Checking for specific error indicators among the long error body returned by Canvas.
Configuration menu - View commit details
-
Copy full SHA for 999bafe - Browse repository at this point
Copy the full SHA 999bafeView commit details -
Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…
…rse-manager-next into 221-enroll-non-umich
Configuration menu - View commit details
-
Copy full SHA for ade135e - Browse repository at this point
Copy the full SHA ade135eView commit details -
Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm …
…into 221-enroll-non-umich * '221-enroll-non-umich' of https://github.com/lsloan/ccm: check for unique ID error during Canvas user creation (#7) Update ccm_web/server/src/invitation/cirrus-invitation.interfaces.ts
Configuration menu - View commit details
-
Copy full SHA for 08d3356 - Browse repository at this point
Copy the full SHA 08d3356View commit details -
tl-its-umich-edu#221 - correct case from @pushyami's code
I didn't fix refs after accepting change suggestion in GH PR. I also hadn't pulled from GH, so I didn't see the compile errors this had caused.
Configuration menu - View commit details
-
Copy full SHA for 1001d59 - Browse repository at this point
Copy the full SHA 1001d59View commit details -
tl-its-umich-edu#221 - correct case from @pushyamig's code
I didn't fix refs after accepting change suggestion in GH PR. I also hadn't pulled from GH, so I didn't see the compile errors this had caused. (EDIT: Updated to use Pushyami's correct username, "pushyamig". Apologies to @pushyami. I wish I could easily go back to correct the other commit message, too.)
Configuration menu - View commit details
-
Copy full SHA for 19987f8 - Browse repository at this point
Copy the full SHA 19987f8View commit details -
Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm …
…into 221-enroll-non-umich * '221-enroll-non-umich' of https://github.com/lsloan/ccm: tl-its-umich-edu#221 - correct case from @pushyami's code
Configuration menu - View commit details
-
Copy full SHA for 64230a0 - Browse repository at this point
Copy the full SHA 64230a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f06f8c5 - Browse repository at this point
Copy the full SHA f06f8c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d90018 - Browse repository at this point
Copy the full SHA 2d90018View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36d1fbd - Browse repository at this point
Copy the full SHA 36d1fbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19f3fc3 - Browse repository at this point
Copy the full SHA 19f3fc3View commit details