Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enroll non-UMich users (iss. #221, #169, #252, #291) #247

Merged
merged 166 commits into from
Feb 24, 2022

Commits on Nov 16, 2021

  1. tl-its-umich-edu#221 - add methods for non-UMich users

    Very simplistic approach for now.  Should be refactored to reduce duplication of code before merging upstream.
    lsloan committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    91b8e24 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Configuration menu
    Copy the full SHA
    d53814f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a6b295e View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Configuration menu
    Copy the full SHA
    a90cca4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c123226 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4416ba2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7fb37e7 View commit details
    Browse the repository at this point in the history
  5. tl-its-umich-edu#221 - add config svc to enroll ext user method

    Also, temporarily accept results as JSON string.  Method based on one for enrolling existing users
    lsloan committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    9e5fd2c View commit details
    Browse the repository at this point in the history
  6. tl-its-umich-edu#221 - method based on enroll existing users

    Temporarily use JSON results as return value.
    lsloan committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    15fc7e0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ef1975e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b3e4540 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Configuration menu
    Copy the full SHA
    5ca5ffa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8410c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e185db View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df7d7be View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1980e2e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d52cfa0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9ddcf53 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2826718 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    32c6d37 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3ddd3a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Configuration menu
    Copy the full SHA
    14c32b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a04f72 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ffc189b View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Configuration menu
    Copy the full SHA
    d911752 View commit details
    Browse the repository at this point in the history
  2. tl-its-umich-edu#221 - add admin API token config support

    `adminApiToken` may end up replacing `adminApiClientId` and `adminApiSecret` altogether.
    lsloan committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    c75ba78 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83187fa View commit details
    Browse the repository at this point in the history
  4. tl-its-umich-edu#221 - add admin API token config support

    `adminApiToken` may end up replacing `adminApiClientId` and `adminApiSecret` altogether.
    lsloan committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    adc89dc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    01834ea View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3796f46 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5fc754b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9c737b7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e6b9b7a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7ba42b4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    78317c4 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    20074ff View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    72712ed View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9c51430 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Configuration menu
    Copy the full SHA
    32297ab View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Configuration menu
    Copy the full SHA
    bbe1a78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf86f08 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    49202f0 View commit details
    Browse the repository at this point in the history
  4. tl-its-umich-edu#221 - resolve handling of invitation results

    There are 3 distinct things happening in this method, creating users as needed, inviting new users, and enrolling all users.  Each process returns different information, so it seems the best way to handle that and return it all to the API user is as a single JSON response.
    lsloan committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    c39efc2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6a9d03c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ffc1d88 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c13618d View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Configuration menu
    Copy the full SHA
    f8bc2fb View commit details
    Browse the repository at this point in the history
  2. tl-its-umich-edu#221 - move create users methods

    Moved `createExternalUsers()` and `createExternalUser()` methods from `SectionApiHandler` to `AdminApiHandler`.
    
    As suggested by @ssciolla in PR tl-its-umich-edu#247 comment: https://github.com/tl-its-umich-edu/canvas-course-manager-next/pull/247/files/c13618dcfac8c22935d81e493f3200fce344bfe1#r770959269
    lsloan committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    f8b3340 View commit details
    Browse the repository at this point in the history
  3. tl-its-umich-edu#221 - add module to complete InvitationService

    Added `InvitationModule` and necessary references in order to use `InvitationService` as a full-fledged service.
    
    As suggested by @ssciolla in PR tl-its-umich-edu#247 comment: https://github.com/tl-its-umich-edu/canvas-course-manager-next/pull/247/files/c13618dcfac8c22935d81e493f3200fce344bfe1#r771579036
    lsloan committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    77de934 View commit details
    Browse the repository at this point in the history
  4. tl-its-umich-edu#221 - return invitation results correctly

    As I was testing this, the `inviteResults` kept coming back as `null`, even though I could see results in the console log.  I thought it was a question of timing with the async method, but then I realized I wasn't returning from the method correctly.  It's much better now.
    lsloan committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    62e42c2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    51c4cdb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4ec4362 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. Configuration menu
    Copy the full SHA
    32f9fe0 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. tl-its-umich-edu#252 - check for user existence

    @ssciolla: I'm not sure whether I wrote this API entry with the security we would like.  Give me feedback.
    lsloan committed Dec 20, 2021
    2 Configuration menu
    Copy the full SHA
    761c3d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Configuration menu
    Copy the full SHA
    455e6ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dfce3ab View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f8b3109 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    59b9f04 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. tl-its-umich-edu#221 - remove invitation API URL

    Remove invitation API URL, add note about picking good key name, and update references to renumbered steps.
    lsloan committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    64ad253 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Configuration menu
    Copy the full SHA
    4596f2e View commit details
    Browse the repository at this point in the history
  2. tl-its-umich-edu#221 - new CanvasUserLoginEmail interface

    Added new `CanvasUserLoginEmail` interface for those times we need to use a `CanvasUser` with `login_id` and `email`.  @ssciolla and I discussed making this change before the Dec 2021 holiday break.  I would rather have one interface for both purposes, but I can't get it to work right.  Perhaps that's due to my limited TypeScript experience.
    lsloan committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    0decd1b View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Configuration menu
    Copy the full SHA
    68b3b4a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53dff50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0b3bad0 View commit details
    Browse the repository at this point in the history
  4. tl-its-umich-edu#220 - clean-up

    lsloan committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    3b13740 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    956a649 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ce38c2f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e18066d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1de3e9f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e795701 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c41cc14 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2e2db8a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    15d65e2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    aeb1efa View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    5894203 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0b24364 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. tl-its-umich-edu#291 - removed, so user can accept terms

    From Canvas API docs: `user[terms_of_use]` - Whether the user accepts the terms of use. Required if this is a self-registration and this canvas instance requires users to accept the terms (on by default). If this is true, it will mark the user as having accepted the terms of use.
    lsloan committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    5eee9fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8b035b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Configuration menu
    Copy the full SHA
    a578eec View commit details
    Browse the repository at this point in the history
  2. tl-its-umich-edu#220 - added ExternalEnrollment type

    Also corrected minor spacing mistake.  (eslint didn't notice that one. 😉)
    lsloan committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    18b1149 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1a8ecf8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3055b4d View commit details
    Browse the repository at this point in the history
  5. Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm

    …into 221-enroll-non-umich
    
    * '221-enroll-non-umich' of https://github.com/lsloan/ccm:
      tl-its-umich-edu#220 - use new `ExternalEnrollment` return type
    lsloan committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    5669210 View commit details
    Browse the repository at this point in the history
  6. Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm

    …into 221-enroll-non-umich
    
    * '221-enroll-non-umich' of https://github.com/lsloan/ccm:
      tl-its-umich-edu#220 - use new `ExternalEnrollment` return type
    lsloan committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    799b3a3 View commit details
    Browse the repository at this point in the history
  7. Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm

    …into 221-enroll-non-umich
    
    * '221-enroll-non-umich' of https://github.com/lsloan/ccm:
    lsloan committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    49caaa9 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. tl-its-umich-edu#221 - remark-lint coddling

    I don't see any problem with README.md, but remark-lint has complained about it.  Let's see whether the changes I've made satisfy it.
    lsloan committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    aca1cef View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Configuration menu
    Copy the full SHA
    c23d0ca View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. tl-its-umich-edu#221 - check roles user is allowed to assign

    Finally!  I had trouble with TypeScript syntax surrounding `enum` types.  I finally have a solution that works.  It may not be elegant.  I know it needs cleaning up, which I'll do tomorrow.
    lsloan committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    197fd3a View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Configuration menu
    Copy the full SHA
    e6b300d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba07db4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e616abc View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Configuration menu
    Copy the full SHA
    74347c6 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…

    …rse-manager-next into 221-enroll-non-umich
    
    Resolved conflicts:
    * ccm_web/server/src/api/api.controller.ts
    * ccm_web/server/src/api/api.service.ts
    lsloan committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    b62821f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d045e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. tl-its-umich-edu#221 - attempt to use NestJS HttpMethod

    As suggested by @ssciolla, I'm trying to use HttpMethod instead of simple Axios for Cirrus requests.  The previous use of Axios seems to be masking details from error responses.  However, this doesn't seem to work at all.  I can't even tell whether the request is being sent to Cirrus.
    lsloan committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    6933474 View commit details
    Browse the repository at this point in the history
  2. tl-its-umich-edu#221 - error handling changes

    The error handling code makes some assumptions about the structure of responses from the Canvas API.  In the case of creating users, when there were errors (e.g., the user already exists, etc.) this code didn't recognize it as a proper Canvas error, because it had a different format.  So, added a way for other error message formats to be accepted.
    lsloan committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    d66b3ed View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Configuration menu
    Copy the full SHA
    a424e10 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    35f8a0b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dfd06f4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    377baf8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    38e68e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Configuration menu
    Copy the full SHA
    79dd288 View commit details
    Browse the repository at this point in the history
  2. tl-its-umich-edu#221 - working request using HttpModule

    A lot of gratitude goes to @ssciolla for helping with this.  I was making a TS newbie mistake which caused an error.  I couldn't tell that the error wasn't coming from the Cirrus request.
    lsloan committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    4132b66 View commit details
    Browse the repository at this point in the history
  3. tl-its-umich-edu#221 - improvements in invitation service

    Better error handling and return a more descriptive type.
    lsloan committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    b090610 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Configuration menu
    Copy the full SHA
    9fab557 View commit details
    Browse the repository at this point in the history
  2. tl-its-umich-edu#221 - move swagger link to top

    This change isn't strictly related to the issue, but I prefer the Swagger link to appear at the top of the page.  With the app loaded into an iframe and the iframe doesn't fit entirely within the page's display (at least, not in my browser), there's a lot of scrolling within scrolling I need to do when the link is at the bottom of the page.  It's much simpler at the top.  Plus, with the link at the top, we could also add a "DEVELOPMENT MODE" banner there, if we'd like.
    lsloan committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    ba63309 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    772a7f4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f77ec3 View commit details
    Browse the repository at this point in the history
  5. tl-its-umich-edu#221 - move role check from service to controller

    Also regroup code and simplify getting of account ID number.
    lsloan committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    288c5da View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    85830e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Configuration menu
    Copy the full SHA
    d150e9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8d5c1f View commit details
    Browse the repository at this point in the history
  3. tl-its-umich-edu#221 - solve some of our invalid email problems

    I just noticed the `IsEmail` validator.  It's going to be very helpful to us.  I discovered that if the input contains invalid email addresses, Canvas is OK with that and creates the account if it doesn't exist.  Not ideal.  Even worse, the next step of the process passes the email addresses (including the invalid ones) that need to be invited to Cirrus.  Unfortunately, when Cirrus gets invalid email addresses in the batch input, the entire batch fails, so nobody gets an invitation.  That means accounts were created (and subsequent enrollments were made for them), but no invitations were sent.  I was thinking that it may mean the process would need to be reworked to look everybody up FIRST, attempt to invite that batch of new people, and if that succeeds, then do the account creation.  The order of those steps and the additional number of steps is not desirable.  Now that we can call the entire request invalid if any email addresses are invalid, that should save us from any major changes.  I will test further to verify.
    lsloan committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    7a9cc00 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Configuration menu
    Copy the full SHA
    e9a62cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef3654b View commit details
    Browse the repository at this point in the history
  3. tl-its-umich-edu#221 - attempt to key results by email

    I'd like to get @ssciolla's feedback on this.
    lsloan committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    2dc9464 View commit details
    Browse the repository at this point in the history
  4. tl-its-umich-edu#221 - better response structuring with Object

    Using `Object` seems to be better than `Map`.  Also moved the code to after the invitation step to include those results.
    lsloan committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    a3e35c5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    21e9677 View commit details
    Browse the repository at this point in the history
  6. tl-its-umich-edu#221 - add login_id

    This makes it possible to correlate `CanvasEnrollment` objects with `CanvasUserLoginEmail` ones.
    lsloan committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    7a00c32 View commit details
    Browse the repository at this point in the history
  7. tl-its-umich-edu#221 - return loginId (email) with results

    Because the external user enrollment process is based on each user's email address (which is used as their login ID), it's important to include that value in the response.  I've also renamed the `userId` variable to `loginId` for clarity and consistency.
    lsloan committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    76c128b View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. tl-its-umich-edu#221 - pulled response change PR from @ssciolla

    Fixes some problems I had asked for help with.  Also makes other changes to response format.
    lsloan committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    f350a78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51131d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Configuration menu
    Copy the full SHA
    ed51145 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c82718 View commit details
    Browse the repository at this point in the history
  3. tl-its-umich-edu#221 - add InvitationConfig cast

    This makes accessing the properties (`apiURL`, `apiEntityID`, etc.) of the object easier and eliminate IDE warnings.
    lsloan committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    b0d5a71 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'main' of https://github.com/tl-its-umich-edu/canvas-cou…

    …rse-manager-next into 221-enroll-non-umich
    
    Conflicts:
    * ccm_web/server/src/api/api.admin.handler.ts
    * ccm_web/server/src/api/api.section.handler.ts
    * ccm_web/server/src/api/api.utils.ts
    * ccm_web/server/src/config.ts
    * config/.env.sample
    lsloan committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    7fca2a3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b014cc9 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Configuration menu
    Copy the full SHA
    13ce4be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7bfa0c5 View commit details
    Browse the repository at this point in the history
  3. tl-its-umich-edu#221 - more eslint god appeasement 🗿🗿🗿🗿🗿

    eslint in MS' Visual Studio Code isn't that great.  It told me that the previous commit was all that needed to be fixed.  However, Codacy disagreed.  Upon opening each of the files that Codacy reported, only THEN did VSC's eslint say, "oh yeah… there's one problem in this file.  Umm…  Yup!  There's two files in that file, too.  You're good at this!  Maybe you don't need eslint in VSC at all, just keep checking Codacy's reports.  Can you go away and leave me alone now?  Thanks!"
    lsloan committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    07dbb37 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. Configuration menu
    Copy the full SHA
    f3e04f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bb3663 View commit details
    Browse the repository at this point in the history
  3. Update config/.env.sample

    Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
    lsloan and ssciolla authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    58cea44 View commit details
    Browse the repository at this point in the history
  4. tl-its-umich-edu#221 - undo Swagger dev. link changes

    Undo my changes to make the Swagger link more convenient to find and use.  It doesn't really belong in this PR.  @ssciolla is implementing this in PR tl-its-umich-edu#348 instead.
    lsloan committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    5c387b8 View commit details
    Browse the repository at this point in the history
  5. tl-its-umich-edu#221 - restore CSRF decorator

    It may have been accidentally removed at some point.
    lsloan committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    06ed486 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1392849 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2d9cc23 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bf1a27b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    85f483b View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. tl-its-umich-edu#221 - more of: move invitation API URL definition

    Using code as directed by @pushyamig in (tl-its-umich-edu#247 (comment)).  The `apiURL` was left behind in the config interface.
    lsloan committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    b677374 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    006280d View commit details
    Browse the repository at this point in the history
  3. tl-its-umich-edu#221 - allegedly removed the supposed snark

    Who does he think he is putting that in the code‽  He sure seems like some kind of "genius".
    lsloan committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    1fd468b View commit details
    Browse the repository at this point in the history
  4. Update ccm_web/server/src/api/api.utils.ts

    Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
    lsloan and ssciolla authored Feb 23, 2022
    Configuration menu
    Copy the full SHA
    681fbc6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c193398 View commit details
    Browse the repository at this point in the history
  6. Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm

    …into 221-enroll-non-umich
    
    * '221-enroll-non-umich' of https://github.com/lsloan/ccm:
      Update ccm_web/server/src/api/api.utils.ts
    lsloan committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    865f1ba View commit details
    Browse the repository at this point in the history
  7. tl-its-umich-edu#221 - remove type declaration

    Interesting that eslint didn't complain about these.  At least not in VSC.  It did in IntelliJ IDEA.
    lsloan committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    2797cfb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    937e335 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2b826e5 View commit details
    Browse the repository at this point in the history
  10. tl-its-umich-edu#221 - break up import to be like others

    I had also used VSC's format document/selection on this file.  It removed a lot of spaces that later caused eslint errors.  IntelliJ IDEA did this correctly.
    lsloan committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    f271825 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    801c7a3 View commit details
    Browse the repository at this point in the history
  12. tl-its-umich-edu#221 - redo Cirrus URL definition

    The example given in (tl-its-umich-edu#247 (comment)) was wrong.  @pushyamig wants the base URL of the Cirrus API to remain in the config, but various other segments of the complete URL are to be hard-coded into the application code.
    lsloan committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    f63a8c4 View commit details
    Browse the repository at this point in the history
  13. tl-its-umich-edu#221 - remove String casting

    eslint had given an error about the variable in the string and some other errors in that function.  However, something has changed since then and none of those errors reappear when I remove the casting.
    lsloan committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    3689bec View commit details
    Browse the repository at this point in the history
  14. tl-its-umich-edu#221 - eslint assuagement

    VSC's formatting and eslint features conflict with each other.  Codacy reports other problems, but @pushyamig says @ssciolla only follows the eslint advice in VSC.  It makes me wonder:  If Codacy shows more problems that aren't fixed, does it ever show that the tests for the PR have passed?
    lsloan committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    94ebf49 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3404d66 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Configuration menu
    Copy the full SHA
    4ae143b View commit details
    Browse the repository at this point in the history
  2. Update ccm_web/server/src/invitation/cirrus-invitation.interfaces.ts

    correct case from @pushyami's code
    
    Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
    lsloan and ssciolla authored Feb 24, 2022
    Configuration menu
    Copy the full SHA
    31798cf View commit details
    Browse the repository at this point in the history
  3. check for unique ID error during Canvas user creation (#7)

    Checking for specific error indicators among the long error body returned by Canvas.
    ssciolla authored Feb 24, 2022
    Configuration menu
    Copy the full SHA
    999bafe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ade135e View commit details
    Browse the repository at this point in the history
  5. Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm

    …into 221-enroll-non-umich
    
    * '221-enroll-non-umich' of https://github.com/lsloan/ccm:
      check for unique ID error during Canvas user creation (#7)
      Update ccm_web/server/src/invitation/cirrus-invitation.interfaces.ts
    lsloan committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    08d3356 View commit details
    Browse the repository at this point in the history
  6. tl-its-umich-edu#221 - correct case from @pushyami's code

    I didn't fix refs after accepting change suggestion in GH PR.  I also hadn't pulled from GH, so I didn't see the compile errors this had caused.
    lsloan committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    1001d59 View commit details
    Browse the repository at this point in the history
  7. tl-its-umich-edu#221 - correct case from @pushyamig's code

    I didn't fix refs after accepting change suggestion in GH PR.  I also hadn't pulled from GH, so I didn't see the compile errors this had caused.  (EDIT: Updated to use Pushyami's correct username, "pushyamig".  Apologies to @pushyami.  I wish I could easily go back to correct the other commit message, too.)
    lsloan committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    19987f8 View commit details
    Browse the repository at this point in the history
  8. Merge branch '221-enroll-non-umich' of https://github.com/lsloan/ccm

    …into 221-enroll-non-umich
    
    * '221-enroll-non-umich' of https://github.com/lsloan/ccm:
      tl-its-umich-edu#221 - correct case from @pushyami's code
    lsloan committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    64230a0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f06f8c5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2d90018 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    36d1fbd View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    19f3fc3 View commit details
    Browse the repository at this point in the history