Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token inconsistencies: enforce snake_case in token #4746

Closed
glenacota opened this issue Oct 18, 2020 · 6 comments
Closed

Token inconsistencies: enforce snake_case in token #4746

glenacota opened this issue Oct 18, 2020 · 6 comments

Comments

@glenacota
Copy link
Collaborator

glenacota commented Oct 18, 2020

The token syntax guideline for multi-word tokens is to use the_snake_case_form. However, in some pages, words in tokens are separated by whitespace (e.g., buku, gist, man, git-send-email, ...) and in others dashes (e.g., dexter, git-ls-remote, ...).

I can work on a bulk PR to enforce the snake_case syntax guideline, maybe creating one commit for each wrongful separator.

(this Issue might be linked to this old one)

@glenacota
Copy link
Collaborator Author

BTW, I'm not sure this is the right place where to ask, but as I'm very fond of this project and lately I've got some more time to contribute to it, I'd like to ask the org owners how does it work to apply for a regular contributor position :)

@seenukarthi
Copy link
Contributor

seenukarthi commented Oct 19, 2020

BTW, I'm not sure this is the right place where to ask, but as I'm very fond of this project and lately I've got some more time to contribute to it, I'd like to ask the org owners how does it work to apply for a regular contributor position :)

@glenacota there is gitter room I think general discussion can be done there.

@sbrl
Copy link
Member

sbrl commented Oct 19, 2020

Hey there, @glenacota! We'd love to have you onboard. According to our community roles document, you need to have 5 non-trivial PRs merged. From the pull request history, I notice you have the following non-trivial PRs merged: #4364, #4362, #2464, #2458, #2452, and #2440. This qualifies you to become a contributor according to the aforementioned document, so I'll open a new issue about that and @mention you :-)

@sbrl
Copy link
Member

sbrl commented Oct 19, 2020

And to answer the original question in this issue, a PR would be appreciated! Though do be careful to check each one: there may be some instances of concrete examples where the space is essential to the page. And also yes, this does seem related to that issue :-)

@sbrl
Copy link
Member

sbrl commented Oct 19, 2020

Opened #4763

@glenacota
Copy link
Collaborator Author

issue solved with #4788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants