banner: add page #2440
banner: add page #2440
Conversation
|
|
There was a problem hiding this comment.
Hi @glenacota, thanks for the new page!
I just have a few minor comments below.
pages/common/banner.md
Outdated
|
|
||
| > Print the given argument as a large ASCII art. | ||
|
|
||
| - Print the text message as a large banner. Note: quotes are optional: |
There was a problem hiding this comment.
You can just put "quotes are optional" within parenthesis before finishing the sentence. No need for "Note:"
There was a problem hiding this comment.
Ok, but I wanted to be consistent with the format used for the echo command. Do you think we should change the sentence also there?
There was a problem hiding this comment.
Thanks. Yes, sometimes pages deviate from a common style. I think we should change the echo page too. Note that the last example in the echo page too uses parenthesis.
pages/common/banner.md
Outdated
|
|
||
| - Print the text message as a banner with a width of 50 characters: | ||
|
|
||
| `banner -w 50 {{"Hello World"}}` |
There was a problem hiding this comment.
50 is still not within tokens.
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being edited.The page follows the contributing guidelines.