Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-bundle: add page #4364

Merged
merged 5 commits into from
Oct 1, 2020
Merged

git-bundle: add page #4364

merged 5 commits into from
Oct 1, 2020

Conversation

glenacota
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Related to issue #3953

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-bundle.md:33: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

@owenvoke owenvoke added the new command Issues requesting creation of a new page. label Sep 27, 2020
owenvoke
owenvoke requested changes Sep 27, 2020
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @glenacota, thanks for the new page! Just a few minor changes to add token syntax around customisable values. 👍

pages/common/git-bundle.md Outdated Show resolved Hide resolved
pages/common/git-bundle.md Outdated Show resolved Hide resolved
owenvoke
owenvoke approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @glenacota. 🙂

sbrl
sbrl reviewed Sep 29, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @glenacota! I've left some comments below for you to review.

Very minor things really - other than this it looks great 👍

pages/common/git-bundle.md Outdated Show resolved Hide resolved
pages/common/git-bundle.md Outdated Show resolved Hide resolved
glenacota and others added 2 commits September 29, 2020 17:04
@glenacota @sbrl
Improve readability
f5977bf 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@glenacota @sbrl
Minor rewording for readability
e1cd4d6 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@navarroaxel navarroaxel requested a review from sbrl October 1, 2020 19:19
@navarroaxel navarroaxel merged commit 3cdee95 into tldr-pages:master Oct 1, 2020
This was referenced Oct 19, 2020
Closed
Closed
@bl-ue bl-ue mentioned this pull request Jan 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@owenvoke owenvoke owenvoke approved these changes

@sbrl sbrl Awaiting requested review from sbrl

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glenacota @tldr-bot @navarroaxel @owenvoke @sbrl