Skip to content

Conversation

MaximMakulski
Copy link

I added some ssh clients. In addition, i have taken over the library for the Docker API from the TLS-Docker project.

@Holzhaus
Copy link

This PR reintroduces the shell scripts that have been removed in favor of docker-compose. Also, the images in the clientImages directory seem to duplicate the client images that are already present in the current compose configuration (for example, openssh: https://github.com/tls-attacker/SSH-Docker-Library/blob/main/compose.yml#L1208). Please double check, maybe the rebase went wrong?

TrueSkrillor added a commit that referenced this pull request Mar 24, 2023
@TrueSkrillor
Copy link
Contributor

Okay, we can't merge this PR without modifying the surrounding framework as pointed out by @Holzhaus. I'll be adopting each implementation to meet the requirements and open separate PRs for each of them. This PR will remain open until every implementation has been migrated.

TrueSkrillor added a commit that referenced this pull request Mar 24, 2023
@TrueSkrillor
Copy link
Contributor

All client images, excluding go ssh and metasploit, have been merged into master in #59 based on the Dockerfiles in this PR. We can ignore zgrab2 as it uses go ssh internally.

I'll keep this PR open until the remaining clients and the Java code have been merged.

@TrueSkrillor TrueSkrillor changed the title Clients DO NOT MERGE: Clients Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants