embeddings: remove TEI embeddings client. #396

pattonjp · 2023-12-04T21:54:13Z

followup per #352

PR Checklist

Read the Contributing documentation.
Read the Code of conduct documentation.
Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
Describes the source of new concepts.
References existing implementations as appropriate.
Contains test coverage for new functions.
Passes all golangci-lint checks.

* FR278 Add remote chromadb support * FR278 Fix lint complaints * Add 'nameSpace' via metadata * Add embedder Option * Add includes, example app, README * feat(vectorstore): add chroma * fix: update type to match upstream * style: fix golangci-lint complaints

…tmc#318) Signed-off-by: bjwswang <bjwswang@gmail.com>

Signed-off-by: Saerdna <zhaodahao@gmail.com>

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.24 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.24...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: bjwswang <bjwswang@gmail.com>

…#326) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update README.md * Update README.md

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.57.0 to 1.57.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.57.0...v1.57.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Adding ollama support * Address linting issues * Disable default templating of model if any to avoid messing up custom prompts * Added Ollama chatModel * Adding ollama embeddings * Added examples and fix the chat template for llama2 * examples: Fixup module names in ollama examples * ollama: Small lint fix --------- Co-authored-by: Travis Cline <travis.cline@gmail.com>

* docs: Mark unfinished parts as draft * github: Add docs publish workflow * github: Simplify pages deploy * docs: set baseUrl * docs: mark more as draft for now

ci: Pin golangci-lint to 1.55

* Added initial HandelStreamFunc callback handler * added callback handler to conversational agent * Added Agent final stdout callback * Added callback handler to mrkl agent * Added egress buffer for final agent streaming * Added proper egress channel handling * Added comments * Added better context handling * Fixing lint

add option to truncate tei embedding input

adding huggingface text embeddings interface as docker service for convienience

This is the first use of the refactoring made in tmc#374 -- removing the embeddings/openai directory entirely, since it can be now implemented with NewEmbedder without duplicating code. The test was moved one dir down and works with the new setup. This is a model that can be used to similarly refactor the other embeddings/* subdirs. This is a large PR because it also updates example go.mods For tmc#379

Now that the main module's version was bumped, update the example to use a proper embedder

The only use of Ollama embeddings is an example - update it too and go.mod versions

embeddings: new NewEmbedder for Ollama embeddings

For tmc#379

For tmc#379 Updates examples go.mod because it's used in an example

…tmc#393) * embeddings: add example of proper usage, and tweak doc.go accordingly For tmc#379 * Appease lint and add comment

pattonjp · 2023-12-04T22:10:08Z

examples ci build is failing due to new dependency.

eliben

Thanks!

eliben · 2023-12-05T00:31:36Z

vectorstores/milvus/milvus.go

@@ -18,7 +18,7 @@ import (
 type Store struct {
 	dropOld          bool
 	async            bool
-	initialized      bool


The changes in this file seem unrelated to the main goal of the PR, or am I missing something? It'd be good to keep the PR for a single purpose only

llms/tei/text_embeddings_inference..go

eliben · 2023-12-08T14:21:18Z

@pattonjp friendly ping - do you intend to continue with this PR?

pattonjp · 2023-12-08T17:37:55Z

@eliben
after the embeddings factor, it appears that the tei embeddings client is no longer needed. i am now able to use openai llm as client to my local tei instance.

chroma_vectorstore_example

eliben · 2023-12-08T18:29:44Z

@eliben after the embeddings factor, it appears that the tei embeddings client is no longer needed. i am now able to use openai llm as client to my local tei instance.

That's a great outcome :)

eliben

This LGTM overall - though it's still not clear if all the changes this PR introduces are related/essential for the title (see my other comment)

@tmc for approval

tmc

LGTM

noodnik2 and others added 30 commits September 29, 2023 09:05

vectorstore: openai apikey is must required only when embedder is nil (…

adf0f6c

…tmc#318) Signed-off-by: bjwswang <bjwswang@gmail.com>

bugfix: openai fix model option (tmc#319)

41f2824

Signed-off-by: Saerdna <zhaodahao@gmail.com>

deps: update golang.org/x/net

5620c5b

examples: sync to main

a02d4fd

vectorstores: disable debug in chromadb client (tmc#324)

949349d

Signed-off-by: bjwswang <bjwswang@gmail.com>

chains: added constitutional chain. refactored few shot prompt (tmc#316)

c636b3d

examples: Sync and update deps

370d210

ci: Pin golangci-lint to 1.54 (tmc#340)

ce0bbea

Update README.md (tmc#338)

6d09939

* Update README.md * Update README.md

example: Sync

5f44515

example: Sync

be6f87d

examples: Include full path in examples

440d668

docs: Add docs publishing, include Ollama quickstart guide. (tmc#342)

e3f64b1

* docs: Mark unfinished parts as draft * github: Add docs publish workflow * github: Simplify pages deploy * docs: set baseUrl * docs: mark more as draft for now

docs: Minor edits to ollama guide

0ded982

docs: Simplify quickstart material

eaf002b

readme: Add link to docs site

34b4fdc

docs: Minor tweak

8e0c552

Update docusaurus.config.js

139e263

ci: Pin golangci-lint to 1.55

04a7ba0

fix: golangci-lint v1.55 errors

12c41dc

Merge pull request tmc#343 from Ismail14098/main

0b9c047

ci: Pin golangci-lint to 1.55

make: Update golangci-lint version in make helper

0fb9f07

examples: Add gpt4 turbo example (tmc#349)

168acd7

serpapi: remove unnecessary replacement from url (tmc#344)

a85bad2

pattonjp and others added 12 commits November 30, 2023 14:32

embeddings: TEI input truncation (enhancement) (tmc#384)

9983a59

add option to truncate tei embedding input

Simplify milvus example (tmc#383)

98fa24d

adding huggingface text embeddings interface as docker service for convienience

examples/pinecone-vectorstore-example: use new embedder (tmc#386)

2bb1ca0

Now that the main module's version was bumped, update the example to use a proper embedder

Update README.md (tmc#387)

008d109

embeddings: new NewEmbedder for Ollama embeddings

db67bc5

The only use of Ollama embeddings is an example - update it too and go.mod versions

Merge pull request tmc#390 from tmc/fixollamaemb

ebe0f43

embeddings: new NewEmbedder for Ollama embeddings

embeddings: use NewEmbedder for Vertex embeddings (tmc#391)

4182ba4

For tmc#379

embeddings: use NewEmbedder for Ernie embeddings (tmc#392)

bef6d7e

For tmc#379 Updates examples go.mod because it's used in an example

embeddings: add example of proper usage, and tweak doc.go accordingly (…

9508a34

…tmc#393) * embeddings: add example of proper usage, and tweak doc.go accordingly For tmc#379 * Appease lint and add comment

embeddings: factor to new embedder client pattern

2ac3643

lint errors

da040f2

eliben reviewed Dec 5, 2023

View reviewed changes

tmc force-pushed the main branch from 8c3ee03 to 0217b03 Compare December 5, 2023 06:40

eliben mentioned this pull request Dec 6, 2023

embeddings: clean up code using new inferaces/type #379

Open

5 tasks

pattonjp added 4 commits December 8, 2023 10:33

merge latest changes

ddf6d5c

fix missed conflict

2a45fb2

remove tei embeddings

a9142b9

mod tidy

0651d8a

pattonjp changed the title ~~embeddings: TEI factor to new embedder client pattern~~ embeddings: remove TEI embeddings client. Dec 8, 2023

rollback wokflow change

16e0cbd

eliben requested changes Dec 8, 2023

View reviewed changes

chroma_vectorstore_example Outdated Show resolved Hide resolved

removing rebase artifact

12f90a3

eliben approved these changes Dec 8, 2023

View reviewed changes

tmc approved these changes Dec 9, 2023

View reviewed changes

tmc merged commit 00f364f into tmc:main Dec 9, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

embeddings: remove TEI embeddings client. #396

embeddings: remove TEI embeddings client. #396

pattonjp commented Dec 4, 2023 •

edited

Loading

pattonjp commented Dec 4, 2023

eliben left a comment

eliben Dec 5, 2023

eliben commented Dec 8, 2023

pattonjp commented Dec 8, 2023 •

edited

Loading

eliben commented Dec 8, 2023

eliben left a comment

tmc left a comment

embeddings: remove TEI embeddings client. #396

embeddings: remove TEI embeddings client. #396

Conversation

pattonjp commented Dec 4, 2023 • edited Loading

PR Checklist

pattonjp commented Dec 4, 2023

eliben left a comment

Choose a reason for hiding this comment

eliben Dec 5, 2023

Choose a reason for hiding this comment

eliben commented Dec 8, 2023

pattonjp commented Dec 8, 2023 • edited Loading

eliben commented Dec 8, 2023

eliben left a comment

Choose a reason for hiding this comment

tmc left a comment

Choose a reason for hiding this comment

pattonjp commented Dec 4, 2023 •

edited

Loading

pattonjp commented Dec 8, 2023 •

edited

Loading