Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: Added left-handed mode and viewmodel FOV & xyz-offset cvars #68

Closed
wants to merge 2 commits into from

Conversation

SmileyAG
Copy link
Contributor

@SmileyAG SmileyAG commented Aug 2, 2021

@SmileyAG SmileyAG changed the title Added left-handed mode Client: Added left-handed mode Aug 2, 2021
@SmileyAG SmileyAG changed the title Client: Added left-handed mode Client: Added left-handed mode and viewmodel FOV & xyz-offset cvars Aug 3, 2021
fR = gEngfuncs.pfnRandomFloat(50, 70);
extern ConVar cl_righthand;
if (cl_righthand.GetFloat() > 0)
fR = gEngfuncs.pfnRandomFloat(-50, 70);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be

fR = -gEngfuncs.pfnRandomFloat(50, 70);

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I'll fix it in next PR.

@@ -502,7 +504,10 @@ void EV_FireGlock1(event_args_t *args)
V_PunchAxis(0, -2.0);
}

EV_GetDefaultShellInfo(args, origin, velocity, ShellVelocity, ShellOrigin, forward, right, up, 20, -12, 4);
if (cl_righthand.GetFloat() > 0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to negate Z velocity in EV_GetDefaultShellInfo instead of every place that it is called at

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it could be formatted better

@tmp64
Copy link
Owner

tmp64 commented Aug 4, 2021

Can you please split this into two PRs? I'll be pushing a commit later today that adds support for OpenGL 2.0 which doesn't require linking with opengl32.dll or GLX. This will cause a mess during rebasing and updating ea9fb71.

@SmileyAG
Copy link
Contributor Author

SmileyAG commented Aug 4, 2021

Can you please split this into two PRs? I'll be pushing a commit later today that adds support for OpenGL 2.0 which doesn't require linking with opengl32.dll or GLX. This will cause a mess during rebasing and updating ea9fb71.

Alright.

@SmileyAG SmileyAG closed this Aug 4, 2021
@SmileyAG SmileyAG deleted the lefthand branch August 4, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants