-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client: Added left-handed mode and viewmodel FOV & xyz-offset cvars #68
Conversation
fR = gEngfuncs.pfnRandomFloat(50, 70); | ||
extern ConVar cl_righthand; | ||
if (cl_righthand.GetFloat() > 0) | ||
fR = gEngfuncs.pfnRandomFloat(-50, 70); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
fR = -gEngfuncs.pfnRandomFloat(50, 70);
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I'll fix it in next PR.
@@ -502,7 +504,10 @@ void EV_FireGlock1(event_args_t *args) | |||
V_PunchAxis(0, -2.0); | |||
} | |||
|
|||
EV_GetDefaultShellInfo(args, origin, velocity, ShellVelocity, ShellOrigin, forward, right, up, 20, -12, 4); | |||
if (cl_righthand.GetFloat() > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to negate Z velocity in EV_GetDefaultShellInfo
instead of every place that it is called at
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it could be formatted better
Can you please split this into two PRs? I'll be pushing a commit later today that adds support for OpenGL 2.0 which doesn't require linking with opengl32.dll or GLX. This will cause a mess during rebasing and updating ea9fb71. |
Alright. |
Based on:
YaLTeR/OpenAG@8df40ea
YaLTeR/OpenAG#129
YaLTeR/OpenAG#107
YaLTeR/OpenAG#108
YaLTeR/OpenAG#109
YaLTeR/OpenAG#111
YaLTeR/OpenAG@3b60ea7