Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test_transform_feature_points due to depreciation of np.nonzero on zero-length arrays #444

Closed
w-k-jones opened this issue Sep 11, 2024 · 1 comment · Fixed by #451
Closed

Fix failing test_transform_feature_points due to depreciation of np.nonzero on zero-length arrays #444

w-k-jones opened this issue Sep 11, 2024 · 1 comment · Fixed by #451
Labels
bug Code that is failing or producing the wrong result dependency Issues with a dependency or import

Comments

@w-k-jones
Copy link
Member

test_transform_feature_points and test_transform_feature_points_3D are failing due to np.nonzero being called on an empty array in line 817. I'll have a look at fixing this, as we should add a check that features are actually removed before calling this code.

We should also do a general check for depreciated functions in dependencies to avoid problems with tests in future
@w-k-jones w-k-jones added bug Code that is failing or producing the wrong result dependency Issues with a dependency or import labels Sep 11, 2024
This was referenced Sep 23, 2024
Open
Merged
@w-k-jones w-k-jones linked a pull request Sep 25, 2024 that will close this issue
Matrix testing fix #451
Merged
11 tasks
@w-k-jones
Copy link
Member Author

Resolved by #451

@JuliaKukulies JuliaKukulies mentioned this issue Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code that is failing or producing the wrong result dependency Issues with a dependency or import
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Matrix testing fix w-k-jones/tobac
1 participant
@w-k-jones