Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix testing fix #451

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

w-k-jones
Copy link
Member

@w-k-jones w-k-jones commented Sep 24, 2024

Fixes a bug in transform_feature_points which was causing the failing matrix tests. I also fixed a couple of other depreciation warnings in the tests, and added python 3.12 to matrix testing. Resolves #444

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

Copy link

Linting results by Pylint:

Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (4fa1efa) to head (81a580b).
Report is 82 commits behind head on RC_v1.5.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           RC_v1.5.x     #451      +/-   ##
=============================================
- Coverage      60.98%   60.96%   -0.03%     
=============================================
  Files             23       23              
  Lines           3550     3548       -2     
=============================================
- Hits            2165     2163       -2     
  Misses          1385     1385              
Flag Coverage Δ
unittests 60.96% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@w-k-jones
Copy link
Member Author

@JuliaKukulies @freemansw1 This should fix the matrix testing issues, are you happy to review?

@w-k-jones w-k-jones self-assigned this Sep 24, 2024
@w-k-jones w-k-jones added bug Code that is failing or producing the wrong result High Priority This issue needs immediate fixing, and may warrant a hotfix release labels Sep 24, 2024
@w-k-jones w-k-jones added this to the Version 1.5.4 milestone Sep 24, 2024
@JuliaKukulies JuliaKukulies self-requested a review September 24, 2024 17:35
Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for fixing this so quickly!

@JuliaKukulies
Copy link
Member

@w-k-jones, fyi I have merged in these changes in #450 and this fixes the matrix testing issue just as here

Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @w-k-jones

@w-k-jones w-k-jones merged commit 3609a59 into tobac-project:RC_v1.5.x Sep 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result High Priority This issue needs immediate fixing, and may warrant a hotfix release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing test_transform_feature_points due to depreciation of np.nonzero on zero-length arrays
3 participants