-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix testing fix #451
Matrix testing fix #451
Conversation
Linting results by Pylint:Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.x #451 +/- ##
=============================================
- Coverage 60.98% 60.96% -0.03%
=============================================
Files 23 23
Lines 3550 3548 -2
=============================================
- Hits 2165 2163 -2
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@JuliaKukulies @freemansw1 This should fix the matrix testing issues, are you happy to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for fixing this so quickly!
@w-k-jones, fyi I have merged in these changes in #450 and this fixes the matrix testing issue just as here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @w-k-jones
Fixes a bug in
transform_feature_points
which was causing the failing matrix tests. I also fixed a couple of other depreciation warnings in the tests, and added python 3.12 to matrix testing. Resolves #444