-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated v1.5 reference to peer-reviewed #450
updated v1.5 reference to peer-reviewed #450
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.x #450 +/- ##
=============================================
- Coverage 60.98% 60.96% -0.03%
=============================================
Files 23 23
Lines 3550 3548 -2
=============================================
- Hits 2165 2163 -2
Misses 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Linting results by Pylint:Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) |
It would be nice to add the publications to the top of the "Refereed Publications" page, but I'm happy to approve this as is |
Agree, I will add this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @JuliaKukulies. For the issue in utils, is there an issue number linked to it? If so, let's make sure to mark it with the milestone and close it too.
As for the utils fixes: this was done in the already closed PR of Will #451 (issue #444). It just ended up here as well since there was a time mismatch and I have then merged in the changes from #451 to this PR so the matrix testing is fixed |
@freemansw1 Since the issue that was related to these merged in changes is closed, I am merging this now |
Updated the reference and thereby solved #445