Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated v1.5 reference to peer-reviewed #450

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

JuliaKukulies
Copy link
Member

Updated the reference and thereby solved #445

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (4fa1efa) to head (ad60ed7).
Report is 33 commits behind head on RC_v1.5.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           RC_v1.5.x     #450      +/-   ##
=============================================
- Coverage      60.98%   60.96%   -0.03%     
=============================================
  Files             23       23              
  Lines           3550     3548       -2     
=============================================
- Hits            2165     2163       -2     
  Misses          1385     1385              
Flag Coverage Δ
unittests 60.96% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 23, 2024

Linting results by Pylint:

Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@w-k-jones
Copy link
Member

It would be nice to add the publications to the top of the "Refereed Publications" page, but I'm happy to approve this as is

@JuliaKukulies
Copy link
Member Author

It would be nice to add the publications to the top of the "Refereed Publications" page, but I'm happy to approve this as is

Agree, I will add this!

@JuliaKukulies JuliaKukulies mentioned this pull request Sep 24, 2024
11 tasks
@w-k-jones w-k-jones linked an issue Sep 25, 2024 that may be closed by this pull request
@w-k-jones w-k-jones added the documentation Updates and improvements to documentation and examples label Sep 30, 2024
@w-k-jones w-k-jones added this to the Version 1.5.4 milestone Oct 11, 2024
@w-k-jones w-k-jones self-requested a review October 11, 2024 14:26
Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @JuliaKukulies. For the issue in utils, is there an issue number linked to it? If so, let's make sure to mark it with the milestone and close it too.

@JuliaKukulies
Copy link
Member Author

Thanks, @JuliaKukulies. For the issue in utils, is there an issue number linked to it? If so, let's make sure to mark it with the milestone and close it too.

As for the utils fixes: this was done in the already closed PR of Will #451 (issue #444). It just ended up here as well since there was a time mismatch and I have then merged in the changes from #451 to this PR so the matrix testing is fixed

@JuliaKukulies
Copy link
Member Author

@freemansw1 Since the issue that was related to these merged in changes is closed, I am merging this now

@JuliaKukulies JuliaKukulies merged commit c38ae1c into tobac-project:RC_v1.5.x Oct 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates and improvements to documentation and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update citation in documentation
3 participants