-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move fixes to filter_min_distance
and 2d coordinate interpolation to v1.4.
#251
Move fixes to filter_min_distance
and 2d coordinate interpolation to v1.4.
#251
Conversation
Codecov ReportBase: 35.76% // Head: 39.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## hotfix #251 +/- ##
==========================================
+ Coverage 35.76% 39.37% +3.61%
==========================================
Files 15 11 -4
Lines 3403 2255 -1148
==========================================
- Hits 1217 888 -329
+ Misses 2186 1367 -819
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that you managed to get these changes over to the hotfix branch @w-k-jones! Looks all good to me and hopefully, it will be as easy to merge back into v1.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy for this to be merged. Sorry that I missed approving this.
No worries! I'll go merge now |
This PR takes the same changes made in #244 and #250 and re-implements them on v1.4 to allow for a hotfix release. The logic tree in
filter_min_distance
has been simplified based on the suggestion of @lettlini in the review of #244Note that
filter_min_distance
is not tested as comprehensively due to the missing tests that are implemented for v1.5Hopefully this won't create merge conflicts for v1.5...