-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerated example notebooks with v1.4.2 #253
Regenerated example notebooks with v1.4.2 #253
Conversation
JuliaKukulies
commented
Feb 20, 2023
- Have you followed our guidelines in CONTRIBUTING.md?
- Have you self-reviewed your code and corrected any misspellings?
- Have you written documentation that is easy to understand?
- Have you written descriptive commit messages?
- Have you added NumPy docstrings for newly added functions?
- Have you formatted your code using black?
- If you have introduced a new functionality, have you added adequate unit tests?
- Have all tests passed in your local clone?
- If you have introduced a new functionality, have you added an example notebook?
- Have you kept your pull request small and limited so that it is easy to review?
- Have the newest changes from this branch been merged?
Codecov ReportBase: 39.22% // Head: 39.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## hotfix #253 +/- ##
==========================================
+ Coverage 39.22% 39.35% +0.12%
==========================================
Files 11 11
Lines 2246 2254 +8
==========================================
+ Hits 881 887 +6
- Misses 1365 1367 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Does this include the changes with #251 ? The filter_min_distance
isn't used in the notebooks, the 2d coordinate interpolation but shouldn't affect any visible output
Good point. Actually, it did not include the changes, so I re-executed the notebooks again after merging the changes from #251. Notice that I also added a print statement at the top of each notebook showing with which tobac version the notebook was executed. I guess it is best when we merge #251 before this one when @freemansw1 gets the chance to have a quick look and then I will go ahead with the remaining tasks for the release. |
Printing the version number is a nice addition! I agree, once #251 is done I'm happy for this to be merged and the release to go ahead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy for this to be merged, thanks @JuliaKukulies !