Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerated example notebooks with v1.4.2 #253

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

JuliaKukulies
Copy link
Member

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@JuliaKukulies JuliaKukulies mentioned this pull request Feb 20, 2023
10 tasks
@JuliaKukulies JuliaKukulies self-assigned this Feb 20, 2023
@JuliaKukulies JuliaKukulies added the documentation Updates and improvements to documentation and examples label Feb 20, 2023
@JuliaKukulies JuliaKukulies added this to the Version 1.4.2 milestone Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 39.22% // Head: 39.35% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (180c94f) compared to base (1507b40).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           hotfix     #253      +/-   ##
==========================================
+ Coverage   39.22%   39.35%   +0.12%     
==========================================
  Files          11       11              
  Lines        2246     2254       +8     
==========================================
+ Hits          881      887       +6     
- Misses       1365     1367       +2     
Flag Coverage Δ
unittests 39.35% <66.66%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tobac/utils.py 48.28% <50.00%> (ø)
tobac/feature_detection.py 80.52% <69.23%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Does this include the changes with #251 ? The filter_min_distance isn't used in the notebooks, the 2d coordinate interpolation but shouldn't affect any visible output

@JuliaKukulies
Copy link
Member Author

JuliaKukulies commented Feb 21, 2023

Looks good to me. Does this include the changes with #251 ? The filter_min_distance isn't used in the notebooks, the 2d coordinate interpolation but shouldn't affect any visible output

Good point. Actually, it did not include the changes, so I re-executed the notebooks again after merging the changes from #251. Notice that I also added a print statement at the top of each notebook showing with which tobac version the notebook was executed.

I guess it is best when we merge #251 before this one when @freemansw1 gets the chance to have a quick look and then I will go ahead with the remaining tasks for the release.

@w-k-jones
Copy link
Member

Printing the version number is a nice addition! I agree, once #251 is done I'm happy for this to be merged and the release to go ahead

Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy for this to be merged, thanks @JuliaKukulies !

@JuliaKukulies JuliaKukulies merged commit 943458e into tobac-project:hotfix Feb 21, 2023
@JuliaKukulies JuliaKukulies deleted the hotfix_v1.4.2 branch February 22, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates and improvements to documentation and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants