fix(bigquery)!: Canonicalize struct & array inline constructor #3751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public slack context
BigQuery allows Array/Struct inline construction such as:
Up until now this was parsed as a single
exp.DataType
node with the inlined values stored in it'svalues
arg. However, this is (1) semantically incorrect asexp.DataType
should only encode type information and (2) it doesn't facilitate transpilation in any way.This PR aims to decouple the actual values from
exp.DataType
and enable seamless transpilation (mainly focused towards DDB) by canonicalizing such expressions toCAST(<values> AS <type>)
.This is done by transforming the parsed
exp.DataType
into anexp.Cast
, with the values now stored in anexp.Array
/exp.Struct
as the cast's LHS and the type as the RHS.