fix(duckdb)!: Fix STRUCT cast generation #4366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4365
BigQuery supports inline
STRUCT
constructors such as the following:#3751 introduced support in SQLGlot by canonicalizing those expressions to a CAST:
Note thought that transpilation towards DuckDB was still not complete as it requires explicit key-value pairs to construct STRUCTs:
To solve this issue efficiently, the PR was extended so that DuckDB can understand when a
STRUCT
was constructed under aSTRUCT
cast and turn that intoCAST(ROW(...) AS STRUCT(...)
instead:However, #4365 shows how this is prone to errors if the
ROW
field def order does not match with the cast:To mitigate this issue, the #3751 solution can be further limited to generate a
ROW
only if theSTRUCT
being casted does not have key - value pairs; This seems enough to (1) preserve existing BQ -> DuckDB transpilation cases and (2) restore DuckDB's roundtrips which are order-agnostic: