fix(page): mock selection of multiline text on create/edit link #5241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
doodlewind
reviewed
Nov 7, 2023
packages/blocks/src/_common/components/rich-text/virgo/nodes/link-node/link-popup/link-popup.ts
Show resolved
Hide resolved
|
Hi @doodlewind, scrnli_11_7_2023_3-46-02.PM.mp4Shouldn't it be a single link with all text attributes removed ? |
|
@AyushAgrawal-A2 thanks for the finding, removing all attributes here makes sense - new PR welcome :) |
doodlewind
approved these changes
Nov 7, 2023
doodlewind
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5014
Changes:
getClientRects, for representing text selection accurately.isValidUrlin the_onConfirmmethod beforenormalizeUrl. Previously, an invalid URL was getting accepted on pressing the Enter key as this check was after normalizeUrl.scrnli_11_7_2023_3-28-05.PM.mp4