Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page): multiple link elements when part of selection has attributes #5245

Merged

Conversation

AyushAgrawal-A2
Copy link
Contributor

Bug Description:

#5241 (comment)

Changes:

  • Switched to mode: 'replace' in formatText method while creating new link, to clear all text attributes in selection.
scrnli_11_7_2023_4-46-35.PM.mp4

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 11:20am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 11:20am

@Flrande Flrande merged commit eb02db5 into toeverything:master Nov 8, 2023
20 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/multiple_link_elements branch November 8, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants