fix(page): unexpected placeholder #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Flrande
changed the title
lawvs
approved these changes
Nov 12, 2023
Flrande
reviewed
Nov 12, 2023
| const textSelection = remoteSelections?.find( | ||
| selection => selection.type === 'text' | ||
| ); | ||
| if (textSelection) { |
There was a problem hiding this comment.
Why we need to check textSelection here?
There was a problem hiding this comment.
Suppose there are two users A and B. User A creates #. At this time, user B only needs to update the placehoder when it senses data changes. Here, remoteSelections is mainly used to determine whether it is user B.
Only when it is a text selection, it means that the user is in editing mode. This can avoid unnecessary updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #5204
before:
2023-11-12.12.11.05.mov
after:
2023-11-12.12.10.32.mov