Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page): unexpected placeholder #5295

Merged
merged 1 commit into from
Nov 12, 2023
Merged

fix(page): unexpected placeholder #5295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/blocks/src/paragraph-block/paragraph-block.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,16 @@ export class ParagraphBlockComponent extends BlockElement<ParagraphBlockModel> {
this.requestUpdate();
});
this.model.childrenUpdated.on(() => this.requestUpdate());

this.page.awarenessStore.slots.update.on(v => {
const remoteSelections = this.std.selection.remoteSelections.get(v.id);
const textSelection = remoteSelections?.find(
selection => selection.type === 'text'
);
if (textSelection) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to check textSelection here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppose there are two users A and B. User A creates #. At this time, user B only needs to update the placehoder when it senses data changes. Here, remoteSelections is mainly used to determine whether it is user B.

Only when it is a text selection, it means that the user is in editing mode. This can avoid unnecessary updates.

this._updatePlaceholder();
}
});
}

private _updatePlaceholder = () => {
Expand Down
Loading