fix(273): Fix input output execution

[georgebuciuman]

User description

Fixes #273

---

PR Type

Bug fix, Enhancement

---

Description

• Improved value handling and rendering in nodeV2.tsx by checking for undefined and adding support for string type.
• Enhanced input and output node execution to dynamically manage outputs based on inputs.
• Added a new method getAllOutputs in the node class to retrieve all outputs.

---

Changes walkthrough 📝

Relevant files

Enhancement

nodeV2.tsx Improve value handling and rendering in node wrapper.        packages/graph-editor/src/components/flow/wrapper/nodeV2.tsx Changed condition to check for undefined instead of falsy values. Added handling for string type in getValuePreview. Updated JSX to use nullish coalescing and conditional rendering. +6/-4      input.ts Enhance input node execution to manage outputs dynamically. packages/graph-engine/src/nodes/generic/input.ts Added logic to retain existing outputs if they match inputs. Removed outputs that no longer have corresponding inputs. +16/-9    output.ts Enhance output node execution to manage outputs dynamically. packages/graph-engine/src/nodes/generic/output.ts Added logic to retain existing outputs if they match inputs. Removed outputs that no longer have corresponding inputs. +16/-9    node.ts Add method to retrieve all outputs in node class.                packages/graph-engine/src/programmatic/node.ts Added getAllOutputs method to retrieve all node outputs. Reorganized imports for better readability. +11/-5

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[changeset-bot]

⚠️ No Changeset found

Latest commit: 65997de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	3
🧪 Relevant tests	No
🔒 Security concerns	No
⚡ Key issues to review	Possible Bug: In both input.ts and output.ts, the logic for deleting outputs not present in inputs might inadvertently delete outputs that are still needed if not properly managed or if there are asynchronous operations affecting outputs. This needs careful review to ensure outputs are managed correctly without unintended side effects.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Prevent potential runtime errors by ensuring necessary properties exist before use Add a check to ensure rawInput.type exists before adding an output to prevent potential runtime errors. packages/graph-engine/src/nodes/generic/input.ts [32-36] -if(!(input in outputs)) { +if(!(input in outputs) && rawInput.type) { this.addOutput(input, { type: rawInput.type, visible: true, }); } Suggestion importance[1-10]: 9 Why: This suggestion addresses a potential runtime error, which is crucial for the stability of the application. Ensuring rawInput.type exists before use is a good practice.	9
Maintainability	Ensure consistent object references for better maintainability and to avoid errors Ensure consistent use of input.name instead of port.name to avoid potential reference errors or inconsistencies. packages/graph-editor/src/components/flow/wrapper/nodeV2.tsx [265-266] {inlineValuesValue && <Text css={{ fontSize: '$small', color: '$gray12' }}>{getValuePreview(input.value, input.type) ?? input.name}</Text>} -{port.value !== undefined ? <Text css={{ fontSize: '$medium', color: '$gray11' }}>{input.name}</Text> : null} +{input.value !== undefined ? <Text css={{ fontSize: '$medium', color: '$gray11' }}>{input.name}</Text> : null} Suggestion importance[1-10]: 7 Why: Ensuring consistent object references improves maintainability and reduces the chance of errors. However, the impact is minor as it only affects readability and consistency.	7
Enhancement	Improve code clarity by renaming the function to better reflect its functionality Use a more descriptive function name for getAllOutputs to clarify that it returns output values, not output objects. packages/graph-engine/src/programmatic/node.ts [285-289] -getAllOutputs = <T = Record<string, any>>(): T => { +getAllOutputValues = <T = Record<string, any>>(): T => { return Object.fromEntries( Object.entries(this.outputs).map(([key, value]) => [key, value.value]) ) as T; }; Suggestion importance[1-10]: 6 Why: Renaming the function to better reflect its functionality improves code clarity and maintainability, but it is not a critical change.	6
Possible issue	Improve the robustness of the value check by handling both null and undefined Replace the strict equality check for undefined with a falsy check to handle both null and undefined values gracefully. packages/graph-editor/src/components/flow/wrapper/nodeV2.tsx [166-167] -if (value === undefined) { +if (!value) { return null; } Suggestion importance[1-10]: 4 Why: While handling both null and undefined can be useful, the original change was likely made to differentiate between null and other falsy values like 0 or ''. The suggestion might reintroduce issues the PR aimed to fix.	4

[SorsOps]

Looks like there's a side effect with not setting the node typing correctly

[georgebuciuman]

Looks like there's a side effect with not setting the node typing correctly

@SorsOps We should also set the type of the output to always be the same as the input then, I guess