Revert "Fix input output execution"

[SorsOps]

User description

Reverts #276

---

PR Type

Bug fix

---

Description

• Fixed the logic for displaying values and port names in the node wrapper component.
• Simplified the execute method in both input and output nodes by clearing and resetting outputs.
• Removed unnecessary imports and the getAllOutputs method in the node programmatic file.

---

Changes walkthrough 📝

Relevant files

Bug fix

nodeV2.tsx Fix value and port name display logic in node wrapper.      packages/graph-editor/src/components/flow/wrapper/nodeV2.tsx Changed condition to check for falsy values instead of undefined. Removed redundant case for string type in getValuePreview. Updated logic for displaying port names. +4/-6      input.ts Simplify execute method and clean up imports in input node. packages/graph-engine/src/nodes/generic/input.ts Removed unnecessary imports. Simplified the execute method to clear and reset outputs. +10/-17  output.ts Simplify execute method and clean up imports in output node. packages/graph-engine/src/nodes/generic/output.ts Removed unnecessary imports. Simplified the execute method to clear and reset outputs. +10/-17  node.ts Remove getAllOutputs method and reorganize imports in node. packages/graph-engine/src/programmatic/node.ts Reorganized imports for better readability. Removed the getAllOutputs method. +5/-11

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8e3425b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	3
🧪 Relevant tests	No
🔒 Security concerns	No
⚡ Key issues to review	Possible Bug: The change from checking value === undefined to !value in getValuePreview might introduce bugs by treating all falsy values (like 0 or empty string) as undefined, which could lead to incorrect behavior or display issues.
	Code Clarity: The removal of the getAllOutputs method and changes in the execute methods of input.ts and output.ts simplify the code but could potentially impact functionality if the original handling of outputs was necessary for certain edge cases.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Use strict equality check to avoid incorrect handling of falsy values Replace the loose check (!value) with a strict check (value === undefined) to ensure that only undefined values return null. This avoids unintended cases where falsy values like 0 or '' would incorrectly return null. packages/graph-editor/src/components/flow/wrapper/nodeV2.tsx [166-167] -if (!value) { +if (value === undefined) { return null; } Suggestion importance[1-10]: 9 Why: This suggestion addresses a potential bug where falsy values like 0 or '' could incorrectly return null. Using a strict check ensures only undefined values are handled this way, improving the function's reliability.	9
Enhancement	Prevent output duplication by checking for existing outputs before adding new ones Reintroduce the check for existing outputs before adding new outputs to prevent duplication and potential overwrites in the node's output data. packages/graph-engine/src/nodes/generic/input.ts [34-38] -this.addOutput(input, { - type: rawInput.type, - visible: true, -}); +if(!(input in this.getAllOutputs())) { + this.addOutput(input, { + type: rawInput.type, + visible: true, + }); +} this.setOutput(input, rawInput.value); Suggestion importance[1-10]: 8 Why: This suggestion enhances the code by preventing potential duplication and overwrites in the node's output data, which can improve the stability and correctness of the node's behavior.	8
Maintainability	Restore the getAllOutputs method to manage node outputs effectively Reintroduce the getAllOutputs method to facilitate access to all outputs, which might be necessary for other parts of the application or during node cleanup. packages/graph-engine/src/programmatic/node.ts [285-287] +getAllOutputs = <T = Record<string, any>>(): T => { + return Object.fromEntries( + Object.entries(this.outputs).map(([key, value]) => [key, value.value]) + ) as T; +}; + /** * Handles cleanup for nodes with state. * Use the super method to clear the graph reference Suggestion importance[1-10]: 8 Why: Reintroducing the getAllOutputs method improves maintainability and ensures that other parts of the application or node cleanup processes can access all outputs as needed.	8
Possible issue	Ensure string values are handled correctly if needed Since the 'string' case handling has been removed, ensure that this does not affect the functionality where string values need specific handling other than being checked as a hex color. packages/graph-editor/src/components/flow/wrapper/nodeV2.tsx [192-194] +case 'string': + valuePreview = value; + break; default: if (isHexColor(value)) { return getColorPreview(value,true); Suggestion importance[1-10]: 7 Why: This suggestion ensures that string values are handled correctly, which might be necessary for certain functionalities. However, it is context-dependent and might not be crucial if string handling as hex color is sufficient.	7