-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining wepoll
items.
#1041
Comments
|
@Thomasdezeeuw I added your item to the OP. Do you have permission to edit the OP directly? |
Yes, but didn't know that. |
@Thomasdezeeuw no worries 👍 |
about memory leak on #1042 |
wepoll
items.wepoll
items.
And we probably need to make a notice that the socket can NEVER be used in other place simultaneously with Mio. Because we simulated ET behavior by intercepting all operations that users could do. |
I would like to add: the current locking scheme is too granular. It makes little sense to use separate locks for the update_queue and the iocp HANDLE; it's likely to hurt performance and introduce subtle bugs. One example I could find: mio/src/sys/windows/selector.rs Lines 368 to 370 in 211223e
self.update_sockets_events()?;
self.active_poll_count.fetch_add(1, Ordering::SeqCst); ^-- By calling This is just an example, which could be easily fixed by reversing the two operations. But in general I think it'd be better to use a single lock to protect both the completion port and the associated state. Then you release this lock just before calling This might require integrating parts of miow into mio, which seems like a good idea either way. |
Is the pull #1055 making sense to you now? |
@Thomasdezeeuw I'll start working on this issue, please assign it to me. |
Had a discussion with @carllerche about the remaining items from this issue. Here's an update of what has been done so far (all items which are commented out are resolved) and remaining action items (added as a status below each line). //Dealing with WSAStartup, #1046. (solved in #1029) |
//Dealing with WSAStartup, #1046. (solved in #1029) |
@Thomasdezeeuw this issue can be closed. All items have either been resolved or are tracked by other opened issues. |
Meta issue tracking remaining work to do on the
wepoll
windows implementation. This description will be updated over time.Original PR: #1034. Original issue #1024.
WSAStartup
, Determine how to do deal with WSAStartup on Windows #1046. (solved in Remove net2 dependency #1029)RawSocket
(do not read / write directly).The text was updated successfully, but these errors were encountered: