implement extra reset variants for Interval #5878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Jul 17, 2023
victor-timofei
force-pushed
the
interval-reset
branch
from
be472be
to
77b08c7
Compare
Darksonn
reviewed
Jul 19, 2023
Darksonn
reviewed
Jul 31, 2023
tokio/src/time/interval.rs
Outdated
|
|
||
| /// Resets the interval to a [`crate::time::Instant`] deadline. | ||
| /// | ||
| /// This method ignores [`MissedTickBehavior`] strategy. |
There was a problem hiding this comment.
It might be better to rephrase this as:
Sets the next tick to expire at the given instant. If the instant is in the past, then the
MissedTickBehaviorstrategy will be used to catch up. If the instant is in the future, then the next tick will complete at the given instant, even if that means that it will sleep for longer than the duration of thisInterval. If theIntervalhad any missed ticks before calling this method, then those are discarded.
victor-timofei
force-pushed
the
interval-reset
branch
from
be4406b
to
2172e0f
Compare
Darksonn
reviewed
Aug 3, 2023
Comment on lines
+595
to
+597
| /// catch up. If the instant is in the future, then the next tick will | ||
| /// complete at the given instant, even if that means that it will sleep for | ||
| /// longer than the duration of this [`Interval`]. If the [`Interval`] had |
There was a problem hiding this comment.
It seems like the "even if that means that it will sleep for longer than the duration" part is not currently tested.
victor-timofei
force-pushed
the
interval-reset
branch
from
2172e0f
to
153cc74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5874
Motivation
The use case is explained in #5874
Solution
It just calls the internal reset on the specified
Instant.I have added a new field to theIntervalstruct to store the previous period.On each tick if previous period isSome()it will be restored.Integration tests will be added on a later commit.