-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare Tokio v1.30.0 release #5917
Conversation
Updated to resolve @NobodyXu's change requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Several changes in the changelog seem to be unrelated to tokio crate. (FYI, the directory-level commit history shows only changes related to tokio crate: https://github.com/tokio-rs/tokio/commits/master/tokio)
@taiki-e made your requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to prepare this PR!
tokio/CHANGELOG.md
Outdated
- rt: add runtime ID (#5864) | ||
- rt: initial implementation of new threaded runtime (#5823) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please turn all of the changelog lines into links. Here's an example of how it should look with two of the links:
- rt: add runtime ID (#5864) | |
- rt: initial implementation of new threaded runtime (#5823) | |
- rt: add runtime ID ([#5864]) | |
- rt: initial implementation of new threaded runtime ([#5823]) | |
[#5823]: https://github.com/tokio-rs/tokio/pull/5823 | |
[#5864]: https://github.com/tokio-rs/tokio/pull/5864 |
Note the two changes:
- Square brackets added around PR number in the commit message.
- Links added at the bottom, in sorted order.
@Darksonn done! |
@taiki-e done! |
@taiki-e thank you! Sorry it took a few passes to get it where you all wanted, thanks for holding my hand 🎉 |
What are the next steps? Do I have to do anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the changelog is ready, you just need to wait for me to get to a laptop. I will merge it at the same time as when I publish it.
tokio/CHANGELOG.md
Outdated
|
||
[#5887]: https://github.com/tokio-rs/tokio/pull/5887 | ||
[#5859]: https://github.com/tokio-rs/tokio/pull/5859 | ||
[#5859]: https://github.com/tokio-rs/tokio/pull/5881 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link appears twice. Please double check the links. We usually sort them to make them easier to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Darksonn done, I did originally consider sorting but I looked at a few prior entries and they weren't sorted but I agree it is best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it depends on who wrote it. I always sort them.
I'm not sure why CI keeps failing, is that something I need to address? |
No. I opened an issue #5920 and I will restart ci. |
@Darksonn sounds good, if any other changes are necessary for this PR I'll be here ready to fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this. I'll merge it later when I get to a laptop.
Please double check whether any new things have been merged in the meantime.
will do! |
@Darksonn there are two commits that have happened since I opened this PR. They are:
I asume the |
@Darksonn nm, looks like you took care of it |
Yeah, thanks for taking the time to prepare this PR. It will be published shortly. |
As requested by @Darksonn in #5887
First time doing this for this project so please let me know if if I need to correct something. I went through all of the commits after the v1.29.1 release on June 29 and tried to sort them into the CHANGELOG buckets that made sense but may have misplaced some.
1.30.0 (August 9, 2023)
This release bumps the MSRV of Tokio to 1.63. (#5887)
Changed
--cfg mio_unsupported_force_poll_poll
flag (#5881)const_new
methods always available (#5885)Added
broadcast::Sender::new
(#5824)UCred
for espidf (#5868)File::options()
(#5869)Interval
(#5878){ChildStd*}::into_owned_{fd, handle}
(#5899)Removed
tokio_*
cfgs (#5890)Documented
broadcast::send
(#5820)AsyncReadExt::read_exact
(#5863)Sleep
as!Unpin
in docs (#5916)raw_arg
not showing up in docs (#5865)Unstable