opentelemetry: Update otel to 0.17.0 #1853

jtescher · 2022-01-22T17:55:07Z

Motivation

Support the latest OpenTelemetry specification. Resolves #1857.

Solution

Update opentelemetry to the latest 0.17.x release. Breaking changes upstream in the tracking of parent contexts in otel's SpanBuilder have necessitated a new OtelData struct to continue pairing tracing spans with their associated otel Context.

## Motivation Support the latest OpenTelemetry specification. ## Solution Update `opentelemetry` to the latest `0.17.x` release. Breaking changes upstream in the tracking of parent contexts in otel's `SpanBuilder` have necessitated a new `OtelData` struct to continue pairing tracing spans with their associated otel `Context`.

davidbarsky · 2022-01-23T02:13:24Z

For what it’s worth, tracing-opentelemetry can abide by a higher MSRV, especially if the opentelemetry has a higher one. tracing-appender already does because the time crate has a higher MSRV.

hawkw · 2022-01-24T18:28:49Z

Looks like CI is failing because opentelemetry increased its MSRV: https://github.com/tokio-rs/tracing/runs/4908254944?check_suite_focus=true#step:4:151

Since the opentelemetry dependency is (of course) required for tracing-opentelemetry, we should just increase the crate's MSRV to whatever opentelemetry requires. We can fix the CI build by adding a separate check job for tracing-opentelemetry on its new MSRV, the way we do for tracing-appender:

tracing/.github/workflows/check_msrv.yml

Lines 49 to 63 in 7eb6005

    
           check-msrv-appender: 
        
             # Run `cargo check` on our minimum supported Rust version (1.51.0). 
        
             runs-on: ubuntu-latest 
        
             steps: 
        
             - uses: actions/checkout@main 
        
             - uses: actions-rs/toolchain@v1 
        
               with: 
        
                 toolchain: 1.53.0 
        
                 profile: minimal 
        
                 override: true 
        
             - name: Check 
        
               uses: actions-rs/cargo@v1 
        
               with: 
        
                 command: check 
        
                 args: --lib=tracing-appender

We'll also have to add tracing-opentelemetry to the list of crates excluded from the main MSRV check job, here:

tracing/.github/workflows/check_msrv.yml

Line 46 in 7eb6005

args: --all --exclude=tracing-appender

In order to increase the crate's MSRV, we'll have to update the rust-version field in Cargo.toml:

tracing/tracing-opentelemetry/Cargo.toml

Line 20 in 7eb6005

rust-version = "1.42.0"

as well as the MSRV documented in the README and lib.rs documentation.

@jtescher, can I get you to update the MSRV so that we can get CI to pass? Then, I think this should probably be good to merge. Thanks!

hawkw

overall, this looks good to me, but we'll need to fix the MSRV issues I mentioned before we can merge this. I commented on a couple other small things.

tracing-opentelemetry/src/subscriber.rs

hawkw · 2022-01-24T18:32:20Z

tracing-opentelemetry/src/lib.rs

+
+/// Per-span OpenTelemetry data tracked by this crate.
+#[derive(Debug, Clone)]
+pub struct OtelData {


Am I correct that this needs to be public because it's used in the PreSampledTracer trait, but it's totally opaque to user code? Is there any reason user code might need to access or mutate this type's fields?

Good point, fields need to be pub for althernate sdk implementations. Will fix.

Added quick comment as well to clarify purpose a bit. Should be opaque to everyone who is not trying to implement PreSampledTracer directly.

jtescher · 2022-01-27T17:09:55Z

@hawkw ok great all passing now ✅

hawkw

lgtm

hawkw · 2022-01-27T19:01:48Z

tracing-opentelemetry/README.md

-Tracing is built against the latest stable release. The minimum supported
-version is 1.42. The current Tracing version is not guaranteed to build on Rust
-versions earlier than the minimum supported version.
+Tracing Opentelemetry is built against the latest stable release. The minimum


nit: should this be

Suggested change

Tracing Opentelemetry is built against the latest stable release. The minimum

Tracing OpenTelemetry is built against the latest stable release. The minimum

hawkw · 2022-01-27T19:02:14Z

tracing-opentelemetry/src/lib.rs

@@ -111,6 +111,8 @@ pub use subscriber::{subscriber, OpenTelemetrySubscriber};
 pub use tracer::PreSampledTracer;

 /// Per-span OpenTelemetry data tracked by this crate.
+///
+/// Useful for implementing [PreSampledTracer] in alternate otel SDKs.


nit

Suggested change

/// Useful for implementing [PreSampledTracer] in alternate otel SDKs.

/// Useful for implementing [`PreSampledTracer`] in alternate otel SDKs.

caizixian · 2022-01-30T04:44:29Z

I'm just wondering whether a new release can be made so that downstream projects can update their dependencies accordingly.

## Motivation Support the latest OpenTelemetry specification. ## Solution Update `opentelemetry` to the latest `0.17.x` release. Breaking changes upstream in the tracking of parent contexts in otel's `SpanBuilder` have necessitated a new `OtelData` struct to continue pairing tracing spans with their associated otel `Context`. # Conflicts: # .github/workflows/check_msrv.yml # tracing-opentelemetry/Cargo.toml # tracing-opentelemetry/benches/trace.rs # tracing-opentelemetry/src/layer.rs # tracing-opentelemetry/src/span_ext.rs # tracing-opentelemetry/tests/trace_state_propagation.rs

Breaking changes in this release: - Upgrade to `v0.17.0` of `opentelemetry` (#1853) For list of breaking changes in OpenTelemetry, see the [v0.17.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md#v0170).

## Motivation Support the latest OpenTelemetry specification. ## Solution Update `opentelemetry` to the latest `0.17.x` release. Breaking changes upstream in the tracking of parent contexts in otel's `SpanBuilder` have necessitated a new `OtelData` struct to continue pairing tracing spans with their associated otel `Context`. # Conflicts: # .github/workflows/check_msrv.yml # tracing-opentelemetry/Cargo.toml # tracing-opentelemetry/benches/trace.rs # tracing-opentelemetry/src/layer.rs # tracing-opentelemetry/src/span_ext.rs # tracing-opentelemetry/tests/trace_state_propagation.rs

Breaking changes in this release: - Upgrade to `v0.17.0` of `opentelemetry` (tokio-rs#1853) For list of breaking changes in OpenTelemetry, see the [v0.17.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md#v0170).

jtescher added the crate/opentelemetry Related to the `tracing-opentelemetry` crate. label Jan 22, 2022

jtescher requested review from davidbarsky, hawkw and a team as code owners January 22, 2022 17:55

jtescher mentioned this pull request Jan 22, 2022

Tracking issue for updating tracing-opentelemetry to opentelemetry 0.17 #1824

Closed

davidbarsky approved these changes Jan 23, 2022

View reviewed changes

This was referenced Jan 24, 2022

chore(deps): update opentelemetry-jaeger requirement from 0.15 to 0.16 #1856

Closed

chore(deps): update opentelemetry requirement from 0.16 to 0.17 #1855

Closed

hawkw approved these changes Jan 24, 2022

View reviewed changes

Geal mentioned this pull request Jan 26, 2022

update opentelemetry to 0.17 apollographql/router#365

Closed

8 tasks

jtescher added 5 commits January 27, 2022 11:18

Update MSRV and fix lints

e2794dd

Make OtelData fields pub

ab45c88

Fix otel msrv job

e94276f

Fix MSRV package exclude syntax

69b2805

Exclude appender in otel msrv checks

705b8e1

hawkw approved these changes Jan 27, 2022

View reviewed changes

Merge branch 'master' into jtescher/update-otel

e087a21

hawkw enabled auto-merge (squash) January 27, 2022 19:03

hawkw merged commit e005548 into master Jan 27, 2022

hawkw deleted the jtescher/update-otel branch January 27, 2022 19:13

This was referenced Jan 30, 2022

opentelemetry: Backport update otel to 0.17.0 #1876

Merged

opentelemetry: prepare for 0.16.0 release #1877

Merged

davidbarsky mentioned this pull request Sep 26, 2023

chore: backport roughly a year's worth of changes #2728

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

opentelemetry: Update otel to 0.17.0 #1853

opentelemetry: Update otel to 0.17.0 #1853

jtescher commented Jan 22, 2022 •

edited by davidbarsky

Loading

davidbarsky commented Jan 23, 2022

hawkw commented Jan 24, 2022

hawkw left a comment

hawkw Jan 24, 2022

jtescher Jan 27, 2022

jtescher Jan 27, 2022

jtescher commented Jan 27, 2022

hawkw left a comment

hawkw Jan 27, 2022

hawkw Jan 27, 2022

caizixian commented Jan 30, 2022

	Tracing Opentelemetry is built against the latest stable release. The minimum
	Tracing OpenTelemetry is built against the latest stable release. The minimum

	/// Useful for implementing [PreSampledTracer] in alternate otel SDKs.
	/// Useful for implementing [`PreSampledTracer`] in alternate otel SDKs.

opentelemetry: Update otel to 0.17.0 #1853

opentelemetry: Update otel to 0.17.0 #1853

Conversation

jtescher commented Jan 22, 2022 • edited by davidbarsky Loading

Motivation

Solution

davidbarsky commented Jan 23, 2022

hawkw commented Jan 24, 2022

hawkw left a comment

Choose a reason for hiding this comment

hawkw Jan 24, 2022

Choose a reason for hiding this comment

jtescher Jan 27, 2022

Choose a reason for hiding this comment

jtescher Jan 27, 2022

Choose a reason for hiding this comment

jtescher commented Jan 27, 2022

hawkw left a comment

Choose a reason for hiding this comment

hawkw Jan 27, 2022

Choose a reason for hiding this comment

hawkw Jan 27, 2022

Choose a reason for hiding this comment

caizixian commented Jan 30, 2022

jtescher commented Jan 22, 2022 •

edited by davidbarsky

Loading