Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry: prepare for 0.16.0 release #1877

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Conversation

jtescher
Copy link
Collaborator

@jtescher jtescher commented Jan 30, 2022

Breaking changes in this release:

@jtescher jtescher added the crate/opentelemetry Related to the `tracing-opentelemetry` crate. label Jan 30, 2022
@jtescher jtescher requested a review from a team as a code owner January 30, 2022 19:43
@jtescher
Copy link
Collaborator Author

@hawkw did we want to move forward with #1869 before merging this one?

@davidbarsky
Copy link
Member

@hawkw did we want to move forward with #1869 before merging this one?

I'm not Eliza, but yes.

Copy link
Member

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the build passes, I'll merge this.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw that #1869 just got merged, but I'm not sure if that was actually the correct solution to the problem. Let's take a minute to make sure that change was correct before we publish this release, please.

@jtescher
Copy link
Collaborator Author

jtescher commented Feb 1, 2022

Previous Discord comment context

Hi, is it possible to separate log and tracing?
I tried disabling tracing-log but I cannot turn-off default-features of tracing-subscriber which is a dependncy of tracing-opentelemetry

tracing-opentelemetry = { version = "0.16.0", optional = true, default-features = false }
tracing-subscriber = { version = "0.3.6", default-features = false, features = [
    "smallvec",
    "std",
] }
$ cargo tree -i -p tracing-log
tracing-log v0.1.2
└── tracing-subscriber v0.3.6
    ├── mylib
    └── tracing-opentelemetry v0.16.0
        └── mylib

I cannot reproduce that example. E.g. This example Cargo.toml

[package]
name = "test"
version = "0.1.0"
edition = "2021"

[dependencies]
opentelemetry = "0.16.0"
tracing = "0.1.29"
tracing-opentelemetry = { version = "0.16.0", default-features = false }
tracing-subscriber = { version = "0.3.6", default-features = false, features = [ "smallvec", "std", ] }

tracing-log is not included if default-features = false.

$ cargo tree -i -p tracing-log
error: package ID specification `tracing-log` did not match any packages

#1869 was not to fix the above case, but to simply not require opting out explicitly.

tracing-opentelemetry/CHANGELOG.md Outdated Show resolved Hide resolved
@hawkw hawkw enabled auto-merge (squash) February 3, 2022 19:18
@hawkw hawkw merged commit cdac451 into master Feb 3, 2022
@hawkw hawkw deleted the jtescher/otel-release branch February 3, 2022 19:31
hawkw pushed a commit that referenced this pull request Feb 3, 2022
Breaking changes in this release:

- Upgrade to `v0.17.0` of `opentelemetry` (#1853)
  For list of breaking changes in OpenTelemetry, see the [v0.17.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md#v0170).
hawkw pushed a commit that referenced this pull request Feb 3, 2022
Breaking changes in this release:

- Upgrade to `v0.17.0` of `opentelemetry` (#1853)
  For list of breaking changes in OpenTelemetry, see the [v0.17.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md#v0170).
hawkw pushed a commit that referenced this pull request Feb 3, 2022
Breaking changes in this release:

- Upgrade to `v0.17.0` of `opentelemetry` (#1853)
  For list of breaking changes in OpenTelemetry, see the [v0.17.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md#v0170).
hawkw pushed a commit that referenced this pull request Feb 3, 2022
Breaking changes in this release:

- Upgrade to `v0.17.0` of `opentelemetry` (#1853)
  For list of breaking changes in OpenTelemetry, see the [v0.17.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md#v0170).
hawkw pushed a commit that referenced this pull request Feb 4, 2022
Breaking changes in this release:

- Upgrade to `v0.17.0` of `opentelemetry` (#1853)
  For list of breaking changes in OpenTelemetry, see the [v0.17.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md#v0170).
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
Breaking changes in this release:

- Upgrade to `v0.17.0` of `opentelemetry` (tokio-rs#1853)
  For list of breaking changes in OpenTelemetry, see the [v0.17.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md#v0170).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate/opentelemetry Related to the `tracing-opentelemetry` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants