Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update MSRVs from 1.42 to 1.49 #1913

Merged
merged 1 commit into from
Feb 7, 2022
Merged

chore: update MSRVs from 1.42 to 1.49 #1913

merged 1 commit into from
Feb 7, 2022

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Feb 7, 2022 •
edited
Loading

This updates all crates' MSRVs to 1.49 if they were not already greater
than that (tracing-appender is at 1.53). Rust 1.49+ is required to
update parking_lot to v0.12 (see #1878). Also, futures-task (which I
believe is only needed as a transitive dep) now needs 1.45+, so this
also fixes our CI build.

Because tracing-opentelemetry previously required 1.46.0, it had a
separate CI MSRV job. Since 1.49.0 is greater than 1.46.0, the separate
check for tracing-opentelemetry is no longer needed.

In the process, I removed deprecated uses of
core::atomic::spin_loop_hint, which is replaced with
core::hint::spin_loop in 1.49.

@hawkw
chore: update MSRVs from 1.42 to 1.49
0012970 
This updates all crates' MSRVs to 1.49 if they were not already greater
than that (`tracing-appender` is at 1.53). Rust 1.49+ is required to
update `parking_lot` to v0.12 (see #1878). Also, `futures-task` (which I
believe is only needed as a transitive dep) now needs 1.45+, so this
also fixes our CI build.

In the process, I removed deprecated uses of
`core::atomic::spin_loop_hint`, which is replaced with
`core::hint::spin_loop` in 1.49.
@hawkw hawkw enabled auto-merge (squash) February 7, 2022 17:43
jtescher
jtescher approved these changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@hawkw hawkw merged commit 4365b39 into master Feb 7, 2022
@hawkw hawkw deleted the eliza/msrv-1.49 branch February 7, 2022 17:52
hawkw added a commit that referenced this pull request Feb 7, 2022
@hawkw
chore: update MSRVs from 1.42 to 1.49 (#1913)
908e563 
This updates all crates' MSRVs to 1.49 if they were not already greater
than that (`tracing-appender` is at 1.53). Rust 1.49+ is required to
update `parking_lot` to v0.12 (see #1878). Also, `futures-task` (which I
believe is only needed as a transitive dep) now needs 1.45+, so this
also fixes our CI build.

Because `tracing-opentelemetry` previously required 1.46.0, it had a
separate CI MSRV job. Since 1.49.0 is greater than 1.46.0, the separate
check for `tracing-opentelemetry` is no longer needed.

In the process, I removed deprecated uses of
`core::atomic::spin_loop_hint`, which is replaced with
`core::hint::spin_loop` in 1.49.
@hawkw hawkw mentioned this pull request Feb 7, 2022
Merged
hawkw added a commit that referenced this pull request Feb 7, 2022
@hawkw
chore: update MSRVs from 1.42 to 1.49 (#1913)
3222527 
This updates all crates' MSRVs to 1.49 if they were not already greater
than that (`tracing-appender` is at 1.53). Rust 1.49+ is required to
update `parking_lot` to v0.12 (see #1878). Also, `futures-task` (which I
believe is only needed as a transitive dep) now needs 1.45+, so this
also fixes our CI build.

Because `tracing-opentelemetry` previously required 1.46.0, it had a
separate CI MSRV job. Since 1.49.0 is greater than 1.46.0, the separate
check for `tracing-opentelemetry` is no longer needed.

In the process, I removed deprecated uses of
`core::atomic::spin_loop_hint`, which is replaced with
`core::hint::spin_loop` in 1.49.
hawkw added a commit that referenced this pull request Feb 8, 2022
@hawkw
journald: prepare to release v0.2.3
1b22133 
# 0.2.3 (February 7, 2022)

### Fixed

- Fixed missing `memfd_create` with `glibc` versions < 2.25 ([#1912])

### Changed

- Updated minimum supported Rust version to 1.49.0 ([#1913])

Thanks to @9999years for contributing to this release!

[#1912]: #1912
[#1913]: #1913
@hawkw hawkw mentioned this pull request Feb 8, 2022
Merged
hawkw added a commit that referenced this pull request Feb 8, 2022
@hawkw
journald: prepare to release v0.2.3
3280f79 
# 0.2.3 (February 7, 2022)

### Fixed

- Fixed missing `memfd_create` with `glibc` versions < 2.25 ([#1912])

### Changed

- Updated minimum supported Rust version to 1.49.0 ([#1913])

Thanks to @9999years for contributing to this release!

[#1912]: #1912
[#1913]: #1913
@arlyon
Copy link

arlyon commented Feb 10, 2022 •
edited
Loading

Hello, something of note is that tokio-rs/valuable specifies 1.51.0 as the minimal rust version:

https://github.com/tokio-rs/valuable/blob/master/valuable/Cargo.toml#L6

Any crates that depend on it such as tracing-core, tracing-subscriber, and tracing-serde (according to the reverse depedencies) should be bumped to that as well.

I have hit this issue with arlyon/async-stripe, which targets 1.49.0, but is currently failing CI. See here: https://github.com/arlyon/async-stripe/runs/5143921274?check_suite_focus=true

@arlyon
Copy link

arlyon commented Feb 10, 2022

For some context, valuable is in my Cargo.lock file due to it being a requirement of tracing-core, and requires from quick checking at least version 1.51.0 otherwise cargo metadata breaks.

The exact cause of the CI breakage (it's not failing builds!) is that tarpaulin uses cargo metadata internally which fails.

This was referenced Feb 10, 2022
Merged
Closed
hawkw added a commit that referenced this pull request Feb 17, 2022
@hawkw
tracing: prepare to release v0.1.31
2531ec8 
# 0.1.31 (February 17th, 2022)

This release increases the minimum supported Rust version (MSRV) to
1.49.0. In addition, it fixes some relatively rare macro bugs.

### Added

- Added `tracing-forest` to the list of related crates ([#1935])

### Changed

- Updated minimum supported Rust version (MSRV) to 1.49.0 ([#1913])

### Fixed

- Fixed the `warn!` macro incorrectly generating an event with the
  `TRACE` level ([#1930])
- Fixed macro hygiene issues when used in a crate that defines its own
  `concat!` macro, for real this time ([#1918])

Thanks to @QnnOkabayashi, @nicolaasg, and @teohhanhui for contributing
to this release!

[#1935]: #1935
[#1913]: #1913
[#1930]: #1930
[#1918]: #1918
@hawkw hawkw mentioned this pull request Feb 17, 2022
Merged
hawkw added a commit that referenced this pull request Feb 17, 2022
@hawkw
tracing: prepare to release v0.1.31 (#1937)
846a53e 
# 0.1.31 (February 17th, 2022)

This release increases the minimum supported Rust version (MSRV) to
1.49.0. In addition, it fixes some relatively rare macro bugs.

### Added

- Added `tracing-forest` to the list of related crates ([#1935])

### Changed

- Updated minimum supported Rust version (MSRV) to 1.49.0 ([#1913])

### Fixed

- Fixed the `warn!` macro incorrectly generating an event with the
  `TRACE` level ([#1930])
- Fixed macro hygiene issues when used in a crate that defines its own
  `concat!` macro, for real this time ([#1918])

Thanks to @QnnOkabayashi, @nicolaasg, and @teohhanhui for contributing
to this release!

[#1935]: #1935
[#1913]: #1913
[#1930]: #1930
[#1918]: #1918
hawkw added a commit that referenced this pull request Feb 17, 2022
@hawkw
subscriber: prepare to release v0.3.9
ad3fd76 
# 0.3.9 (Feb 17, 2022)

This release updates the minimum supported Rust version (MSRV) to
1.49.0, and updates the (optional) dependency on `parking_lot` to v0.12.

### Changed

- Updated minimum supported Rust version (MSRV) to 1.49.0 ([#1913])
- `parking_lot`: updated to v0.12 ([008339d])

### Added

- **fmt**: Documentation improvements ([#1926], [#1927])

[#1913]: #1913
[#1926]: #1926
[#1927]: #1927
[008339d]: 008339d
@hawkw hawkw mentioned this pull request Feb 17, 2022
Merged
hawkw added a commit that referenced this pull request Feb 18, 2022
@hawkw
subscriber: prepare to release v0.3.9 (#1938)
2974ae9 
# 0.3.9 (Feb 17, 2022)

This release updates the minimum supported Rust version (MSRV) to
1.49.0, and updates the (optional) dependency on `parking_lot` to v0.12.

### Changed

- Updated minimum supported Rust version (MSRV) to 1.49.0 ([#1913])
- `parking_lot`: updated to v0.12 ([008339d])

### Added

- **fmt**: Documentation improvements ([#1926], [#1927])

[#1913]: #1913
[#1926]: #1926
[#1927]: #1927
[008339d]: 008339d
hawkw added a commit that referenced this pull request Mar 8, 2022
@hawkw
attributes: prepare to release v0.1.20
d9c90f1 
# 0.1.20 (March 8, 2022)

### Fixed

- Compilation failure with `--minimal-versions` due to a too-permissive
  `syn` dependency ([#1960])

### Changed

- Bumped minimum supported Rust version (MSRV) to 1.49.0 ([#1913])

Thanks to new contributor @udoprog for contributing to this release!

[#1960]: #1960
[#1913]: #1913
@hawkw hawkw mentioned this pull request Mar 8, 2022
Merged
hawkw added a commit that referenced this pull request Mar 8, 2022
@hawkw
attributes: prepare to release v0.1.20 (#1976)
fda0aa4 
# 0.1.20 (March 8, 2022)

### Fixed

- Compilation failure with `--minimal-versions` due to a too-permissive
  `syn` dependency ([#1960])

### Changed

- Bumped minimum supported Rust version (MSRV) to 1.49.0 ([#1913])

Thanks to new contributor @udoprog for contributing to this release!

[#1960]: #1960
[#1913]: #1913
hawkw added a commit that referenced this pull request Mar 9, 2022
@hawkw
core: prepare to release 0.1.23
12605bc 
# 0.1.23 (March 8, 2022)

### Changed

- Removed `#[inline]` attributes from some `Dispatch` methods whose
  callers are now inlined ([#1974])
- Bumped minimum supported Rust version (MSRV) to Rust 1.49.0 ([#1913])

[#1913]: #1913
[#1974]: #1974
@hawkw hawkw mentioned this pull request Mar 9, 2022
Merged
hawkw added a commit that referenced this pull request Mar 9, 2022
@hawkw
core: prepare to release 0.1.23 (#1977)
c6acb12 
# 0.1.23 (March 8, 2022)

### Changed

- Removed `#[inline]` attributes from some `Dispatch` methods whose
  callers are now inlined ([#1974])
- Bumped minimum supported Rust version (MSRV) to Rust 1.49.0 ([#1913])

[#1913]: #1913
[#1974]: #1974
hawkw added a commit that referenced this pull request Apr 21, 2022
@hawkw
log: prepare to release v0.1.3
3eafee2 
# 0.1.3 (April 21st, 2022)

### Added

- **log-tracer**: Added `LogTracer::with_interest_cache` to enable a
 limited form of per-record `Interest` caching for `log` records
 ([#1636])

### Changed

- Updated minimum supported Rust version (MSRV) to Rust 1.49.0 ([#1913])

### Fixed

- **log-tracer**: Fixed `LogTracer` not honoring `tracing` max level
  filters ([#1543])
- Broken links in documentation ([#2068], [#2077])

Thanks to @Millione, @teozkr, @koute, @Folyd, and @ben0x539 for
contributing to this release!

[#1636]: https://github.com/tokio-rs/tracing/pulls/1636
[#1913]: https://github.com/tokio-rs/tracing/pulls/1913
[#1543]: https://github.com/tokio-rs/tracing/pulls/1543
[#2068]: https://github.com/tokio-rs/tracing/pulls/2068
[#2077]: https://github.com/tokio-rs/tracing/pulls/2077
hawkw added a commit that referenced this pull request Apr 21, 2022
@hawkw
log: prepare to release v0.1.3 (#2086)
cdbd122 
# 0.1.3 (April 21st, 2022)

### Added

- **log-tracer**: Added `LogTracer::with_interest_cache` to enable a
 limited form of per-record `Interest` caching for `log` records
 ([#1636])

### Changed

- Updated minimum supported Rust version (MSRV) to Rust 1.49.0 ([#1913])

### Fixed

- **log-tracer**: Fixed `LogTracer` not honoring `tracing` max level
  filters ([#1543])
- Broken links in documentation ([#2068], [#2077])

Thanks to @Millione, @teozkr, @koute, @Folyd, and @ben0x539 for
contributing to this release!

[#1636]: https://github.com/tokio-rs/tracing/pulls/1636
[#1913]: https://github.com/tokio-rs/tracing/pulls/1913
[#1543]: https://github.com/tokio-rs/tracing/pulls/1543
[#2068]: https://github.com/tokio-rs/tracing/pulls/2068
[#2077]: https://github.com/tokio-rs/tracing/pulls/2077

Fixes #1884
Fixes #1664
@jtescher jtescher mentioned this pull request Jun 16, 2022
Merged
@davidbarsky davidbarsky mentioned this pull request Sep 26, 2023
Merged
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
chore: update MSRVs from 1.42 to 1.49 (tokio-rs#1913)
34448d7 
This updates all crates' MSRVs to 1.49 if they were not already greater
than that (`tracing-appender` is at 1.53). Rust 1.49+ is required to
update `parking_lot` to v0.12 (see tokio-rs#1878). Also, `futures-task` (which I
believe is only needed as a transitive dep) now needs 1.45+, so this
also fixes our CI build.

Because `tracing-opentelemetry` previously required 1.46.0, it had a
separate CI MSRV job. Since 1.49.0 is greater than 1.46.0, the separate
check for `tracing-opentelemetry` is no longer needed.

In the process, I removed deprecated uses of
`core::atomic::spin_loop_hint`, which is replaced with
`core::hint::spin_loop` in 1.49.
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
journald: prepare to release v0.2.3
c9594ee 
# 0.2.3 (February 7, 2022)

### Fixed

- Fixed missing `memfd_create` with `glibc` versions < 2.25 ([tokio-rs#1912])

### Changed

- Updated minimum supported Rust version to 1.49.0 ([tokio-rs#1913])

Thanks to @9999years for contributing to this release!

[tokio-rs#1912]: tokio-rs#1912
[tokio-rs#1913]: tokio-rs#1913
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
tracing: prepare to release v0.1.31 (tokio-rs#1937)
e479e06 
# 0.1.31 (February 17th, 2022)

This release increases the minimum supported Rust version (MSRV) to
1.49.0. In addition, it fixes some relatively rare macro bugs.

### Added

- Added `tracing-forest` to the list of related crates ([tokio-rs#1935])

### Changed

- Updated minimum supported Rust version (MSRV) to 1.49.0 ([tokio-rs#1913])

### Fixed

- Fixed the `warn!` macro incorrectly generating an event with the
  `TRACE` level ([tokio-rs#1930])
- Fixed macro hygiene issues when used in a crate that defines its own
  `concat!` macro, for real this time ([tokio-rs#1918])

Thanks to @QnnOkabayashi, @nicolaasg, and @teohhanhui for contributing
to this release!

[tokio-rs#1935]: tokio-rs#1935
[tokio-rs#1913]: tokio-rs#1913
[tokio-rs#1930]: tokio-rs#1930
[tokio-rs#1918]: tokio-rs#1918
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
subscriber: prepare to release v0.3.9 (tokio-rs#1938)
d63c14f 
# 0.3.9 (Feb 17, 2022)

This release updates the minimum supported Rust version (MSRV) to
1.49.0, and updates the (optional) dependency on `parking_lot` to v0.12.

### Changed

- Updated minimum supported Rust version (MSRV) to 1.49.0 ([tokio-rs#1913])
- `parking_lot`: updated to v0.12 ([008339d])

### Added

- **fmt**: Documentation improvements ([tokio-rs#1926], [tokio-rs#1927])

[tokio-rs#1913]: tokio-rs#1913
[tokio-rs#1926]: tokio-rs#1926
[tokio-rs#1927]: tokio-rs#1927
[008339d]: tokio-rs@008339d
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
attributes: prepare to release v0.1.20 (tokio-rs#1976)
c8b4396 
# 0.1.20 (March 8, 2022)

### Fixed

- Compilation failure with `--minimal-versions` due to a too-permissive
  `syn` dependency ([tokio-rs#1960])

### Changed

- Bumped minimum supported Rust version (MSRV) to 1.49.0 ([tokio-rs#1913])

Thanks to new contributor @udoprog for contributing to this release!

[tokio-rs#1960]: tokio-rs#1960
[tokio-rs#1913]: tokio-rs#1913
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
core: prepare to release 0.1.23 (tokio-rs#1977)
0c8fcf4 
# 0.1.23 (March 8, 2022)

### Changed

- Removed `#[inline]` attributes from some `Dispatch` methods whose
  callers are now inlined ([tokio-rs#1974])
- Bumped minimum supported Rust version (MSRV) to Rust 1.49.0 ([tokio-rs#1913])

[tokio-rs#1913]: tokio-rs#1913
[tokio-rs#1974]: tokio-rs#1974
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
log: prepare to release v0.1.3 (tokio-rs#2086)
f04ba10 
# 0.1.3 (April 21st, 2022)

### Added

- **log-tracer**: Added `LogTracer::with_interest_cache` to enable a
 limited form of per-record `Interest` caching for `log` records
 ([tokio-rs#1636])

### Changed

- Updated minimum supported Rust version (MSRV) to Rust 1.49.0 ([tokio-rs#1913])

### Fixed

- **log-tracer**: Fixed `LogTracer` not honoring `tracing` max level
  filters ([tokio-rs#1543])
- Broken links in documentation ([tokio-rs#2068], [tokio-rs#2077])

Thanks to @Millione, @teozkr, @koute, @Folyd, and @ben0x539 for
contributing to this release!

[tokio-rs#1636]: https://github.com/tokio-rs/tracing/pulls/1636
[tokio-rs#1913]: https://github.com/tokio-rs/tracing/pulls/1913
[tokio-rs#1543]: https://github.com/tokio-rs/tracing/pulls/1543
[tokio-rs#2068]: https://github.com/tokio-rs/tracing/pulls/2068
[tokio-rs#2077]: https://github.com/tokio-rs/tracing/pulls/2077

Fixes tokio-rs#1884
Fixes tokio-rs#1664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbarsky davidbarsky davidbarsky approved these changes

@jtescher jtescher jtescher approved these changes

@carllerche carllerche Awaiting requested review from carllerche carllerche is a code owner

@yaahc yaahc Awaiting requested review from yaahc yaahc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkw @arlyon @jtescher @davidbarsky