Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] add new platform msn2201 #8

Closed
wants to merge 12 commits into from
Closed

[Mellanox] add new platform msn2201 #8

wants to merge 12 commits into from

Conversation

tomer-israel
Copy link
Owner

@tomer-israel tomer-israel commented Aug 18, 2021

Signed-off-by: tomeri tomeri@nvidia.com

Why I did it

add new files for the new platform MSN2201

How I did it

added new device folder and platform device files to it based on (msn2700)
some of the files are linked to msn2700 and some were changed according to the new device specification (ports, speeds)

How to verify it

run with these files on the new HW

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: tomeri <tomeri@nvidia.com>
Signed-off-by: tomeri <tomeri@nvidia.com>
@dprital
Copy link
Collaborator

dprital commented Aug 19, 2021

Please remove the backport from 202012.

Copy link
Collaborator

@dprital dprital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add NVIDIA Copyright header for the files

device/mellanox/x86_64-mlnx_msn2201-r0/sensors.conf Outdated Show resolved Hide resolved
@keboliu
Copy link

keboliu commented Aug 20, 2021

  1. Currently all other existing platforms are all installed with SFP cages, this is the first time we have RJ45, so in platform API chassis object initialization, it should ignore the RJ45 ports. You may need to start from here to check https://github.com/Azure/sonic-buildimage/blob/master/platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py#L68
  2. You need to fill in device data for 2201 in https://github.com/Azure/sonic-buildimage/blob/master/platform/mellanox/mlnx-platform-api/sonic_platform/device_data.py

Signed-off-by: tomeri <tomeri@nvidia.com>
@moshemos
Copy link

  1. Buffer configuration. Should be approved by @stephen Sun - Done! should be as SN2700
  2. How can pcied is provided? Who provided the info on the new system? was Yehuda and his team confirmed it? this is no Nvidia switch but rather a DNI switch so it might be the same and might not.
  3. Is the default speed of the ports is 1G and not 100M? is this aligned with the MRD?
  4. SAI profile was approved by Itai? No - Sai will be supported 2 days after Itay will get the platform for bring up
  5. device/mellanox/x86_64-mlnx_msn2201-r0/platform.json:
    a. Product name is 2700. Wrong.
    b. Are there 3 CPLD files for this system? who confirmed?
    c. Fans configuration – who confirmed? It was not tested to real hw
    d. Psu configuration – who confirmed? It was not tested to real hw
    e. Thermal configuration – who confirmed? It was not tested to real hw
    f. 1G/100M should be supported. Missing 100m support for all ports. Not aligned with the mrd.
  6. device/mellanox/x86_64-mlnx_msn2201-r0/platform_components.json
    There is an assumption we are upble to upgrade them. Was this discussed with Yehuda? Are the tools used today are good enough? there is open item on the alligator weekly which is not solved yet.
  7. device/mellanox/x86_64-mlnx_msn2201-r0/sensors.conf
    a. Device name is 2700. Wrong.
    b. As there is no real hw how these file is generated?

Signed-off-by: tomeri <tomeri@nvidia.com>
Signed-off-by: tomeri <tomeri@nvidia.com>
Signed-off-by: tomeri <tomeri@nvidia.com>
Signed-off-by: tomeri <tomeri@nvidia.com>
Signed-off-by: tomeri <tomeri@nvidia.com>
@tomer-israel
Copy link
Owner Author

  1. Buffer configuration. Should be approved by @stephen Sun - Done! should be as SN2700
  2. How can pcied is provided? Who provided the info on the new system? was Yehuda and his team confirmed it? this is no Nvidia switch but rather a DNI switch so it might be the same and might not.
  3. Is the default speed of the ports is 1G and not 100M? is this aligned with the MRD?
  4. SAI profile was approved by Itai? No - Sai will be supported 2 days after Itay will get the platform for bring up
  5. device/mellanox/x86_64-mlnx_msn2201-r0/platform.json:
    a. Product name is 2700. Wrong.
    b. Are there 3 CPLD files for this system? who confirmed?
    c. Fans configuration – who confirmed? It was not tested to real hw
    d. Psu configuration – who confirmed? It was not tested to real hw
    e. Thermal configuration – who confirmed? It was not tested to real hw
    f. 1G/100M should be supported. Missing 100m support for all ports. Not aligned with the mrd.
  6. device/mellanox/x86_64-mlnx_msn2201-r0/platform_components.json
    There is an assumption we are upble to upgrade them. Was this discussed with Yehuda? Are the tools used today are good enough? there is open item on the alligator weekly which is not solved yet.
  7. device/mellanox/x86_64-mlnx_msn2201-r0/sensors.conf
    a. Device name is 2700. Wrong.
    b. As there is no real hw how these file is generated?
  1. done
  2. Yehuda's team gave us the values of the pcie
  3. the default speed is 1G, according to Haim Raz: "Always max, 1G for the RJ45 base-t and 100G for the qsfp-28."
  4. on the sai xml the "port-speed" for the RJ-45 is unknown, itai needs to supply the port-speed for the rj45
  5. i discussed with the hw-management team about the values: cpld, fans, psu, thermal values should be fine.
    about the 1g/100m speeds on dynamic port breakout: I didnt add the 100M for the DPB , I have a different PR for this support and we need to think if the 100M is needed for the DPB mode.
    Add support for RJ45 speeds on dynamic breakout mode #9
  6. I will take it with Yehuda
  7. new file was received from hw-management

Signed-off-by: tomeri <tomeri@nvidia.com>
Signed-off-by: tomeri <tomeri@nvidia.com>
Signed-off-by: tomeri <tomeri@nvidia.com>
# 13 2201
{
THERMAL_DEV_CATEGORY_CPU_CORE:(0, 2),
THERMAL_DEV_CATEGORY_MODULE:(1, 56),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check with Vadim/Michael that we can use all the ports for thermal. Not sure that the ports which are RJ45 are. maybe we can specific a range of the 4 100g ports only?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RJ45 don't have thermals.
I will change it to, so we need to change it to:
THERMAL_DEV_CATEGORY_MODULE:(52, 4)

I will test it and update it

}
},
'x86_64-nvidia_sn2201-r0': {
'thermal': {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check with Vadim/Michael if this is the right definition for termal. I am not aware we got a clear statement.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answer from vadim:
"Regarding “minimum_table” – as far as I know we didn’t get dynamic minimum table for Alligator yet. In hw-mgmt thermal algorithm we consider all corners to be at 60%."

@tomer-israel tomer-israel force-pushed the MSN2201 branch 2 times, most recently from a4efe06 to a130986 Compare November 1, 2021 10:25
@tomer-israel tomer-israel force-pushed the MSN2201 branch 3 times, most recently from 38e93d1 to a50e8c6 Compare November 15, 2021 16:26
tomer-israel pushed a commit that referenced this pull request Nov 16, 2021
Update Barefoot platform support for Bullseye and 5.10 kernel, and add
python3-venv.
Signed-off-by: tomeri <tomeri@nvidia.com>
@liorghub
Copy link
Collaborator

Code taken to:
liorghub#20

@liorghub liorghub reopened this Nov 18, 2021
@liorghub liorghub closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants