Add support for RJ45 speeds on dynamic breakout mode #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrallen
reviewed
Oct 4, 2021
| @@ -47,7 +47,7 @@ module sonic-breakout_cfg { | |||
| * Add any other breakout-mode to allow Dynamic Port | |||
| * Breakout to that breakout-mode. | |||
| */ | |||
| pattern '1x100G\[40G\]|2x50G|4x25G\[10G\]|2x25G\(2\)\+1x50G\(2\)|1x50G\(2\)\+2x25G\(2\)|1x400G|2x200G|4x100G|8x50G|1x200G\[100G,50G,40G,25G,10G,1G\]|2x100G\[50G,40G,25G,10G,1G\]|4x50G\[40G,25G,10G,1G\]|1x25G\[10G\]|1x100G\[50G,40G,25G,10G\]|2x50G\[40G,25G,10G\]|4x25G\[10G\]|1x25G\[10G,1G\]|1x100G\[50G,40G,25G,10G,1G\]|2x50G\[40G,25G,10G,1G\]|4x25G\[10G,1G\]|1x400G\[200G,100G,50G,40G,25G,10G,1G\]|2x200G\[100G,50G,40G,25G,10G,1G\]|4x100G\[50G,40G,25G,10G,1G\]'; | |||
| pattern '1x100G\[40G\]|2x50G|4x25G\[10G\]|2x25G\(2\)\+1x50G\(2\)|1x50G\(2\)\+2x25G\(2\)|1x400G|2x200G|4x100G|8x50G|1x200G\[100G,50G,40G,25G,10G,1G\]|2x100G\[50G,40G,25G,10G,1G\]|4x50G\[40G,25G,10G,1G\]|1x25G\[10G\]|1x100G\[50G,40G,25G,10G\]|2x50G\[40G,25G,10G\]|4x25G\[10G\]|1x25G\[10G,1G\]|1x100G\[50G,40G,25G,10G,1G\]|2x50G\[40G,25G,10G,1G\]|4x25G\[10G,1G\]|1x400G\[200G,100G,50G,40G,25G,10G,1G\]|2x200G\[100G,50G,40G,25G,10G,1G\]|4x100G\[50G,40G,25G,10G,1G\]|1x1G[100M]'; | |||
There was a problem hiding this comment.
I'm not sure this change is sufficient for what you may want. This is about to be a moot point regardless when sonic-net#6801 is merged (which is hopefully imminent) but just as an FYI what you have added will ONLY allow the 1x1G[100M] mode. I.e. 100M would not be allowed in any breakouts or in any higher speed modes i.e. 1x10G[1G, 100M].
|
Looking at this change, it seems that the only effective change is allowing the "M" to be provided after the speed. By default, if "G" is not specified the speed is interpreted in Mbps. I want to clarify that is is your intention and that you are not under the impression than anything else is being functionally changed here. If this is intended to be upstreamed to vanilla SONiC we might run into some protest from the community for this change since it is not "functional" |
alexrallen
approved these changes
Oct 4, 2021
tomer-israel
changed the title
dprital
reviewed
Oct 10, 2021
| @@ -47,7 +47,7 @@ module sonic-breakout_cfg { | |||
| * Add any other breakout-mode to allow Dynamic Port | |||
| * Breakout to that breakout-mode. | |||
| */ | |||
| pattern '1x100G\[40G\]|2x50G|4x25G\[10G\]|2x25G\(2\)\+1x50G\(2\)|1x50G\(2\)\+2x25G\(2\)|1x400G|2x200G|4x100G|8x50G|1x200G\[100G,50G,40G,25G,10G,1G\]|2x100G\[50G,40G,25G,10G,1G\]|4x50G\[40G,25G,10G,1G\]|1x25G\[10G\]|1x100G\[50G,40G,25G,10G\]|2x50G\[40G,25G,10G\]|4x25G\[10G\]|1x25G\[10G,1G\]|1x100G\[50G,40G,25G,10G,1G\]|2x50G\[40G,25G,10G,1G\]|4x25G\[10G,1G\]|1x400G\[200G,100G,50G,40G,25G,10G,1G\]|2x200G\[100G,50G,40G,25G,10G,1G\]|4x100G\[50G,40G,25G,10G,1G\]'; | |||
| pattern '1x100G\[40G\]|2x50G|4x25G\[10G\]|2x25G\(2\)\+1x50G\(2\)|1x50G\(2\)\+2x25G\(2\)|1x400G|2x200G|4x100G|8x50G|1x200G\[100G,50G,40G,25G,10G,1G\]|2x100G\[50G,40G,25G,10G,1G\]|4x50G\[40G,25G,10G,1G\]|1x25G\[10G\]|1x100G\[50G,40G,25G,10G\]|2x50G\[40G,25G,10G\]|4x25G\[10G\]|1x25G\[10G,1G\]|1x100G\[50G,40G,25G,10G,1G\]|2x50G\[40G,25G,10G,1G\]|4x25G\[10G,1G\]|1x400G\[200G,100G,50G,40G,25G,10G,1G\]|2x200G\[100G,50G,40G,25G,10G,1G\]|4x100G\[50G,40G,25G,10G,1G\]|1x1G[100M]'; | |||
There was a problem hiding this comment.
It seems that you need to add "" to the end of definition "1G[100M"] + add also "1G[]"
5 tasks
tomer-israel
force-pushed
the
MSN2201
branch
2 times, most recently
from
a4efe06 to
a130986
Compare
tomer-israel
force-pushed
the
MSN2201
branch
3 times, most recently
from
38e93d1 to
a50e8c6
Compare
tomer-israel
force-pushed
the
MSN2201
branch
2 times, most recently
from
b749ef5 to
934ab11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
need to support the new speeds 1G & 100M on the breakout modes
How I did it
added to portconfig.py the support for speeds with character 'M' (Mega)
How to verify it
configure manually speeds on hwsku & platform.json the breakout mode 1G[100M] & 100M[1G]
Which release branch to backport (provide reason below if selected)
Description for the changelog
Add new support for 100M speeds on breakout mode