Mark AsciiString::new() as 'const fn' #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 'Vec::new()' is already a const function,
there is no difference in generated MIR/ASM whether
AsciiString::new()
is markedconst
or not.I saw issue #56 is waiting to mark this function as 'const',
and this PR simply marks 'AsciiString::new()' as a const fn.
cargo test
successfully passed all tests in my local environment.Thank you for reviewing this PR 😸
p.s.
I compared the generated MIR and ASM from https://play.rust-lang.org with/without
const
.