Upgrade to tokio 1.0 #454
Merged
Upgrade to tokio 1.0 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e00E
force-pushed
the
tokio-1.0
branch
4 times, most recently
from
88b32b3
to
78a134e
Compare
|
Awesome! |
|
They have merged the PR but haven't had a release to crates.io yet so we still have to wait: |
|
✔️ |
Merged
This was referenced Mar 25, 2021
Closed
|
@e00E do you mind rebasing the PR? I'm considering merging this even with |
|
Done. Btw you won't be able to make a crates.io release with a git dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #445
This should not be merged yet because there are two git dependencies. For both crates I have created PRs to update them to tokio 1.0 but they have not been merged yet: