add http-rustls feature #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! |
|
A new OpenSSL release comes out tomorrow, that fixes yet another critical security issue:
it would be great to get rid of OpenSSL with this PR. |
|
@toxeus do you mind addressing build issues? |
|
@tomusdrw done |
tomusdrw
reviewed
Mar 26, 2021
|
Yes, our troublemaker crate is pulling in openssl 😉 I have updated the README. |
The existing `http-tls` feature enables TLS support via `hyper-tls` which in turn pulls in OpenSSL on Linux via `native-tls`. OpenSSL is written in C and has a long history of vulnerabilities caused by memory corruption. The new `http-rustls` feature allows to choose a TLS implementation that is written in Rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
http-tlsfeature enables TLS support viahyper-tlswhich in turn pulls in OpenSSL on Linux vianative-tls. OpenSSL is written in C and has a long history of vulnerabilities caused by memory corruption.The new
http-rustlsfeature allows to choose a TLS implementation that is written in Rust.Depends on #454 being merged first. I'll rebase once that happens.