Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

issue 2868 fix #248

Merged
merged 11 commits into from
Jul 30, 2019
Merged

issue 2868 fix #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
56fc79b
Update register.scss
PrakashDurlabhji Jul 19, 2019
b6d7225
Merge branch 'qa-accessibility' into issue_2868
PrakashDurlabhji Jul 24, 2019
ce087dd
Update tc-ui.scss
PrakashDurlabhji Jul 24, 2019
6a41b6e
Update toggle-password-with-tips.directive.jade
PrakashDurlabhji Jul 24, 2019
fdf8a0c
Update register.jade
PrakashDurlabhji Jul 24, 2019
7e657a3
Update tc-ui.scss
PrakashDurlabhji Jul 25, 2019
48d532e
Update register.scss
PrakashDurlabhji Jul 25, 2019
2b5e9fd
Merge branch 'qa-accessibility' into issue_2868
PrakashDurlabhji Jul 28, 2019
8b0ac14
issue 2868 patch
PrakashDurlabhji Jul 29, 2019
ae919b6
Merge branch 'qa-accessibility' into issue_2868
PrakashDurlabhji Jul 29, 2019
bdc3028
Merge branch 'qa-accessibility' into issue_2868
PrakashDurlabhji Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/styles/tc-ui.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@
font-family: inherit;
font-weight: inherit;
}

.tc-btn.show-password-btn:focus {
outline: 2px solid $tc-dark-blue-70;
}

.tc-btn.loading:enabled, .tc-btn:focus:not(:disabled) {
background: $tc-white;
Expand Down Expand Up @@ -356,4 +360,4 @@
font-size: 15px;
line-height: 20px;
}
}
}
5 changes: 4 additions & 1 deletion app/styles/tc/register.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import 'topcoder/tc-includes';
@import "../tc-ui-variables";
@import '../tc-ui-variables.scss';

.register-container {
a {
Expand All @@ -14,6 +14,9 @@
button {
margin-top: 0;
background-color: $tc-dark-blue-90;
&:focus {
outline: 3px solid $tc-dark-blue-70;
}
&.disabled {
background-color: $tc-gray-60 !important;
color: $tc-white-cream;
Expand Down
2 changes: 1 addition & 1 deletion app/views/directives/toggle-password-with-tips.directive.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
class="input input-btn {{ vm.hasPasswordError() ? 'error' : ''}}"
required)

<button type="button" id="toggleInputTypeBtn" class="tc-btn tc-btn-sm" ng-click="vm.toggleInputType()">{{ vm.toggleShowLabel }}</button>
<button type="button" id="toggleInputTypeBtn" tabIndex="0" class="tc-btn tc-btn-sm show-password-btn" ng-click="vm.toggleInputType()">{{ vm.toggleShowLabel }}</button>
4 changes: 2 additions & 2 deletions app/views/tc/register.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@
section.terms
p By clicking "Join" you agree to Topcoder's #[a(href="http://www.topcoder.com/community/how-it-works/terms/", target="_blank") Terms] and #[a(href="http://www.topcoder.com/community/how-it-works/privacy-policy/", target="_blank") Privacy Policy]

button.tc-btn.tc-btn-large(type="submit", tc-busy-button, tc-busy-when="vm.registering", ng-disabled="vm.registerForm.$invalid", ng-show="vm.isValidCountry") Join
button.tc-btn.tc-btn-large.disabled(type="submit", ng-show="!vm.isValidCountry", disabled="disabled") Join
button.tc-btn.tc-btn-large(type="submit", tc-busy-button, tc-busy-when="vm.registering", ng-disabled="vm.registerForm.$invalid", ng-show="vm.isValidCountry", tabIndex="0") Join
button.tc-btn.tc-btn-large.disabled(type="submit", ng-show="!vm.isValidCountry", disabled="disabled", tabIndex="0") Join

div(role="region" aria-label="Register With")
section.login-options(ng-if="!vm.ssoUser")
Expand Down