issue 2868 fix

[PrakashDurlabhji]

No description provided.

[nkumar-topcoder]

change PR to appirio-tech:qa-accessibility

[mishacucicea]

@PrakashDurlabhji This applies to the Join button as well. Please make sure the button is highlighted when navigated to (you might need to fix tabindex as well)

[PrakashDurlabhji]

@mishacucicea PR updated

[mishacucicea]

@PrakashDurlabhji Please don't use hardcoded values for colors, they are already present in tc-ui-variables.scss. Reference that file and use variable name.

[PrakashDurlabhji]

@veshu @mishacucicea PR updated. not able to change the label else it is completed.

[mishacucicea]

@PrakashDurlabhji Your code is not compiling, you need to reference tc-ui-variables.scss

Please make sure you thoroughly check your PRs and changes, otherwise we won't accept your submissions and the level of trust in your code will decrease.

[PrakashDurlabhji]

@mishacucicea chcking

[PrakashDurlabhji]

@mishacucicea updated

[mishacucicea]

Undefined variable: "$tc-dark-blue-70". Fix it

[PrakashDurlabhji]

@mishacucicea isnt a PR merged in it which inserted $tc-dark-blue-70, so i used it assuming it will be present in code till my code is reviewed. I guess it is not yet inside yet.

[mishacucicea]

@PrakashDurlabhji You need to make sure that the current branch, (e.g. issue_2868) is working OK, which, at the time being it doesn't. Currently it shows that these are your changes compared to the qa-accessibility branch. Even if the import was added in another place, if it's not on the qa-accessibility branch you need to fix it.
I'm curious how did you tested locally, you do know changes need to be tested before requesting a review, right?

[PrakashDurlabhji]

@mishacucicea PR updated with screenshot on issue page and no compilation error now. kindly provide feedback if anything left will confirm everything with screenshot from nowon

[mishacucicea]

looks good.