Skip to content

[$15][MSFT-204] [Registration] - Join Button and Show Button is not highlighted after hitting the tab button #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veshu opened this issue Jul 17, 2019 · 29 comments

Comments

@veshu
Copy link
Contributor

veshu commented Jul 17, 2019

Steps to Reproduce

  1. Go to https://accounts.topcoder.com/member/registration
  2. Hit Tab key until we reach to Join button below.
  3. Observe the Join and Show Button.

Expected Result
After entering all the fields the Show button and the Join button should be highlighted.

Actual Result
The Show Button and the Join button is not getting highlighted after hitting the tab button.

Device: Desktop/Labtop
Operating System: macOS
Browser: Chrome

WCAG Category: 2. Operable
WCAG Level: A
WCAG Success Criterion: 2.4.3 Focus Order
Screen Reader Used:
Accessibility Audit Tool used: Other

Attachment
https://topcodermsft-my.sharepoint.com/personal/pd-topcoder_topcodermsft_onmicrosoft_com/Documents/Forms/All.aspx?cid=63cedfe6%2D52a5%2D4f33%2D9399%2D00e26b7dd4a2&FolderCTID=0x0120005C598A51049FC14CBA882E1AEE168F51&id=%2Fpersonal%2Fpd%2Dtopcoder%5Ftopcodermsft%5Fonmicrosoft%5Fcom%2FDocuments%2FMSFT%2DTeams%2DQA%2FJune%202019%2F29%20Jun%2FTest%20Results%2FBug%20Videos%20%26%20Log%20Files%2FCreeya%2FBug%20%2D%20JoinShow%20Highlighted

@crazyk07 crazyk07 added the Login label Jul 17, 2019
@mishacucicea mishacucicea changed the title [MSFT-204] [Registration] - Join Button and Show Button is not highlighted after hitting the tab button [$15][MSFT-204] [Registration] - Join Button and Show Button is not highlighted after hitting the tab button Jul 18, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 18, 2019

Contest https://www.topcoder.com/challenges/30096252 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 18, 2019

Contest https://www.topcoder.com/challenges/30096252 has been updated - the new changes has been updated for this ticket.

This is an automated message for lazybaer via Topcoder X

@PrakashDurlabhji PrakashDurlabhji self-assigned this Jul 19, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 19, 2019

Contest https://www.topcoder.com/challenges/30096252 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for lazybaer via Topcoder X

@PrakashDurlabhji
Copy link
Contributor

@mishacucicea
Copy link

@PrakashDurlabhji Please look at the PR comments.

@PrakashDurlabhji
Copy link
Contributor

@mishacucicea PR updated

@veshu @tosha5252

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 24, 2019

Contest https://www.topcoder.com/challenges/30096798 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30096798 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for lazybaer via Topcoder X

@PrakashDurlabhji
Copy link
Contributor

@veshu @mishacucicea PR updated. not able to change the label else it is completed.
topcoder-archive/appirio_tech-accounts-app#248

@nkumar-topcoder
Copy link
Contributor

@mishacucicea #2868, #2775 and #2774 all fix overlap with similar files.

@PrakashDurlabhji
Copy link
Contributor

Kindly note anyone who wishes to assign this to himself that discussion for #2868 and #2774 is going on at #2775 and will be resolved soon.

@lakshmiathreya
Copy link

Verified on MacOS/Chrome & Win10/Chrome - Join and Show are now getting highlighted as expected.
Screenshot 2019-08-05 at 12 06 43 PM

@mishacucicea
Copy link

@nkumar-topcoder I assume you want this retested due to a new merge, right?
cc @lakshmiathreya

@nkumar-topcoder
Copy link
Contributor

@nkumar-topcoder I assume you want this retested due to a new merge, right?
cc @lakshmiathreya

Yes, i merged your latest dev branch fixes which had 2774. And wanted to re-test. Thanks

@PrakashDurlabhji
Copy link
Contributor

@mishacucicea this issue was already solved by my PR you can verify for this at topcoder-archive/appirio_tech-accounts-app#248 which has code for highlight button by adding focus as stated in original issue

just #2775 was remaining and solved by rohit PR.

also #2774 was solved by my PR itself.

just all 3 issues were to be tested together hence was waiting on #2868 and #2774 till #2775 completed as per feedback.
and remaining part of #2775 was completed by rohit, so #2868 and #2774 has no much relation with it.

@tosha5252
Copy link

This is tested and working

Windows 10 env
Browser: Chrome

@tosha5252
Copy link

Tested and working

Windows 10 env
Browser: Chrome

@crazyk07 crazyk07 added tcx_Paid and removed Accessibility P0 Critical (resolve within 4 hours) QA Pass in PROD Passed verification on Production Registration login labels Aug 8, 2019
@crazyk07
Copy link

crazyk07 commented Aug 8, 2019

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30096798

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests