Issue #1497 - Dropdown menu doesn't take viewport bounds into consideration. #1523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nds into consideration. Quick solution always dropdown “upside” if click in the bottom half of the window.
vikasrohit
reviewed
Dec 23, 2017
|
|
||
| const hocStatusDropdown = (CompositeComponent) => { | ||
| class StatusDropdown extends Component { | ||
| shouldDropdownUp() { |
There was a problem hiding this comment.
@maxceem I know it is late as changes are already merged. However, is it possible to move this logic, of showing dropdown up or down, can be moved to the generic dropdown component or its HOC? That way all dropdowns would get benefit from it.
fyi @vic-topcoder
Collaborator
Author
|
Sorry @vikasrohit I'm not sure I'll have time untill 2nd January for this.
That was done just to make quick fix for release.
Currently there are three implementations in use: from react-components,
Dropdown component inside connect-app, and some simple inline
implementations, like in this case.
I believe the best way to go with dropdowns further is to use some existent
implementation for all dropdowns cases. There are usually a lot of edge
cases with custom UI components like Dropdown. Also we can get support for
mobile devices, keyboard control and accessibility if we incorporate some
existent solution with long history and active development.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1497 - Dropdown menu doesn't take viewport bounds into consideration.
Quick solution: always dropdown “upside” if click in the bottom half of the window.