Skip to content

Issue #1497 - Dropdown menu doesn't take viewport bounds into consideration. #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vic-georgiev merged 2 commits into from
Dec 22, 2017
Merged

Issue #1497 - Dropdown menu doesn't take viewport bounds into consideration. #1523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52dc553
Issue #1497 - Dropdown menu doesn't take viewport bounds into conside…
maxceem Dec 22, 2017
433b29e
fix lint issue
maxceem Dec 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/ProjectStatus/ProjectStatus.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,11 @@ $status-height: 20px;
z-index: 2;
transition: 250ms all;

&.dropdown-up {
top: auto;
bottom: 0;
}

.status-header {
@include roboto-medium;
font-size: $tc-label-md;
Expand Down
104 changes: 63 additions & 41 deletions src/components/ProjectStatus/editableProjectStatus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,68 @@ import {
PROJECT_STATUS_CANCELLED
} from '../../config/constants'

const hocStatusDropdown = (CompositeComponent) => {
class StatusDropdown extends Component {
shouldDropdownUp() {
Copy link

@vikasrohit vikasrohit Dec 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxceem I know it is late as changes are already merged. However, is it possible to move this logic, of showing dropdown up or down, can be moved to the generic dropdown component or its HOC? That way all dropdowns would get benefit from it.
fyi @vic-topcoder

if (this.refs.dropdown) {
const bounds = this.refs.dropdown.getBoundingClientRect()
const windowHeight = window.innerHeight

return bounds.top > windowHeight / 2
}

return false
}

render() {
const { canEdit, isOpen, handleClick, onItemSelect, showText, withoutLabel, unifiedHeader, status } = this.props
const selected = PROJECT_STATUS.filter((opt) => opt.value === status)[0]

this.shouldDropdownUp()
return (
<div className="project-status-dropdown" ref="dropdown">
<div
className={cn('status-header', 'ps-' + selected.value, { active: isOpen, editable: canEdit })}
onClick={handleClick}
>
<CompositeComponent
status={selected}
showText={showText}
withoutLabel={withoutLabel}
unifiedHeader={unifiedHeader}
/>
{ canEdit && <i className="caret" ><SVGIconImage filePath="arrow-9px-carret-down-normal" /></i> }
</div>
{ isOpen && canEdit &&
<div className={cn('status-dropdown', { 'dropdown-up': this.shouldDropdownUp() })}>
<div className="status-header">Project Status</div>
<ul>
{
PROJECT_STATUS.map((item) =>
<li key={item.value}>
<a
href="javascript:"
className={cn('status-option', 'ps-' + item.value, { active: item.value === status })}
onClick={(e) => {
onItemSelect(item.value, e)
}}
>
<ProjectStatus status={item} showText />
</a>
</li>
)
}
</ul>
</div>
}
</div>
)
}
}

return StatusDropdown
}

const editableProjectStatus = (CompositeComponent) => class extends Component {
constructor(props) {
super(props)
Expand Down Expand Up @@ -56,50 +118,10 @@ const editableProjectStatus = (CompositeComponent) => class extends Component {
this.setState({ statusChangeReason : _.get(reason, 'value') })
}

renderDropdown(props) {
const { canEdit, isOpen, handleClick, onItemSelect, showText, withoutLabel, unifiedHeader, status } = props
const selected = PROJECT_STATUS.filter((opt) => opt.value === status)[0]
return (
<div className="project-status-dropdown">
<div className={cn('status-header', 'ps-' + selected.value, { active: isOpen, editable: canEdit })} onClick={handleClick}>
<CompositeComponent
status={selected}
showText={showText}
withoutLabel={withoutLabel}
unifiedHeader={unifiedHeader}
/>
{ canEdit && <i className="caret" ><SVGIconImage filePath="arrow-9px-carret-down-normal" /></i> }
</div>
{ isOpen && canEdit &&
<div className="status-dropdown">
<div className="status-header">Project Status</div>
<ul>
{
PROJECT_STATUS.map((item) =>
<li key={item.value}>
<a
href="javascript:"
className={cn('status-option', 'ps-' + item.value, { active: item.value === status })}
onClick={(e) => {
onItemSelect(item.value, e)
}}
>
<ProjectStatus status={item} showText />
</a>
</li>
)
}
</ul>
</div>
}
</div>
)
}

render() {
const { showStatusChangeDialog, newStatus, statusChangeReason } = this.state
const { canEdit } = this.props
const ProjectStatusDropdown = canEdit ? enhanceDropdown(this.renderDropdown) : this.renderDropdown
const ProjectStatusDropdown = canEdit ? enhanceDropdown(hocStatusDropdown(CompositeComponent)) : hocStatusDropdown(CompositeComponent)
return (
<div className={cn('panel', 'EditableProjectStatus', {'modal-active': showStatusChangeDialog})}>
<div className="modal-overlay"></div>
Expand Down