bug #3273 Show Created By for files and links list in Assets Library

[jacky-zhangjb]

No description provided.

[maxceem]

@jankyzhang there is some issue with the Member Service. It's not connected with your PR, but I cannot test it properly. So I'm waiting for the member service to come back live.

[maxceem]

Finally could review your PR @jankyzhang.

Generally works good. There are few moments to improve.

1. Tooltips look broken. See tooltip on Assets Library page:

   

   And this is how tooltips look like in other places, including Project Listing page:

   

2. You did some extra work to implement a new action to load information about user members. Though it also bring some disadvantage. We should use existent action loadMembers as we use it on the project listing page and we use it in many other places when we load user information. This is better because we don't have to re-load information for the same users several times as action loadMembers stores all loaded users in one place.

[jacky-zhangjb]

@maxceem
Sorry for the delay reply.
I miss the E-mail notification.
I check it right now.

[jacky-zhangjb]

@maxceem,
I have fix two issues now.
Please check the code.

About the issue 2:
In the 'AssetsInfoContainer.jsx' . the 'props.projectMembers' is accroding of the state 'members.members' ,which get from the existent action 'loadMembers'.
If we use the action 'loadMembers' again for 'assetsMembers'.
The 'props.projectMembers' may be changed.
So I implement a new action to load information about user members at first.

[maxceem]

Thanks for the update @jankyzhang. Both issues are fixed now. Just noticed one performance issue. Please, have a look on the comment below.

[jacky-zhangjb]

@maxceem ,
Thanks for the reply.
Now the Service is fail.
I will check and fix the issue today later.

[jacky-zhangjb]

@maxceem

Website try to get the user-info about '305384'.
However, just a blank content return.
So the code request to the server again and again, due to the missUserId '305384'.

How we should do about this ?

[maxceem]

Website try to get the user-info about '305384'.
However, just a blank content return.
So the code request to the server again and again, due to the missUserId '305384'.

How we should do about this ?

We should request users only once. If, like in this situation we didn't get info about some user, we can show Unknown as you do now. Note, that you can check how we do on Project Listing page. After loading the list of projects, we request all the users once. If we cannot get some, we don't show them or show unknown.
So your approach is good, just have to request users one time only.

[jacky-zhangjb]

@maxceem ,
I just update the code.
Please check it.
Thanks.

[maxceem]

Thanks @jankyzhang. All works great.