Skip to content

Checkpoint Review Notification #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Mar 16, 2020 · 14 comments
Closed

Checkpoint Review Notification #4114

SathyaJayabal opened this issue Mar 16, 2020 · 14 comments

Comments

@SathyaJayabal
Copy link
Collaborator

To track discussions
https://topcoder.slack.com/archives/CG2J9RH70/p1584083663037900

For Design:

  1. Event- Checkpoint screening starts
    Message- "Checkpoint screening phase is now open. You may now begin screening checkpoint submissions."
    Target audience- screeners for that particular design challenge
  2. Event- Checkpoint Review starts
    Message- "Checkpoint Review is now open. You may now begin reviewing checkpoint submissions
    Target audience- reviewers for that particular design challenge.

cc @Oanh-and-only-Oanh @sachin-maheshwari @luizrrodrigues

@luizrrodrigues
Copy link
Collaborator

@sachin-maheshwari Let me know when this one is ready in backend.

@sachin-maheshwari
Copy link

@Oanh-and-only-Oanh @luizrrodrigues @SathyaJayabal #1, here "target audience" is not clear to me, please explain with example. And that is for "Design challenge" only ? what about other challenges ?
As I checked for Live Design Challenge https://www.topcoder.com/challenges/30119422 , corresponding backend api - v4/challenges/30119422/resources is giving only one "Primary Screener" i.e. "leben" . So only "leben" will be notified in this case. correct ?
And #2, above api giving only one "Specification Reviewer" i.e. "fajar.min". correct ?

@SathyaJayabal
Copy link
Collaborator Author

@Dara-K @Oanh-and-only-Oanh , I think checkpoint review phase is only applicable for design contests. Other challenges will not have this notification. Am I correct?

@Dara-K , Do design challenges have a reviewer role or is it done by the copilot (actual review by the client) ?

cc @sachin-maheshwari

@Oanh-and-only-Oanh
Copy link

@SathyaJayabal. checkpoint review phrase only applicable for design.

@Dara-K
Copy link

Dara-K commented Mar 16, 2020

@SathyaJayabal Yes, the reviewer is the copilot for design challenges who acts in the name of the customer.

@SathyaJayabal
Copy link
Collaborator Author

@sachin-maheshwari , to summarise

When checkpoint screening starts, "Checkpoint screening phase is now open. You may now begin screening checkpoint submissions." to Primary Screener

When checkpoint review starts, ""Checkpoint Review is now open. You may now begin reviewing checkpoint submissions." to the Copilot.

cc @Oanh-and-only-Oanh @Dara-K

@SathyaJayabal
Copy link
Collaborator Author

cc @luizrrodrigues

@SathyaJayabal
Copy link
Collaborator Author

verified on test env
Screenshot 2020-03-18 at 5 19 26 PM

@SathyaJayabal
Copy link
Collaborator Author

@Oanh-and-only-Oanh @Dara-K @sachin-maheshwari @sushilshinde
On testing in beta, it became clear that the checkpoint screening is done by the "Checkpoint Screener" role and not "Primary Screener" as perviously mentioned.

We need to update the code to reflect this. The Checkpoint Screener must get the Checkpoint Screening Start notification.

@SathyaJayabal SathyaJayabal added Beta Env Environment QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Test Env Environment labels Mar 26, 2020
@SathyaJayabal
Copy link
Collaborator Author

@Oanh-and-only-Oanh @sachin-maheshwari @sushilshinde
Checkpoint screening start notification was not received.
On looking into it, the event for checkpoint screening start was not published by OR.
Other events like checkpoint screening end, checkpoint review start etc were published. I have contacted support to help with resetting the contest phases so that we can try testing again.

The checkpoint review start notification was received by the copilot.
Screenshot 2020-03-26 at 6 53 27 PM

@SathyaJayabal
Copy link
Collaborator Author

@Oanh-and-only-Oanh @sachin-maheshwari @sushilshinde , checkpoint screening notification was also received when testing today
Topcoder Challenges 2020-03-27 11-42-24

@SathyaJayabal
Copy link
Collaborator Author

@Oanh-and-only-Oanh @Dara-K @sachin-maheshwari @sushilshinde
On testing in beta, it became clear that the checkpoint screening is done by the "Checkpoint Screener" role and not "Primary Screener" as perviously mentioned.

We need to update the code to reflect this. The Checkpoint Screener must get the Checkpoint Screening Start notification.

This issue will be tracked in #4146

@SathyaJayabal SathyaJayabal removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Mar 30, 2020
@SathyaJayabal SathyaJayabal added this to the v0.27.0 milestone Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on beta (develop branch)
Screenshot 2020-03-30 at 1 55 57 PM
Topcoder Challenges 2020-03-30 13-58-07

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator Author

Verified on prod.
Screenshot 2020-03-30 at 5 53 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants