Skip to content

Notifications dropdown backend integration #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oanh-and-only-Oanh opened this issue Mar 3, 2020 · 23 comments
Closed

Notifications dropdown backend integration #4055

Oanh-and-only-Oanh opened this issue Mar 3, 2020 · 23 comments

Comments

@Oanh-and-only-Oanh
Copy link

Change existing mock call to the integration with backend
Challenge link: https://www.topcoder.com/challenges/30117693/?type=develop

@SathyaJayabal
Copy link
Collaborator

@sachin-maheshwari @luizrrodrigues , broadcast notifications are not seen for some users.
eg: TonyJ, Mess, tester1234 etc
We can see broadcast notifications for the following user : dan_developer

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Mar 11, 2020

@sachin-maheshwari @luizrrodrigues , for challenge specific notifications, the users do not get the notification when the checkpoint review ends.

@SathyaJayabal
Copy link
Collaborator

@sachin-maheshwari @luizrrodrigues , When the challenge spec for the challenge"30055753" is modified, we can observe the following. this is the registrants list:
Screenshot 2020-03-11 at 5 06 55 PM

No notification for dan_developer
Screenshot 2020-03-11 at 5 08 05 PM

Double notification for TonyJ
Screenshot 2020-03-11 at 5 08 25 PM
Correct notification for Mess
Screenshot 2020-03-11 at 5 09 53 PM

@sachin-maheshwari
Copy link

@sachin-maheshwari @luizrrodrigues , When the challenge spec for the challenge"30055753" is modified, we can observe the following. this is the registrants list:
Screenshot 2020-03-11 at 5 06 55 PM

No notification for dan_developer
Screenshot 2020-03-11 at 5 08 05 PM

Double notification for TonyJ
Screenshot 2020-03-11 at 5 08 25 PM
Correct notification for Mess
Screenshot 2020-03-11 at 5 09 53 PM

As checked quickly for dan_developer, no notification issue - not getting 'dan_devloper' in corresponding challenge api call i.e. https://api.topcoder-dev.com/v4/challenges/30055753/resources

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Mar 11, 2020

Double notification for TonyJ
@SathyaJayabal this coming from backend:

image

@sachin-maheshwari

@luizrrodrigues
Copy link
Collaborator

@sachin-maheshwari @luizrrodrigues , broadcast notifications are not seen for some users.
eg: TonyJ, Mess, tester1234 etc
We can see broadcast notifications for the following user : dan_developer

I'm able to see to TonyJ user, can you share login info to:
Mess and tester1234

Thanks

@luizrrodrigues
Copy link
Collaborator

For challenge specific notifications, the users do not get the notification when the checkpoint review ends.

@sachin-maheshwari I don't see any notification from notifications.autopilot.events yet. Is this the right type to challenge autopilot events right?

@SathyaJayabal
Copy link
Collaborator

@sachin-maheshwari @luizrrodrigues , broadcast notifications are not seen for some users.
eg: TonyJ, Mess, tester1234 etc
We can see broadcast notifications for the following user : dan_developer

I'm able to see to TonyJ user, can you share login info to:
Mess and tester1234

Thanks

password for both: appirio123

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , we had to remove the notifications for submission uploaded event as per. the below discussion.
https://topcoder.slack.com/archives/CG2J9RH70/p1583878405014700?thread_ts=1583858564.012400&cid=CG2J9RH70

On a submission being uploaded, the notification is not displayed, but the pink dot is shown when a submission is uploaded.
Screenshot 2020-03-12 at 9 31 15 AM

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Mar 12, 2020

@SathyaJayabal Thanks for check. This was fixed.
topcoder-platform/navigation-component@af2c926

@SathyaJayabal
Copy link
Collaborator

@SathyaJayabal Thanks for check. This was fixed.
topcoder-platform/navigation-component@af2c926

Still see it @luizrrodrigues . See video for reference
sub notif.mov.zip

@sachin-maheshwari @luizrrodrigues , Marking this as fail until all the above issues are fixed. But let me know if you need any specific scenario tested.

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Mar 12, 2020
@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal I have fixed the issue when msg isRead but no isSeen.

Now we need backend update, @sachin-maheshwari we need to remove submission.notification.create type from backend return.

@sachin-maheshwari
Copy link

Double notification for TonyJ
@SathyaJayabal this coming from backend:

image

@sachin-maheshwari

Please check message is same but 'id' is different that mean same message is published twice.

@sachin-maheshwari
Copy link

@SathyaJayabal Can please summarize the issues which i need to address.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Mar 13, 2020

@sachin-maheshwari ,

  1. Broadcast notifications not showing up for some users
    eg: TonyJ, Mess, tester1234 etc
    We can see broadcast notifications for the following user : dan_developer
  2. Checkpoint review end notification is not displayed for all users.
  3. Challenge spec modified notification is displaying inconsistently for different users ( Notifications dropdown backend integration #4055 (comment))
    a. No notification for dan_developer - Here you say dan_developer is not returned from the corresponding challenge api call, But the user is shown as registered and also submitted for that challenge. This could be a data integrity issue with the dev data. What do you suggest we do about this case?
    b. double notification for tonyj

@SathyaJayabal
Copy link
Collaborator

3: a is tracked here #4104
3: b. is tracked here #4105

@sachin-maheshwari
Copy link

1 is tracked here topcoder-platform/tc-notifications#182

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal create this one too:

Now we need backend update, @sachin-maheshwari we need to remove submission.notification.create type from backend return.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Mar 13, 2020

@SathyaJayabal create this one too:

Now we need backend update, @sachin-maheshwari we need to remove submission.notification.create type from backend return.

tracked here #4108
cc @luizrrodrigues

@SathyaJayabal
Copy link
Collaborator

#2 tracked here #4114

@luizrrodrigues luizrrodrigues added Ready for QA and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Mar 21, 2020
@SathyaJayabal
Copy link
Collaborator

#4104
except for this issue everything else works fine.
I am marking this as pass.

@SathyaJayabal
Copy link
Collaborator

verified on beta (develop).
Broadcast notifications
Checkpoint review and Checkpoint Screening notifications

Spec modified notification is deferred to release 2.

@SathyaJayabal SathyaJayabal added Beta Env Environment Prod Env Environment and removed Test Env Environment Beta Env Environment labels Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-03-30 at 5 53 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants