Skip to content

Notification Backend Integration: Remove submission.notification.create type from backend return #4108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Mar 13, 2020 · 4 comments
Closed

Notification Backend Integration: Remove submission.notification.create type from backend return #4108

SathyaJayabal opened this issue Mar 13, 2020 · 4 comments
Assignees
@sachin-maheshwari
Labels
New feature Notifications Prod Env Environment QA Pass
Milestone
v0.27.0

Comments

@SathyaJayabal
Copy link
Collaborator

We need to remove submission.notification.create type from backend return as we not longer display submission uploaded notifications.
@SathyaJayabal SathyaJayabal mentioned this issue Mar 13, 2020
Closed
sachin-maheshwari pushed a commit to topcoder-platform/tc-notifications that referenced this issue Mar 16, 2020
as per request at git-issue topcoder-platform/community-app#4108, dis…
ae649d2 
…abling events 'A new submission is uploaded'
@SathyaJayabal
Copy link
Collaborator Author

verified on dev

@SathyaJayabal SathyaJayabal mentioned this issue Mar 18, 2020
Merged
@luizrrodrigues luizrrodrigues mentioned this issue Mar 26, 2020
Closed
@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Mar 27, 2020 •
edited
Loading

#3337 (comment)

@sachin-maheshwari , we need to remove the older submission uploaded notifications from the backend. even though they are not displayed on the front end, it causes the bell icon to be highlighted and shows an empty notifications popup.
image (1)

@SathyaJayabal SathyaJayabal added Beta Env Environment and removed Dev Env labels Mar 27, 2020
@SathyaJayabal SathyaJayabal mentioned this issue Mar 30, 2020
Closed
@SathyaJayabal SathyaJayabal added this to the v0.27.0 milestone Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Mar 30, 2020 •
edited
Loading

New notifications on submission upload are not created. But the above issue exists
#4108 (comment).
tracked here #4150

@SathyaJayabal SathyaJayabal added Beta Env Environment QA Pass and removed Beta Env Environment QA Pass labels Mar 30, 2020
@SathyaJayabal SathyaJayabal mentioned this issue Mar 30, 2020
Open
@SathyaJayabal
Copy link
Collaborator Author

verified on prod.

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sachin-maheshwari sachin-maheshwari

Labels
New feature Notifications Prod Env Environment QA Pass
Projects
None yet
Milestone
v0.27.0
Development

No branches or pull requests
2 participants
@sachin-maheshwari @SathyaJayabal