Skip to content

Default menu for the pages that doesnt exists in menu #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nithyaasworld opened this issue Jun 25, 2019 · 19 comments
Closed

Default menu for the pages that doesnt exists in menu #41

nithyaasworld opened this issue Jun 25, 2019 · 19 comments
Assignees
Labels
P1 Urgent (resolve within 24 hours) Prod Env Environment QA Pass

Comments

@nithyaasworld
Copy link
Collaborator

There are some pages that doesn't exist in the Navigation menu.

Examples:

  1. Any member profile page other than the own profile Ex: /members/TonyJ being logged in as mess
  2. Challenge details page
  3. User menu --> Settings

Expected Behaviour: When such pages are accessed, we should just show the Community menu expanded with no selection indicator.

@nithyaasworld
Copy link
Collaborator Author

Tips to fix this is provided here by @ya3ya6 topcoder-platform/community-app#2663 (comment)

@luizrrodrigues
Copy link
Collaborator

@nithyaasworld Please let me know if this is what expected to Settings and Challenge Details page.
(Ignore menu animation/refresh for now)
Screen Recording 2019-06-25 at 20.12.18.mov.zip

@luizrrodrigues luizrrodrigues transferred this issue from topcoder-platform/community-app Jun 25, 2019
@luizrrodrigues luizrrodrigues added the P1 Urgent (resolve within 24 hours) label Jun 25, 2019
@nithyaasworld
Copy link
Collaborator Author

@luizrrodrigues At 25th second, can you please remove the selection indicator that is present under the Community?

If the page is not in the menu items, lets not show any selection indicator for any of the menu items.

Thanks.

@luizrrodrigues
Copy link
Collaborator

@nithyaasworld You sure about that?
We showing Dashboard, My Profile and Payments in secondary menu, so I think Community need be selected.
Please confirm

@nithyaasworld
Copy link
Collaborator Author

Yes @luizrrodrigues

At 25th second of the video, you are in User menu -> Settings page. This screen is not part of the community menu (Dashboard or My Profile or Payments).

So its more appropriate if we do not display any selection indicator for such pages which are not present in the menus.

@luizrrodrigues
Copy link
Collaborator

@nithyaasworld So need remove indicator and secondary menu too, right?

@nithyaasworld
Copy link
Collaborator Author

Yes, right @luizrrodrigues

luizrrodrigues added a commit that referenced this issue Jul 9, 2019
@nithyaasworld
Copy link
Collaborator Author

Thanks @luizrrodrigues

But the selection indicator is not shown if I click on any other first level menus being in one of the screens that doesn't exist in menu.

image

@luizrrodrigues
Copy link
Collaborator

@nithyaasworld I think we can close this one.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Dec 16, 2019

@luizrrodrigues I dont see the fix.

The selection indicators are still not shown for some pages.
Screenshot 2019-12-16 at 6 21 43 PM

While they appear for some pages.
Screenshot 2019-12-16 at 5 59 08 PM

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Okay, I see now.
We talking about arrow indicator.

@lakshmiathreya
Copy link

cc @lakshmiathreya @nithyaasworld

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal I thing we can pass this one, because the another issue reported here will follow up here: #62

Right?

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Dec 17, 2019

Ok, I will add this example to #62. Marking this as QA Pass, since the original issue is fixed. The selection indicator issue will be handles by #62

@SathyaJayabal SathyaJayabal added this to the New Navigation Launch milestone Dec 17, 2019
@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Dec 19, 2019
@SathyaJayabal
Copy link
Collaborator

Verified in production
Screenshot 2019-12-19 at 8 28 26 PM

@SathyaJayabal
Copy link
Collaborator

@bug-hunt-helper help

2 similar comments
@SathyaJayabal
Copy link
Collaborator

@bug-hunt-helper help

@SathyaJayabal
Copy link
Collaborator

@bug-hunt-helper help

@bug-bash-helper
Copy link

Hi @SathyaJayabal.

add label

To add label to the issue, add comment like below with comma-separated list of labels:

@bug-hunt-helper add label: Label Name 1, Label Name 2, Label Name 3

remove label

To remove label from the issue, add comment like below with comma-separated list of labels:

@bug-hunt-helper remove label: Label Name 1, Label Name 2, Label Name 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Urgent (resolve within 24 hours) Prod Env Environment QA Pass
Projects
None yet
Development

No branches or pull requests

4 participants