Skip to content

$25 | Selection indicator is not displayed in some cases #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Dec 16, 2019 · 33 comments
Closed

$25 | Selection indicator is not displayed in some cases #62

SathyaJayabal opened this issue Dec 16, 2019 · 33 comments
Assignees
Labels

Comments

@SathyaJayabal
Copy link
Collaborator

  1. Click on Community -> Dashboard or My Profile, selection indicator disappears.
    This also happens when the user is logged out and you click on Community -> Overview or How it Works
@SathyaJayabal SathyaJayabal added the P3 Normal (resolved within 7 days) label Dec 16, 2019
@SathyaJayabal
Copy link
Collaborator Author

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues,The selection indicator is also not present when the user navigates to some pages that are not on the menu.

examples:
Screenshot 2019-12-17 at 11 20 42 AM
Screenshot 2019-12-17 at 11 21 22 AM

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , one more example of the selection indicator not displayed properly

On a tab size window, when you click on more->explore->programs, the selection indicator moves from more to Community
cc @nithyaasworld
selection indicator 62.mov.zip

@luizrrodrigues luizrrodrigues removed their assignment Jan 9, 2020
@luizrrodrigues luizrrodrigues changed the title Selection indicator is not displayed in some cases $25 | Selection indicator is not displayed in some cases Jan 9, 2020
@LieutenantRoger LieutenantRoger self-assigned this Jan 9, 2020
@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Any status on this one?

@LieutenantRoger
Copy link
Contributor

Hi @luizrrodrigues

Working on this ticket. Will submit Asap.

@LieutenantRoger
Copy link
Contributor

Hi @luizrrodrigues

Do you know how to resolve this issue ? I only checked out the code and try to launch the community app, it used to be launchable, but I received the error like this now.

https://take.ms/WGDkv

@luizrrodrigues
Copy link
Collaborator

What steps you followed to deploy and run app? Also you set the env vars shared in forum?

@LieutenantRoger
Copy link
Contributor

Never mind, I have managed to launch the necessary page. The error I posted above appears some data incomplete in the dev env.

@luizrrodrigues
Copy link
Collaborator

You can run locally with Prod env data (is always better to me when test in my local)

@LieutenantRoger
Copy link
Contributor

Can you take a look like this ? I tried use npm start to launch it in production mode, but the page seemed not able to launch ; https://take.ms/rb5VY

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger try set port:
export PORT=80

@LieutenantRoger
Copy link
Contributor

The data seemed not load still. I can visit TonyJ in dev but not in prod environment: https://take.ms/AL6fm

@LieutenantRoger
Copy link
Contributor

And in dev mode, both the my profile page and dash-board page won't load, I seemed stuck on verifying my solution

@LieutenantRoger
Copy link
Contributor

https://take.ms/65T7f

@luizrrodrigues
Copy link
Collaborator

Use these step to deploy / start:

npm install
npm run build
npm start

And make sure to use node v8.16.0

@LieutenantRoger
Copy link
Contributor

Thanks, turns out I need to rebuild it. Here' the MR: #85

@LieutenantRoger
Copy link
Contributor

I assume we can ignore the CI error ? as I didn't find a .circleci file, so not sure navigation-component should run though the CI after we made a commit.

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Yep, ignore this for now.

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Please create a new MR.

@LieutenantRoger
Copy link
Contributor

Ok, here it is: #145

I thought I have pushed the fix, looks the MR need to be re-created.

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Yes, because old MR was merged. :)
Thanks.

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Not working well:

Missing arrow:
image

Screen Recording 2020-01-25 at 00.38.16.mov.zip

Showing arrow (need don't show here):
image

@LieutenantRoger
Copy link
Contributor

LieutenantRoger commented Jan 25, 2020

@luizrrodrigues

Could you please rephrase the requirement ? I'm more confusing than before.
Based on what rule, the choosing arrow should display, thanks.

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Based in your solution I have fixed the issue (just changed the right variables to show hide Arrow)

1db2f1d

Thanks.

@LieutenantRoger
Copy link
Contributor

Great, thanks.

@SathyaJayabal
Copy link
Collaborator Author

This issue still exists.
#62 (comment)
But I will tag it with #101 as it seems related.

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal I think original issue was fixed here, if remain issue is related with "More" button, let close this one and track in #101

@SathyaJayabal
Copy link
Collaborator Author

Yes, I am just going to mark this as pass after I have linked the issue

@macs054
Copy link
Collaborator

macs054 commented Feb 27, 2020

Verified in Beta
image
image

@macs054 macs054 added Beta Env Environment and removed Test Env Environment labels Feb 27, 2020
@SathyaJayabal SathyaJayabal added this to the Community App 0.21.01 milestone Feb 27, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on prod
Screenshot 2020-02-28 at 8 44 40 AM

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants