Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic font interface + sample (#192) #200

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

marekmaskarinec
Copy link
Member

No description provided.

@marekmaskarinec marekmaskarinec requested a review from skejeton July 14, 2024 20:15
@vtereshkov
Copy link
Contributor

@marekmaskarinec Is canvas::drawText() removed?

@marekmaskarinec
Copy link
Member Author

No, the old api stays for those who want to use it. But now there is also the canvas::pixelFont built over it.

umka/canvas.um Outdated Show resolved Hide resolved
umka/font.um Outdated Show resolved Hide resolved
umka/font.um Outdated Show resolved Hide resolved
Copy link
Member

@skejeton skejeton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only minor nitpicks like in documentation and naming. I'm going to test it on SaveScum.

umka/canvas.um Outdated Show resolved Hide resolved
@skejeton
Copy link
Member

Works with no issues.

skejeton added a commit to skejeton/savescum that referenced this pull request Jul 14, 2024
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
@marekmaskarinec
Copy link
Member Author

@skejeton I have incorporated your suggestions. Are we ok to merge now?

@skejeton skejeton merged commit 53ab81b into main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants