Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager.sh: check vbmeta device by getprop #7216

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

@topjohnwu topjohnwu merged commit 4000369 into topjohnwu:master Aug 8, 2023
8 checks passed
@vvb2060 vvb2060 deleted the vbmeta branch August 8, 2023 10:00
@osm0sis
Copy link
Collaborator

osm0sis commented Aug 8, 2023

:/ $ su
:/ # getprop | grep vbmeta
[ro.boot.vbmeta.device_state]: [locked]
[ro.product.ab_ota_partitions]: [abl,aop,bluetooth,boot,cpucp,devcfg,dsp,dtbo,engineering_cdt,featenabler,hyp,imagefv,keymaster,modem,multiimgoem,odm,oplus_sec,oplusstanvbk,product,qupfw,qweslicstore,shrm,splash,system,system_ext,tz,uefisecapp,vbmeta,vbmeta_system,vbmeta_vendor,vendor,vendor_boot,vendor_dlkm,xbl,xbl_config]
[vendor.boot.vbmeta.device_state]: [locked]
:/ #

This is on latest Lineage 20 on OnePlus 9 Pro, which has vbmeta as shown in the ab_ota_partition list, and previously passed the old detection with vbmeta_a. So you might need both prop and path?

@osm0sis
Copy link
Collaborator

osm0sis commented Aug 8, 2023

How about checking ro.product.ab_ota_partitions for ,vbmeta,? Still prop-based and works unrooted.

@Stillhard
Copy link

getprop | grep vbmeta

This is on my A11 stock rom:

Infinix-X695C:/ $ getprop | grep vbmeta
[ro.boot.vbmeta.device_state]: [locked]
[vendor.boot.vbmeta.device_state]: [locked]
Infinix-X695C:/ $ su
Infinix-X695C:/ # getprop | grep vbmeta
[ro.boot.vbmeta.device_state]: [locked]
[vendor.boot.vbmeta.device_state]: [locked]
Infinix-X695C:/ #

Tried this too:

Infinix-X695C:/ $ getprop ro.product.ab_ota_partitions | grep -wq vbmeta
1|Infinix-X695C:/ $

No vbmeta traces

@osm0sis
Copy link
Collaborator

osm0sis commented Aug 9, 2023

getprop | grep vbmeta

This is on my A11 stock rom:

Infinix-X695C:/ $ getprop | grep vbmeta
[ro.boot.vbmeta.device_state]: [locked]
[vendor.boot.vbmeta.device_state]: [locked]
Infinix-X695C:/ $ su
Infinix-X695C:/ # getprop | grep vbmeta
[ro.boot.vbmeta.device_state]: [locked]
[vendor.boot.vbmeta.device_state]: [locked]
Infinix-X695C:/ #

Tried this too:

Infinix-X695C:/ $ getprop ro.product.ab_ota_partitions | grep -wq vbmeta
1|Infinix-X695C:/ $

No vbmeta traces

Hmm, well what's there now, and what will be added with my PR is still better than the broken path check from before.

@osm0sis
Copy link
Collaborator

osm0sis commented Aug 9, 2023

@Stillhard your device definitely has a vbmeta partition? Is it an A/B device or A-only? Can you provide a full unrooted prompt getprop output for your device?

See here: #7220 (comment)

@Stillhard
Copy link

@Stillhard your device definitely has a vbmeta partition? Is it an A/B device or A-only? Can you provide a full unrooted prompt getprop output for your device?

See here: #7220 (comment)

Infinix-X695C:/ $ getprop ro.build.ab_update
true
Infinix-X695C:/ $ getprop > /sdcard/Download/getprop.txt
Infinix-X695C:/ $

getprop.txt

@Stillhard
Copy link

@Stillhard your device definitely has a vbmeta partition?

vbmeta

vbmeta.zip

@osm0sis
Copy link
Collaborator

osm0sis commented Aug 9, 2023

I wonder if first_api_level could be useful to us here. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants