manager.sh: add ro.boot.vbmeta.size + ro.product.ab_ota_partitions to vbmeta check

[osm0sis]

• ro.boot.vbmeta.device doesn't seem to be in use on all devices, so add some alternative props which may be instead

[vvb2060]

Magisk/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt

Line 40 in 0f5963f

val hideVbmeta = Info.vbmeta || Info.isSamsung || Info.isAB

I think we may have forgotten something.

https://android-review.googlesource.com/c/platform/external/avb/+/320888
Looks like ro.boot.vbmeta.device not only exist on a/b devices

[osm0sis]

Hmm yeah, the original non-working path check also had the non-A/B partition name:

[ -e /dev/block/by-name/vbmeta_a ] || [ -e /dev/block/by-name/vbmeta ]

But if there's no A-only equivalent to ro.product.ab_ota_partitions that will tell us vbmeta exists then I'm not sure what else we can do for unrooted checks.

[osm0sis]

My A-only Poco X2 on stock MIUI 12 (Android 11) has a vbmeta partition. Here's what I got there:

:/ $ getprop | grep vbmeta
[ro.boot.vbmeta.avb_version]: [1.0]
[ro.boot.vbmeta.device_state]: [locked]
[ro.boot.vbmeta.digest]: [1e3b40d142d6ab0b644a448d8bbc4e4b0a13d47f0bd592814c5431440bf79bd2]
[ro.boot.vbmeta.hash_alg]: [sha256]
[ro.boot.vbmeta.invalidate_on_error]: [yes]
[ro.boot.vbmeta.size]: [6720]
:/ $

Full getprop output

[osm0sis]

Per my above grep output and https://android.googlesource.com/platform/external/avb/+/88b13e12a0ebe3c5195dbb5f48ba00ec896d1517, size having a value could be another good indicator on an A-only device.

Still not sure what to do about devices like @Stillhard's though: #7216 (comment)

[salvogiangri]

Still not sure what to do about devices like @Stillhard's though: #7216 (comment)

I noticed some differences in Samsung devices as well:

• Galaxy A52s 5G (A-only, Qualcomm, shipped with Android 11):

a52sxq:/ $ getprop | grep vb                                                                                                                              
[ro.boot.avb_version]: [1.1]
[ro.boot.svb.ver]: [SVB1.0]
[ro.boot.vbmeta.device_state]: [locked]
[vendor.boot.vbmeta.device_state]: [locked]

• Galaxy A54 5G (A-only, Exynos, shipped with Android 13):

a54x:/ $ getprop | grep vb
[ro.boot.avb_version]: [1.2]
[ro.boot.svb.ver]: [SVB1.0]
[ro.boot.vbmeta.avb_version]: [1.1]
[ro.boot.vbmeta.device_state]: [locked]
[ro.boot.vbmeta.digest]: [e62daf841bf694f837fb17290e90dc6c62fe7dfba9538e4d3b873584af59fe54]
[ro.boot.vbmeta.hash_alg]: [sha256]
[ro.boot.vbmeta.invalidate_on_error]: [yes]
[ro.boot.vbmeta.size]: [15808]

[vvb2060]

ro.product.ab_ota_partitions must be an a/b device, we have detected a/b device, so it can be deleted.

[osm0sis]

ro.product.ab_ota_partitions must be an a/b device, we have detected a/b device, so it can be deleted.

But do A/B devices always have a vbmeta partition? I don't believe they always did/do, so checking that prop for vbmeta could still be useful to more likely have the info be accurate.

[vvb2060]

Magisk/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt

Line 40 in 0f5963f

val hideVbmeta = Info.vbmeta || Info.isSamsung || Info.isAB

[osm0sis]

Magisk/app/src/main/java/com/topjohnwu/magisk/ui/install/InstallViewModel.kt

Line 40 in 0f5963f

val hideVbmeta = Info.vbmeta || Info.isSamsung || Info.isAB

I didn't mean how it's used in Magisk, I mean in reality, so I still think it's worth leaving so the results of the check are more accurate, for whatever it later gets used for.

[salvogiangri]

I still don't understand if implementing AVB without a vbmeta image is possible and there are devices that do not have it. Also regarding the "Patch vbmeta in boot image" option in the install page: from my understanding, changing the flags in a non-vbmeta image shouldn't be possible (avb_slot_verify.c#801), is it?

[osm0sis]

At least the first generation of A/B devices (e.g. Pixel XL, Essential PH-1, and apparently some ChromeOS devices before that) didn't have a vbmeta partition. Not sure what their prop situation looks like (maybe someone can post output from last stock?)

As for the boot.img vbmeta flags, yeah, Magisk started doing that awhile back; it only has effect on non-vbmeta partition devices, hence the check: f4ed627

[ipdev99]

At least the first generation of A/B devices (e.g. Pixel XL, Essential PH-1, and apparently some ChromeOS devices before that) didn't have a vbmeta partition. Not sure what their prop situation looks like (maybe someone can post output from last stock?)

Dug out my PH-1 (mata) and flashed the last factory build.
(QQ1A.200105.032)

No ro.product.ab_ota_partitions prop.

No separate vbemta partition.
No vbmeta at all?

mata:/ $ getprop | grep vb
1|mata:/ $ getprop | grep ro.product.ab_ota_partitions
1|mata:/ $ 

---

Patched with Magisk f86c66c-ip (26105).

• Magisk did not give the option to patch vbmeta in boot image.

mata:/ $ su
mata:/ # getprop | grep vb
1|mata:/ # getprop | grep ro.product.ab_ota_partitions
1|mata:/ # 

PH1 dev/block/by-name
PH1 getprop
PH1 getprop as root
Magisk install log
Magisk initial boot log

Edit:
It looks like vbmeta was introduced in AVB 2.0 ?
PH-1 appears to be using AVB 1.0.

[osm0sis]

Edit: It looks like vbmeta was introduced in AVB 2.0 ? PH-1 appears to be using AVB 1.0.

Sort of? Check out my Poco X2 output above, avb 1.0 (with vbmeta prop as such), but has A-only vbmeta partition.

[osm0sis]

@vvb2060 I wonder if we could just check if ro.boot.vbmeta.avb_version has a value at all, or if ro.boot.avb_version is > 1.0, they do seem to be the common props on all the vbmeta devices, including @Stillhard's. Just not sure if that's true everywhere.

I think this PR is good to go for now though, until we can figure more of that stuff out.

[Stillhard]

ro.boot.avb_version

Infinix-X695C:/ $ getprop ro.boot.vbmeta.avb_version

Infinix-X695C:/ $ getprop ro.boot.avb_version
1.1
Infinix-X695C:/ $