chore: adding lints to activate over time (#307)

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
topos-protocol · Sep 22, 2023 · 998a681 · 998a681
1 parent 5cf533d
commit 998a681
Show file tree

Hide file tree

Showing 31 changed files with 87 additions and 7 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -5,6 +5,14 @@ members = [
     "crates/*"
 ]
 
+[workspace.lints.rust]
+# Deny
+missing_docs = "allow"
+unused = "allow"
+
+# Warn
+deprecated-in-future = "warn"
+
 [profile.release]
 strip = true
 

diff --git a/crates/topos-api/Cargo.toml b/crates/topos-api/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-api"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [features]
 default = ["grpc"]
 grpc = []

diff --git a/crates/topos-certificate-spammer/Cargo.toml b/crates/topos-certificate-spammer/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-certificate-spammer"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 clap.workspace = true
 tokio-stream.workspace = true

diff --git a/crates/topos-clock/Cargo.toml b/crates/topos-clock/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-clock"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 tokio.workspace = true
 futures.workspace = true

diff --git a/crates/topos-commands/Cargo.toml b/crates/topos-commands/Cargo.toml
@@ -3,5 +3,8 @@ name = "topos-commands"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 async-trait.workspace = true
diff --git a/crates/topos-core/Cargo.toml b/crates/topos-core/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-core"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 topos-uci = { path = "../topos-uci", optional = true }
 topos-api = { path = "../topos-api", optional = true }

diff --git a/crates/topos-crypto/Cargo.toml b/crates/topos-crypto/Cargo.toml
@@ -4,6 +4,9 @@ description = "Implementation of the Topos cryptography utility functions"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 secp256k1.workspace = true
 byteorder.workspace = true

diff --git a/crates/topos-metrics/Cargo.toml b/crates/topos-metrics/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-metrics"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 lazy_static.workspace = true
 prometheus.workspace = true
diff --git a/crates/topos-p2p/Cargo.toml b/crates/topos-p2p/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-p2p"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 async-trait.workspace = true
 bincode.workspace = true

diff --git a/crates/topos-p2p/src/behaviour/transmission/codec.rs b/crates/topos-p2p/src/behaviour/transmission/codec.rs
@@ -1,4 +1,4 @@
-use std::{i8::MAX, io};
+use std::io;
 
 use crate::constant::{SYNCHRONIZER_PROTOCOL, TRANSMISSION_PROTOCOL};
 

diff --git a/crates/topos-sequencer-subnet-client/Cargo.toml b/crates/topos-sequencer-subnet-client/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-sequencer-subnet-client"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 hex.workspace = true
 serde_json.workspace = true

diff --git a/crates/topos-sequencer-subnet-runtime/Cargo.toml b/crates/topos-sequencer-subnet-runtime/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-sequencer-subnet-runtime"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 byteorder.workspace = true
 hex.workspace = true

diff --git a/crates/topos-sequencer/Cargo.toml b/crates/topos-sequencer/Cargo.toml
@@ -4,6 +4,9 @@ description = "Implementation of the Topos protocol"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 hex.workspace = true
 serde = { workspace = true, features = ["derive"] }

diff --git a/crates/topos-tce-api/Cargo.toml b/crates/topos-tce-api/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-tce-api"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 topos-p2p = { path = "../topos-p2p" }
 topos-api = { path = "../topos-api", features = ["graphql"] }

diff --git a/crates/topos-tce-broadcast/Cargo.toml b/crates/topos-tce-broadcast/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-tce-broadcast"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 byteorder.workspace = true
 futures.workspace = true

diff --git a/crates/topos-tce-broadcast/src/tests/mod.rs b/crates/topos-tce-broadcast/src/tests/mod.rs
@@ -4,7 +4,6 @@ use ethers::signers::{LocalWallet, Signer};
 use rstest::*;
 use std::collections::HashSet;
 use std::time::Duration;
-use std::usize;
 use tce_transport::ReliableBroadcastParams;
 use tokio::sync::mpsc::Receiver;
 use topos_test_sdk::constants::*;

diff --git a/crates/topos-tce-gatekeeper/Cargo.toml b/crates/topos-tce-gatekeeper/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-tce-gatekeeper"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 async-trait.workspace = true
 futures.workspace = true

diff --git a/crates/topos-tce-proxy/Cargo.toml b/crates/topos-tce-proxy/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-tce-proxy"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 topos-core = { workspace = true, features = ["uci", "api"] }
 topos-telemetry = { path = "../topos-telemetry" }

diff --git a/crates/topos-tce-storage/Cargo.toml b/crates/topos-tce-storage/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-tce-storage"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 topos-core = { workspace = true, features = ["uci", "api"] }
 topos-commands = { path = "../topos-commands/" }

diff --git a/crates/topos-tce-synchronizer/Cargo.toml b/crates/topos-tce-synchronizer/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-tce-synchronizer"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 futures.workspace = true
 thiserror.workspace = true

diff --git a/crates/topos-tce-transport/Cargo.toml b/crates/topos-tce-transport/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-tce-transport"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [lib]
 path = 'src/lib.rs'
 

diff --git a/crates/topos-tce/Cargo.toml b/crates/topos-tce/Cargo.toml
@@ -5,6 +5,9 @@ version = "0.1.0"
 edition = "2021"
 rust-version = "1.65"
 
+[lints]
+workspace = true
+
 [dependencies]
 async-trait.workspace = true
 bincode.workspace = true

diff --git a/crates/topos-telemetry/Cargo.toml b/crates/topos-telemetry/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-telemetry"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 opentelemetry.workspace = true
 tracing-opentelemetry.workspace = true

diff --git a/crates/topos-test-sdk/Cargo.toml b/crates/topos-test-sdk/Cargo.toml
@@ -4,6 +4,9 @@ version = "0.1.0"
 edition = "2021"
 build = "build.rs"
 
+[lints]
+workspace = true
+
 [dependencies]
 topos-core = { workspace = true, features = ["uci"] }
 topos-p2p = { path = "../topos-p2p/" }

diff --git a/crates/topos-test-sdk/proc_macro_sdk/Cargo.toml b/crates/topos-test-sdk/proc_macro_sdk/Cargo.toml
@@ -3,6 +3,9 @@ name = "proc_macro_sdk"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [lib]
 proc-macro = true
 

diff --git a/crates/topos-uci/Cargo.toml b/crates/topos-uci/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos-uci"
 version = "0.1.1"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 topos-crypto.workspace = true
 ethereum-types.workspace = true

diff --git a/crates/topos-uci/src/lib.rs b/crates/topos-uci/src/lib.rs
@@ -2,8 +2,6 @@
 //!
 //! Data structures to support Certificates' exchange
 
-extern crate core;
-
 pub use certificate::Certificate;
 pub use certificate_id::CertificateId;
 pub use subnet_id::SubnetId;

diff --git a/crates/topos-wallet/Cargo.toml b/crates/topos-wallet/Cargo.toml
@@ -4,6 +4,9 @@ description = "Key manager"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 secp256k1.workspace = true
 byteorder.workspace = true

diff --git a/crates/topos/Cargo.toml b/crates/topos/Cargo.toml
@@ -3,6 +3,9 @@ name = "topos"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 topos-tce = { path = "../topos-tce/", optional = true }
 topos-p2p = { path = "../topos-p2p" }

diff --git a/crates/topos/src/tracing.rs b/crates/topos/src/tracing.rs
@@ -16,7 +16,7 @@ fn verbose_to_level(verbose: u8) -> Level {
         1 => Level::WARN,
         2 => Level::INFO,
         3 => Level::DEBUG,
-        4..=std::u8::MAX => Level::TRACE,
+        _ => Level::TRACE,
     }
 }