Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: adding lints to activate over time #307

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

Freyskeyd
Copy link
Member

Description

This PR adds lints on the workspace Cargo.toml that will be used by sub crates.

Additions and Changes

Lints are currently all disabled (allow by default) in order to progressively add them by refactoring the code.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd requested review from Nashtare and a team as code owners September 20, 2023 09:23
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (2a996fc) 57.66% compared to head (50e5bf4) 57.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   57.66%   57.67%   +0.01%     
==========================================
  Files         228      228              
  Lines       11807    11807              
==========================================
+ Hits         6808     6810       +2     
+ Misses       4999     4997       -2     
Files Changed Coverage Δ
...ates/topos-p2p/src/behaviour/transmission/codec.rs 73.78% <ø> (ø)
crates/topos-tce-broadcast/src/tests/mod.rs 100.00% <ø> (ø)
crates/topos-uci/src/lib.rs 0.00% <ø> (ø)
crates/topos/src/tracing.rs 19.23% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea, I like this a lot. ❤️

@dvdplm
Copy link
Contributor

dvdplm commented Sep 21, 2023

@Nashtare @4l0n50 I think you should do this on other repos as well. :)

@dvdplm dvdplm merged commit 2b7517c into main Sep 21, 2023
@dvdplm dvdplm deleted the chore/adding-global-lints branch September 21, 2023 14:14
gruberb pushed a commit that referenced this pull request Sep 22, 2023
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants