This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add validator id and verification to echo and ready messages #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hadjiszs
reviewed
Sep 11, 2023
gruberb
commented
Sep 13, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 57.64% 58.41% +0.77%
==========================================
Files 228 230 +2
Lines 11807 11998 +191
==========================================
+ Hits 6806 7009 +203
+ Misses 5001 4989 -12
☔ View full report in Codecov by Sentry. |
gruberb
force-pushed
the
feat/TP-677
branch
from
September 15, 2023 13:44
53211ac
to
ac162a7
Compare
hadjiszs
changed the title
feat: add authority id and verification to echo and ready messages
feat: add validator id and verification to echo and ready messages
Sep 17, 2023
gruberb
force-pushed
the
feat/TP-677
branch
3 times, most recently
from
September 18, 2023 19:10
537904a
to
598c58e
Compare
dvdplm
reviewed
Sep 19, 2023
gruberb
force-pushed
the
feat/TP-677
branch
from
September 20, 2023 12:54
2d4cc1a
to
134b156
Compare
Freyskeyd
suggested changes
Sep 21, 2023
dvdplm
reviewed
Sep 21, 2023
Freyskeyd
suggested changes
Sep 22, 2023
gruberb
force-pushed
the
feat/TP-677
branch
from
September 22, 2023 10:34
1e32273
to
2b48d6e
Compare
Freyskeyd
approved these changes
Sep 22, 2023
gruberb
force-pushed
the
feat/TP-677
branch
2 times, most recently
from
September 22, 2023 12:47
c9b158f
to
ad9ce40
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
gruberb
force-pushed
the
feat/TP-677
branch
from
September 22, 2023 13:54
ad9ce40
to
730e2e5
Compare
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing
ValidatorId
to verify thatECHO | READY
message come from a validvalidator
. We also add a signature toEACH | READY
messages. Therefore thedouble_echo
has to be aware of thevalidator
private key (secret).Fixes TP-677 and TP-678
Additions and Changes
signing_key
to theTceConfig
signature
andvalidator_id
toDoubleEchoCommand
andProtocolEvents::Echo
andProtocolEvents::Ready
.PR Checklist: