Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python2 platform #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

wjo1212
Copy link

@wjo1212 wjo1212 commented Mar 24, 2017

Support python2 platform with hacking types.MappingProxyType as frozendict.frozendict (or frozen_dict.FrozenDict)

@topper-123
Copy link
Owner

For such a small project I'm not interested in external dependencies. If you will inline a frozendict implementation for python2, I'll accept it though. Also, I can't find a frozen_dict module on Pypi.

Other changes accepted, thanks.

@topper-123
Copy link
Owner

topper-123 commented Mar 25, 2017

On second thought:

If you want to, I'll accept a pull request, if frozendict will not be downloaded for python 3. So if it goes into extras_require or a python 2 -specific requires, it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants